From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6A9D23858D28 for ; Wed, 21 Jun 2023 12:55:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A9D23858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687352129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rN175tapQyd/6LBtqRegnu09A6ewQ6AXGKpVvZOyzkg=; b=ZmQyd47o/Zvd4JiuyYgt1sZwxEwcAq9DcY0zAQ5i4jMxOZQqsdmgBKkGdw4dnLz5hBo7lg ulkCfrcRhVaqlpQVl9nG6y3WfweExlZLcwt04whAx9nqzPYlqvDWclZU0tjoo+Q5Rp0okW 3X91tM/fNQUrPsf5tEosNs1NbgEDz58= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-460-VMHUCIdWPP6yHpAZiyV1nw-1; Wed, 21 Jun 2023 08:55:28 -0400 X-MC-Unique: VMHUCIdWPP6yHpAZiyV1nw-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-3f9dc388636so80074291cf.3 for ; Wed, 21 Jun 2023 05:55:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687352127; x=1689944127; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rN175tapQyd/6LBtqRegnu09A6ewQ6AXGKpVvZOyzkg=; b=e+jB2LAd00MniHXpX3tlNPUZq8FB6jShNX2fW9gcwhHEHF+5NtOxKhpVpOP+6X1PSG 1myldpxfls7qW/Hrm/WWRrYP0i08NJLT3gVUfQn8YItAwKz/+dB8Ui+IvSbpwpt49smB bNl4j6loEpYXnlcDttFiTqZqpmhtpVBCiMMcasMCJb6B4KjZfOFSwgMElx7bFVJXYBNI lxkcor7Nrv6MBfkyrEz9GXAab7zhOYf/NtWIaw+jLIgzuSJhRES48UJTPdxVoEHSdYtj iITJHDJfYjAxwU2/4Tb/qb1b+od86uI/K9m/YxcT6H9OIA84jhuYussLWaGM4N6oZClM mAHQ== X-Gm-Message-State: AC+VfDzXzavhhTA4M4jRvfJOX5wpWcsLasCfXgjWmhOSlhPwyRGStLWy Wx9P7qF1HBgUb4zW/EB5208SXDDa0oWEXNhv9VTmY8upQJvF5rtKV7I4HcWXkJV5UsNV1+PJTJ7 7xcu0IEhm4bJYEGlogZY8ySCDNhEhDQ== X-Received: by 2002:a05:6214:1bc6:b0:626:31ad:f873 with SMTP id m6-20020a0562141bc600b0062631adf873mr19735117qvc.24.1687352127382; Wed, 21 Jun 2023 05:55:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ751HHNdiRZQXgQ22j9R6dMe5ILd6L5bzyDU3pPXGJgIvYbDMzqVZER41mwFbZA2ewvDRJ43Q== X-Received: by 2002:a05:6214:1bc6:b0:626:31ad:f873 with SMTP id m6-20020a0562141bc600b0062631adf873mr19735105qvc.24.1687352127079; Wed, 21 Jun 2023 05:55:27 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id c9-20020a0ce149000000b00630228acc55sm2418474qvl.118.2023.06.21.05.55.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 05:55:26 -0700 (PDT) Message-ID: <28ec469a-e3d4-d284-0785-02c93c21246e@redhat.com> Date: Wed, 21 Jun 2023 14:55:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 4/4] gdb/doc: document '+' argument for 'list' command To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20230621104545.2530552-1-blarsen@redhat.com> <20230621104545.2530552-5-blarsen@redhat.com> <838rcd5arg.fsf@gnu.org> <83352l56jd.fsf@gnu.org> From: Bruno Larsen In-Reply-To: <83352l56jd.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/06/2023 14:44, Eli Zaretskii wrote: >> Date: Wed, 21 Jun 2023 13:20:54 +0200 >> Cc: gdb-patches@sourceware.org >> From: Bruno Larsen >> >> On 21/06/2023 13:13, Eli Zaretskii wrote: >>>> \"list .\" lists ten lines arond where the inferior is stopped.\n\ >>>> +\"list +\" lists the ten lines following a previous ten-line listing.\n\ >>>> \"list -\" lists the ten lines before a previous ten-line listing.\n\ >>>> One argument specifies a line, and ten lines are listed around that line.\n\ >>>> Two arguments with comma between specify starting and ending lines to list.\n\ >>> This part is OK. >>> >>>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >>>> index e4e374d138c..f9c3c90e16a 100644 >>>> --- a/gdb/doc/gdb.texinfo >>>> +++ b/gdb/doc/gdb.texinfo >>>> @@ -9149,6 +9149,10 @@ Stack}), this prints lines centered around that line. If no >>>> @code{list} command has been used and no solitary line was printed, >>>> it prints the lines around the function @code{main}. >>>> >>>> +@item list + >>>> +Same as using with no arguments, but errors out if the line is >>>> +past the end of the file. >>> But here it looks like some copy/pasta error? >>> >> No, this is the main distinguishing feature between "list" and "list +", >> the latter will error out if it is past the end of the file, while the >> former won't. > But then these two descriptions of "list +" describe two > seemingly-different behaviors: > > "list +" lists the ten lines following a previous ten-line listing. > > vs > > @item list + > Same as using with no arguments, but errors out if the line is > past the end of the file. > > Or what am I missing? > Ah, I see what you mean. I thought that the help text should prioritize being short over being complete, and I basically modeled it after the no-arguments help text (With no argument, lists ten more lines after or around previous listing) whereas the documentation I thought was important outlining the difference. Would you prefer if I made the help text more verbose? -- Cheers, Bruno