From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00048.outbound.protection.outlook.com [40.107.0.48]) by sourceware.org (Postfix) with ESMTPS id 1D8243858286 for ; Tue, 20 Sep 2022 07:36:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D8243858286 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Bq9ytAqVt9lCGwzwGnXlBSOTJMmz0MlWpJZDUhFvpM334pjlXuCSNz1jlQ05rEP4c5v/KPNhrdMPMwzHg8eykSkFyu20ia3qWmTCPtIxzhWBtBosWhA5HmGcodfH8ExdONw/F6z7x3/Zt2VVJJlomEWWkGLGLjGYJCOjWz5CfJnzQ0b2NOYN859M2pcnMEppcqetlbtiCZCXFjCBDqlCtk4dUNXxaxuN3p8rLP/Eq+7sHJt2+f3x7LOEGgu0flRAHO88mkSaufPVnbYYVyRWvGwFtW1XjeEM29YKl77ejrrsJS4r+o26rryLiVyzXFoXpkiVVHe1X7AEoo8ZAlVZeQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bKIFOZChuWKPEqrSVgwDRJB9PMKntFtT2wkKZJq2ufw=; b=fDCrIwPKs2vphy2doII4u1pDEGu2EsSIGBDMcCc++HvmDLIzuioxxwEKVjCQjSVcG4YyS8YeKLZBNSsiA65wfbtu5RiFrGXNYNbYE+rR3ls09pufJ0gTQWTGc6EdYbTJoJ6RNRjGqeVLZtzOfRhaQ7xqJv9Q8FtwEWmFePOEgf44447EqgXNARZaUCkGerZtLYdFgFN8XoeUYHYMXoVfGRpx6CRCZO/QmHg0WO405u+diqM6tEe/sQ+kT5aav/n9N1aAXiMg/ZM85W4lIFt++d83SbDicCd37CdHTsBtpN67FGbgGLxW+Zbl3SjESWoyAUQkUnpG5W6o48cmDEY4rQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM6P191CA0092.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::33) by GVXPR08MB7752.eurprd08.prod.outlook.com (2603:10a6:150:6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.17; Tue, 20 Sep 2022 07:36:45 +0000 Received: from AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::5e) by AM6P191CA0092.outlook.office365.com (2603:10a6:209:8a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.15 via Frontend Transport; Tue, 20 Sep 2022 07:36:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT049.mail.protection.outlook.com (100.127.140.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.12 via Frontend Transport; Tue, 20 Sep 2022 07:36:45 +0000 Received: ("Tessian outbound ee41cdb23966:v124"); Tue, 20 Sep 2022 07:36:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 20da13ada9577911 X-CR-MTA-TID: 64aa7808 Received: from 9c0ebcdfb236.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C6D4FEC5-8629-4EEA-9F14-D1E89E5CFBCC.1; Tue, 20 Sep 2022 07:36:37 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9c0ebcdfb236.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Sep 2022 07:36:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=POE0sedNbAG1pKysJ4cnZumPtb8MHNyc5Oo8YKuaMfPOtNdt03CCYyUCX3DaxD4eNI6HUsiH60+OHmd1LFlLs1czLCKrx8qk5QzyCKSy9+4loCo9yGcWeAR/B9dN2XLxL+UFtsFa/gyQQ50Wp/1XBc/zSu3edJ4os+wCkAhuA2MUkO3xKBYVYsyAPB3Ohtlq+SB72dD5aDwpMvHWABLKzKAGuJ9V9E4ygXZFPYJIPtS21b71t88rcFAhW9U3rb7PL2Da3/g7M20dJFVv9JWBz7j4DWvneNk+01H7jaPHxhxk6cZBW22AAsuM1oE89dN0fPF5DNpJE5tkt4b/+M9GrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bKIFOZChuWKPEqrSVgwDRJB9PMKntFtT2wkKZJq2ufw=; b=IaggeYfPIZji6qUigloLluQWVlpMi/AjTjvib9xi5OgRusizi6rsKD1vtSk9S99yYU53P5pFMSbESUzSNSynXNRidfFhsGXfP2xBv3/kZuNmL6vqaHWYQ+/6+YDZxRioFI35LfxSMnpweq14cJBvbqZSQAVT8Gjpuq26p+lVdlmaXQrzsNLZlVA4t6sdev5jr6Pf0wOzJ8MtsYxWZ8ePcqUF/4QAcRmrHfM/EqgxNrEsDEOJLLlbpMBPVIoRqFsvkdVtqLyuHrHv5QzoD3mddrejxSENTwzZQSDmCB4Io4SLHfz7dkiyT7ZvpPwCLF3tyJsA2Bdau/Kojy/TASWs6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS2PR08MB9342.eurprd08.prod.outlook.com (2603:10a6:20b:599::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.16; Tue, 20 Sep 2022 07:36:36 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094%5]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 07:36:36 +0000 Message-ID: <2912eb5f-44e0-9aa4-50d1-61af7d09050d@arm.com> Date: Tue, 20 Sep 2022 08:36:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/8] gdbserver: Add asserts in register_size and register_data functions Content-Language: en-US To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20220908064151.3959930-1-thiago.bauermann@linaro.org> <20220908064151.3959930-2-thiago.bauermann@linaro.org> From: Luis Machado In-Reply-To: <20220908064151.3959930-2-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA0PR11CA0136.namprd11.prod.outlook.com (2603:10b6:806:131::21) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS2PR08MB9342:EE_|AM7EUR03FT049:EE_|GVXPR08MB7752:EE_ X-MS-Office365-Filtering-Correlation-Id: 5bad55bc-55fd-4643-f4d3-08da9adade5f x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4JhLcBLpI+HUQUtLlyNWnSFJwcdBi4YBIMlCJRjpUc1fMgYoLaXIJH9iWK8zEQXbb5h7cwfKhmAWQ10/le01QE/5lcnIVWm2BsalK56j1SoOt1vgGUBAizL/7VrDIusNYcaMvjZJLhmLyPvnmIfO6utaLVKjfGq+uHjJckrNCp1wmZQnQ7PvRSUyAQA+CfOxS9l3cCGNWbPb9M9gQFJ2Sm9XsmTP2If7y8Vvz5xudobT95Jndrhf8ei2PMvMWk3Ev50Z9EBaBGkOw/3N29swc7wbpD4UKXypAaM5tl0FDyHF8BJRxNzkG0rCd9LyyevpokIgTuejUPTVj6nuYmSg4uLXIQYZX8M3eyVCpI0jVfn74NLr+nxG+bpFOq7/29uipFJA3AEtfvyA4Ls+1A1mgCBPgdcy4/jh2GFldziHNui79sawm7YuiAVFla1drofCwLycnMdcN//nqmzfTOv6eR586XScfn/Yx69+RDqzrTz0PqAXAhgsh9uwxSTjjc7IbQhZnIh/qGxuuUFklIESjmb2uCeQTOCeWBZMw6Tdc65xYfwTx3Thg6ifzx16+HMRQRN0jth+nHtjrC29JYuBaxPceyeAcw3lb+SSnooHRcJdQK8k8Bn2jCnaCQXZtSDOS3MVX+m0GD6mgF1+BHycukWoLhDMKnCML5cSqnZLzFefVx/Aj7h+nGTEIqqhPWkbzXTRwXKGsr/4f+13PanXge+x36/mFl4y4HUaQYO/XSHrlP9k+1PRreVcoMFRZ/AqtFThadNKe+qpx8xLyp4NiITl7KabH0NPKWqp5T3kJNc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(136003)(366004)(39860400002)(376002)(396003)(451199015)(6512007)(66946007)(2906002)(8936002)(6506007)(5660300002)(6486002)(44832011)(38100700002)(478600001)(41300700001)(316002)(66556008)(36756003)(8676002)(66476007)(6666004)(86362001)(53546011)(31696002)(26005)(186003)(2616005)(83380400001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9342 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ac7611c5-6f9b-4a2d-4a6b-08da9adad8c8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AyBT0ecJzVXcVBRmhFgPVqtjrdYtlODEgd8xb/4XHcBKcUyB6q+R3o0w/vMQc2xqfcGso0DI0sKuBxU5A05fUfeCK7TFhnWeD/KgeEuMVp/7IR4YQgYirPSPW1/A6d8N/az3Pb4S6w6Zk/wpxoFUfiO4GMYIXkp0GEJpigvqSdG45vwEsNzM+Pi51aXFwTiSF8lKlAoTtXFEUo6KcxYGW56YjKjGd07yNgvSpCOvZ1Eeq1jCGArcqByOgxSZu3GecWKPZhnQFTcb38Kd+p62DDprNtrEodQwEZVw+TcIevBzc4lqKZZB52OOKhaNgHD51bCfMoSrfb8pBO9uJ8W2OyTZ5PW4RcJE7RwfvaSnYG3N4CMuBtz78okH0pjQR1+SWu6DU5xiIaxaBU/rSbULKagmrCg4BvfGkDbV/nsszeOJnrECMAYn1oNH7cTXwhAbqLWkyB052Mq9Mlvslk9Il8f7bxDoQ8JA8ds/zqPaxmxpKbw3kQQ/FUgw2QUAOSHceyviyUaRD9PZG9VKsSvXuj/4MTf7M7Ih+X/mtuOZO3kN1VQWltcQL+gp72c7TeydWOQLZkv2cc0Ft0FOsqup0IjZmN8eh+SGoLe9yappIXy0TdLoxBF0ihz2i17PuYU1zzzDnOhe94xnl/suOL06eBNkdPHqPIsWeuSxtEouTkDeqT5lxenzlZ9pM8HgFrmkz037C5kLA1OA1NxT+Aox4p12XxIcaeVOqs8/Xd//6TpnUUEQY+9h34hRZlF5IDADHIR+Fq5Saf588/cKTg0O3wmLiqt8i54mNmL0TA5K+aI0ApxZYhpVAAO50+LrJmwR X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(346002)(136003)(376002)(451199015)(36840700001)(46966006)(40470700004)(86362001)(31696002)(81166007)(36860700001)(82740400003)(356005)(31686004)(36756003)(26005)(6512007)(186003)(40460700003)(44832011)(53546011)(2906002)(5660300002)(41300700001)(6506007)(478600001)(6666004)(83380400001)(6486002)(336012)(47076005)(2616005)(70586007)(82310400005)(316002)(40480700001)(8936002)(8676002)(70206006)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 07:36:45.0100 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5bad55bc-55fd-4643-f4d3-08da9adade5f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7752 X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2022 07:36:51 -0000 On 9/8/22 07:41, Thiago Jung Bauermann via Gdb-patches wrote: > These helped me during development, catching bugs closer to when they > actually happened. > --- > gdbserver/regcache.cc | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc > index 27491efc52d5..ebaeb5e86895 100644 > --- a/gdbserver/regcache.cc > +++ b/gdbserver/regcache.cc > @@ -286,6 +286,8 @@ register_cache_size (const struct target_desc *tdesc) > int > register_size (const struct target_desc *tdesc, int n) > { > + gdb_assert (n >= 0 && n < tdesc->reg_defs.size ()); > + > return find_register_by_number (tdesc, n).size / 8; > } > > @@ -300,6 +302,8 @@ regcache_register_size (const struct regcache *regcache, int n) > static unsigned char * > register_data (const struct regcache *regcache, int n) > { > + gdb_assert(n >= 0 && n < regcache->tdesc->reg_defs.size()); > + > return (regcache->registers > + find_register_by_number (regcache->tdesc, n).offset / 8); > } LGTM. Someone else must approve, but I suppose it could go in on its own.