From: Simon Marchi <simon.marchi@ericsson.com>
To: Tom Tromey <tom@tromey.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, <gdb-patches@sourceware.org>
Subject: Re: [RFA 3/6] Allocate dwarf2_cu with new
Date: Tue, 16 Jan 2018 15:04:00 -0000 [thread overview]
Message-ID: <291f71dc-d6cd-f9fa-1da4-f949464eedd0@ericsson.com> (raw)
In-Reply-To: <87r2qxispc.fsf@tromey.com>
On 2018-01-10 11:28 AM, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> This is gone with Simon's changes; I'll update the ChangeLog and send
> Tom> the updated patch.
>
> Here it is. This went through the buildbot the second time around.
>
> Tom
>
> commit bcaf61d8ff6a149785924223151df8ded30e8d7a
> Author: Simon Marchi <simon.marchi@ericsson.com>
> Date: Sun Jan 7 11:41:09 2018 -0500
>
> Allocate dwarf2_cu with new
>
> This changes dwarf2_cu to be allocated with new, and fixes up the
> users.
>
> 2018-01-05 Tom Tromey <tom@tromey.com>
> Simon Marchi <simon.marchi@ericsson.com>
>
> * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
> (dwarf2_per_objfile::free_cached_comp_units)
> (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
> (init_cutu_and_read_dies_no_follow): Update.
> (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
> (dwarf2_cu::~dwarf2_cu): New.
> (free_heap_comp_unit, free_stack_comp_unit): Remove.
> (age_cached_comp_units, free_one_cached_comp_unit): Update.
Hi Tom,
This LGTM, I just noted two formatting nits.
> @@ -7932,7 +7904,6 @@ init_cutu_and_read_dies (struct dwarf2_per_cu_data *this_cu,
> if (info_ptr >= begin_info_ptr + this_cu->length
> || peek_abbrev_code (abfd, info_ptr) == 0)
> {
> - do_cleanups (cleanups);
> return;
> }
You can remove the curly braces here.
> @@ -8090,7 +8047,6 @@ init_cutu_and_read_dies_no_follow (struct dwarf2_per_cu_data *this_cu,
> if (info_ptr >= begin_info_ptr + this_cu->length
> || peek_abbrev_code (abfd, info_ptr) == 0)
> {
> - do_cleanups (cleanups);
> return;
> }
Here too.
Simon
next prev parent reply other threads:[~2018-01-16 15:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 0:26 [RFA 0/6] Some DWARF reader polishing Tom Tromey
2018-01-06 0:26 ` [RFA 6/6] Remove symbolp typedef Tom Tromey
2018-01-16 15:33 ` Simon Marchi
2018-01-06 0:26 ` [RFA 5/6] Remove objfile argument from add_dyn_prop Tom Tromey
2018-01-10 13:01 ` Yao Qi
2018-01-10 16:32 ` Tom Tromey
2018-01-16 16:00 ` Yao Qi
2018-01-16 15:33 ` Simon Marchi
2018-01-17 17:16 ` Tom Tromey
2018-01-06 0:26 ` [RFA 3/6] Allocate dwarf2_cu with new Tom Tromey
2018-01-10 12:17 ` Yao Qi
2018-01-10 16:14 ` Tom Tromey
2018-01-10 16:28 ` Tom Tromey
2018-01-16 15:04 ` Simon Marchi [this message]
2018-01-17 17:10 ` Tom Tromey
2018-01-06 0:26 ` [RFA 1/6] Unify new_symbol and new_symbol_full Tom Tromey
2018-01-07 5:33 ` Simon Marchi
2018-01-06 0:26 ` [RFA 4/6] Change dwarf2_cu::method_info to be a std::vector Tom Tromey
2018-01-16 15:30 ` Simon Marchi
2018-01-17 17:15 ` Tom Tromey
2018-01-17 17:29 ` Simon Marchi
2018-01-06 0:26 ` [RFA 2/6] Allocate abbrev_table with new Tom Tromey
2018-01-07 5:29 ` Simon Marchi
2018-01-07 16:55 ` Simon Marchi
2018-01-09 18:56 ` Tom Tromey
2018-01-10 12:02 ` Yao Qi
2018-01-10 16:10 ` Tom Tromey
2018-01-10 12:45 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=291f71dc-d6cd-f9fa-1da4-f949464eedd0@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).