From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32555 invoked by alias); 16 Jan 2018 15:04:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32545 invoked by uid 89); 16 Jan 2018 15:04:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=simons, Simons X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Jan 2018 15:04:04 +0000 Received: from ESESSHC011.ericsson.se (Unknown_Domain [153.88.183.51]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 96.50.13339.1641E5A5; Tue, 16 Jan 2018 16:04:01 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.51) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 16 Jan 2018 16:04:00 +0100 Received: from [100.94.230.5] (129.192.64.65) by DBXPR07MB319.eurprd07.prod.outlook.com (2a01:111:e400:941d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.9; Tue, 16 Jan 2018 15:03:58 +0000 Subject: Re: [RFA 3/6] Allocate dwarf2_cu with new To: Tom Tromey CC: Yao Qi , References: <20180106002621.21099-1-tom@tromey.com> <20180106002621.21099-4-tom@tromey.com> <861sixhprf.fsf@gmail.com> <87vag9itcu.fsf@tromey.com> <87r2qxispc.fsf@tromey.com> From: Simon Marchi Message-ID: <291f71dc-d6cd-f9fa-1da4-f949464eedd0@ericsson.com> Date: Tue, 16 Jan 2018 15:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <87r2qxispc.fsf@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR0201CA0041.namprd02.prod.outlook.com (2603:10b6:301:73::18) To DBXPR07MB319.eurprd07.prod.outlook.com (2a01:111:e400:941d::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45939f26-481e-4539-323f-08d55cf25fbf X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020);SRVR:DBXPR07MB319; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB319;3:aMiP88O/iTH2LGUEUr0wxYWl4yK+i74nYmVAket8ZO2ukyB4JCiuikUPTscHZiBRRAQE3FoZfNRwzbMktkxWhsRkpx7qgOsjmJb80KEROyDUcYUKTPyxNvPGjvj84s7bNami0z2FbmVB80xOQceIYBoCk/aDSVkvycbUDRtdJ92/vBVsJXl+rv+GyRQdUejJHpnaYpxWp/4mR2gMQ8Z8n2pDxZKUoTFvqGDsnLBE0uXXme0NMbWyIgih+SNHLo+k;25:x7FjpFtu/DjNVusPl5JNI8T6M7GcPPoY86YI5JqtelT0wTNY10L+3XAhDl+0xxeKmg3tBIpQmcVtVlBQRaazWGovXjESaUYp3OI6pYd/+An/xyGelQwa6C0IbhflyKEQnZGYfozXAjLYE0AFJpcOQb5AssZF5VZZbt8OuGbYNZLQiCbIU3cpV7e8+MF9H19lsJ2qrIxLi36AB9gPb1+RpNRy/wg85yvsVSOqR3cBNJYkeD+VfHoK6v5jAB0kaNlUWsAgoxyPA5L1qxe9IyJJJnMRC0pLm4NZRg4iiYNmnxLjvy7oQP70dZQbHtkGKlcWnVV3jshuRxVYx966r78KTg==;31:KH7z6s+mTb0SXsvjvAVKJ+JiTYJrDnTC4IGZqKSH3pTP6i8tKyR/7zcRXdSuJY273KXTrMugZbBlgnuNIyuD6BmT0d0qwPaV7eTaJ6brOHlAJyhm6hUUk3m3c409eQ2g9/cYLRZIeckMcQsfK7bQjxR27YssBRcjZRd6DDf6Q9BCPWs1+EpQo6N1w+fkhpMsqA+YRc3gYZvt3xf83dVPNRuab2Ss4YDgAa6lbXvJWaM= X-MS-TrafficTypeDiagnostic: DBXPR07MB319: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB319;20:J0wECw3CbpGC1Ajs8G6F3EEZ5bTYxOucGXBUjI4xxRm6L+qLIpYjpu2NWQSXEoPh7tYyZa3ypb2VrrdoNMj670hB2IIjDZiV9UyhRK/vwiJOqOVZO17dYNEKqVADQnKFnagbf65ZmCF99W/kpySpkPuXZp07GTgS42t3/l6idUBpDNLeI9i22PzQ0y7FtVZvw6EwUQD7AWtaFAgqiOsadQEEcnchN5iedURdmseFpWMCjvU3Fl+zyFDQQl1g5N2ba69I4sUj12Kg2HCjx6btCqliV1qift0E17LdAOnJKIIC3vA94VBJIh9SQ70NymhWHEKHicsgl67erNExqkprVRH5vz3Ugku4Ck41SJAlb3FLOCGX8rh8j3EdwOi3K6E0cbMqZ9f0JjZmAb/315YSSD2U9QuZPz9hm3le6lmD5Ez6cI5AOojqYbEoDpuRV05I7OpiYkwtFiGnY4tjkXZAeTWPUj+4dCsfbXU6NtWwexdLs3f0LKtI548wcsUzkvqs;4:dqbF+XAz4k/X7fF4xiZ4YVtttcCwCXnKGgtscTIm/A4zcotxkHm0DhwFtCW8aiTuxrQcKb/D1vlXlyfNBx87ztmT2fOVlBQ5Di6c4O3XjzsgQAfq7zn2lNkccKyNtpHXzj7JRGz5lbCQLZzLuDc3iVBeRp5dAKSRnJm9qOsNmw+BYcjd36o7pb8USPFVnfUfLGJs3NQLd5eqGQi22DwKjAYkf4zpGNJN71Ggbym8VumnVOXpmFaDU0awKGU9dD8JtKfUSTFO5uzQMRnswomigBvIQI09MCOKhzxe5C6UHkAAhvZjjSRsE22ZXgCUsVGv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(2400036)(944501161)(10201501046)(3002001)(93006095)(93001095)(6041268)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011);SRVR:DBXPR07MB319;BCL:0;PCL:0;RULEID:(100000803126)(100110400120);SRVR:DBXPR07MB319; X-Forefront-PRVS: 0554B1F54F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(376002)(39860400002)(346002)(366004)(396003)(39380400002)(24454002)(54534003)(199004)(189003)(377424004)(230700001)(31696002)(16526018)(26005)(25786009)(49976009)(64126003)(68736007)(47776003)(65956001)(65806001)(66066001)(305945005)(6246003)(3846002)(39060400002)(7736002)(6116002)(4326008)(31686004)(83506002)(478600001)(36756003)(50466002)(86362001)(5660300001)(105586002)(65826007)(16576012)(52146003)(52116002)(2486003)(6486002)(81156014)(59450400001)(8676002)(229853002)(316002)(106356001)(58126008)(8936002)(2906002)(53936002)(81166006)(76176011)(53546011)(23676004)(386003)(97736004)(93886005)(6916009)(2950100002)(6666003)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB319;H:[100.94.230.5];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzMTk7MjM6OEo1SDdpeVUwSEUwYmdHYXJZNFAwbE9Qc1ll?= =?utf-8?B?TWFteDc3NDgzempLOWRqWG9HQWh6bnNvdjBEUG9SZS9Zd1FwV1lJakxTVG5s?= =?utf-8?B?VDV4c1hmWXllTDNCamtWa1YwNlJoMzA4RVA5akNXMlYwVGM4T3QyWmpPc1Ni?= =?utf-8?B?aTBYZTRqSHFIMjAxSEYzc0RRUHBZZ2doalAvbFRIbW9yZmVpTExMS2FMbnlD?= =?utf-8?B?RUN6bmN0MFU1MFpnVGtGamFMK0NHSDVVYW03cU9GTG5rL1JMbFAwQlVPK3gv?= =?utf-8?B?bEtWN0JmTEkxSFY1WVNGOGNWYUV3M09SU3ZkUkQwNFJ4UlZ3Q29wY0JnOXQx?= =?utf-8?B?WGdkQmVFZ3FsRkp0ZDM2dHAvZ2JvM3pSU0U3VE1ISGVGSmQzUGFmTkpXd1Rh?= =?utf-8?B?dHl2eGdNelI2R1BZeTNNcUR6ZStpa2tqVnB1OTRPSGNMWWE2MUZHNWVoU0pM?= =?utf-8?B?bTgzUk5pYjFqdXN1bVI1RE9XZmpMbDREdno1ajBISWVNQU5wMnFZb3lQQ0Nl?= =?utf-8?B?SHNveDdSUmIxS2VRWCtOQ3BlSStwQSt2Q09wV2tIOG9CNjVzbFhnaUV5ekxl?= =?utf-8?B?TTJQQTlnQnVheWcrUHE0QW9HOEdPRlpINU44VFNDdlBpWUJnMTBZejcvOXhM?= =?utf-8?B?b0d2eHBsUDB1VUExZitRTlUvRTU1aUVvVmRQSDhRdXB2V2V6TytKYlM2VXV5?= =?utf-8?B?bXROUk5RUGUreGZWMHFGT00raVRHMmZ6OHpjWVpZRzEvYkYrTkphZEVqelpp?= =?utf-8?B?aGJ6Uk5NWC9pRm9xQThaMXpHcWRFWitKcHJKeUpmRk9BaEZoZUFUOVg1aWVl?= =?utf-8?B?bnR4dTFXSmZBZld2VzA1Z2lMVUpnWTdRb3VDT0NiU1Jod1k2Y0U0cDBpK2cy?= =?utf-8?B?WkYwYWh5VjZBU2JEdEI3OWNORml1RlUwOVF6MCsrWHpFMFI2M0ZCUFB3cUZS?= =?utf-8?B?cXJrc0Y4UWpXbnpsdit1OTJDUklWSytaN2NRcFhUcHVCN0FhWlR4d1NGNUp4?= =?utf-8?B?eEFhV3ZzQXV0WWE1UVhkK3JOZTlPYmtiQ2ZNVHBoNHZEZkp1b3g3ZVFtY25H?= =?utf-8?B?UG9USkswbnNPMU1tenUwQ2NwWUhSTytoUzVxUmJ6S3hQbzU0aUsydUwxQS82?= =?utf-8?B?bXZEL21UUnZzcEVhQWdYOGR1NWkrdVA2Z1FZSzhiakdsNi9rOE0rSkpncHUw?= =?utf-8?B?YmZRWEpoemJtUjVLSnNNMUMwcXZrNEZHZFdQWkZSN2pjMExGbDJwZGd3Y1Jy?= =?utf-8?B?RGk3RzN2UFdvbFhZdmlydWJmTnlhRlRPcEV0bjcrcW5pMGIrbUx6dnRWU3g4?= =?utf-8?B?eFB6RGhOT2xXQ05nWWR5bVJwckhNWHE2aXd0eE5VOVdJRWlDQnpRblIzeTlB?= =?utf-8?B?YWhIaUR5SGpadmVGNjZTTVlvci9KWVBZZFBqTm5aRW9aNHNsTUtKQ2RHOXRz?= =?utf-8?B?U0o0aXJGR1JEYnNsRnNRbTNsTTZaTjZGbno5YlphaXpGV1pjY1dIL2h6QUVk?= =?utf-8?B?bmZheklRVVR3L0orT2xMTWtpQXpDTDBNaHcxbWd5L01mWGRFUFZqK1R1alRw?= =?utf-8?B?aU1mcEhKSFN3LzRiUXorRUJEVFdhZTNGRHpsMEk1c1BCTzBxdThYRXFnd1p1?= =?utf-8?B?R1FVN2hRbnJqL1dWTWFCRzFvK0lKbFJicmNlV21YN2VkYXBSVzRyaERuZ2tq?= =?utf-8?B?cTB0OGdsaklwblVwdlpGd1lsOE04OWx0cWVrREpBd1A5T2JQZVc1aTdSVVU3?= =?utf-8?B?dlFlOGtRUFJSMFBITHRmNmVvM25URnd5ZncxZ0Z3Ny9ZamlQemw2NWNteTNh?= =?utf-8?B?amNTNElSNTJUbDgyWXRtZlUxMy9mU3l5WWhJUWxMQnFpR3locGI0aHNTS28r?= =?utf-8?B?VFB0ZS92dEVPWUE0dHYzcGVSTkllUmo4YzQ2THNMUzdPeVBFRHFMSmpYYno1?= =?utf-8?B?WVIzbmd5Q3p1R2N5ekp0dG41UVQ0RFNEd1hVR1pORlI4cGxGanFRV294clJP?= =?utf-8?B?Z1pWZk9XakdXSjAzY0dzWnFSd0xjNnB1NUs1UnZZandPc2NSOThCWlRzQnUr?= =?utf-8?Q?4cw=3D?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB319;6:zP9Zs1/rmF2sgHvR/Mj3E0mZNNO2qWI2FsyfIgPqiXGHLFa34lv0VleIIt+rWVMpOtk0R10fQssXzAG5Lu94VwH3FT7NM+HymNOHL5WPGzYR/+LhJPWD0orguup12wpaFmcUfsn9TcaBpnRJ1l8OxFyubsL0jxUErC3jaRx78gROAPDIinH6gkJdCMtuTf34/3Lj9+iOHYsS95Rob8tQc4WhOTTWlcOAomDj08jNPlgQzGOpeaZ0QhvLZFPOxgHvTdHm+7E51ani3OS/ZthRtxDoqSkN2crgLjlrJN78tdf42rjbE27myE4L4ygt6uJBe6s11tx44oUaCh2teTz8xz/ZmlH7gOwovbcxBIQMNf0=;5:aqdOaAYEQZYmpNfWkzJo1pGxMBzmkuf/1hSb4ejG7U9ID3xMmrENGpOaRN7hAwo0G/VeXj6bk4bb2gE1wiP0zs/rCSajP7wFfNiQoBTWCygNjwoeFQlSWSI2LLFqiP3v7VtNsAqO8Zxpzkf3jU/Cpqod7AAfHZUlpK3vn2G6xBY=;24:+/vJcSJ9cOIttxCc5u8GPXAD2c925nj12Kep3/l+Cnumcq47IdkCWv2joXI4mFCoqV+vjUdzFEnsIRzb/Pfc72GE6aGqfcmO+b3Uwl9Klpc=;7:u0oXhtCavrlwWwqRtSV3Vt4lljqRluBiBtLiOi4efVWFmp/MSW94OA8lapMEDPrvKXxmdlQJdvOc91tYbZcf9jlxnihNaYAFukl7POpIRBjQCi6Wd0TGaql6qLliLMcIg5zk7nRxDrzCUwOVS/9Qk4oaFbw0lDsvC1MU95cQ/RadfJdetl49sE+UTe9otY7xDfpQ8cgzoe0iUEX6OGG+Vu5tG50EuGGctiNB5G/E4MVouApLdklIbY79JdfMyxB5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2018 15:03:58.5531 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45939f26-481e-4539-323f-08d55cf25fbf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB319 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00297.txt.bz2 On 2018-01-10 11:28 AM, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> This is gone with Simon's changes; I'll update the ChangeLog and send > Tom> the updated patch. > > Here it is. This went through the buildbot the second time around. > > Tom > > commit bcaf61d8ff6a149785924223151df8ded30e8d7a > Author: Simon Marchi > Date: Sun Jan 7 11:41:09 2018 -0500 > > Allocate dwarf2_cu with new > > This changes dwarf2_cu to be allocated with new, and fixes up the > users. > > 2018-01-05 Tom Tromey > Simon Marchi > > * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor. > (dwarf2_per_objfile::free_cached_comp_units) > (init_tu_and_read_dwo_dies, init_cutu_and_read_dies) > (init_cutu_and_read_dies_no_follow): Update. > (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit. > (dwarf2_cu::~dwarf2_cu): New. > (free_heap_comp_unit, free_stack_comp_unit): Remove. > (age_cached_comp_units, free_one_cached_comp_unit): Update. Hi Tom, This LGTM, I just noted two formatting nits. > @@ -7932,7 +7904,6 @@ init_cutu_and_read_dies (struct dwarf2_per_cu_data *this_cu, > if (info_ptr >= begin_info_ptr + this_cu->length > || peek_abbrev_code (abfd, info_ptr) == 0) > { > - do_cleanups (cleanups); > return; > } You can remove the curly braces here. > @@ -8090,7 +8047,6 @@ init_cutu_and_read_dies_no_follow (struct dwarf2_per_cu_data *this_cu, > if (info_ptr >= begin_info_ptr + this_cu->length > || peek_abbrev_code (abfd, info_ptr) == 0) > { > - do_cleanups (cleanups); > return; > } Here too. Simon