From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2055.outbound.protection.outlook.com [40.107.116.55]) by sourceware.org (Postfix) with ESMTPS id 93B8E3858D28 for ; Fri, 22 Dec 2023 16:58:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93B8E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93B8E3858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.116.55 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1703264309; cv=pass; b=frrU4N4XrseD52hBgOl2dXD95ok9I0V9/2h5kWSPjPM39H/CF/P0u3Yyl4CbXbInVEj5TuDlCAwDOsPNOFw0URAxMNUZbEvtOQZFV8VzdKEY2sQPjzXp/2h9LcmbMnp9M9dG1oOWUqrwfpS2yFhyzPKO2tHRMYxdFT2fYqiEWrM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1703264309; c=relaxed/simple; bh=npcWhQ7UBFeyVzzG8GzEkD608Tz3CK3ZvWp8rx5clWE=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=mgJd17vh4LGJfs7aTCuC28LZpTpoYrOI67yTSblWj69aQRPDfX+3/O/8aFEU75QRo54V/gttVJR5Xir4LGHjZg9yipQJ5QZHXeyE8kQm3rd+vFGOv7JeRJnSHLq0ZTdPd9INyNT2xEpeyQLyco2oP71khUzqtu6kOPSoT27FaKs= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G6k9bV1nDaF1Mzsh5v9nZQeXQACfUK5sNATNhZkqmOZZBenfl1fPXo95qxYH3OcovunaXZm2JN8WlqJTVCGVFoN+TqIZghju71ehefwwgxKo0W0DKMC4YjnCbOfExyQP/FOihd7Lgaas8X6oyLbtI5TJrZ5jJbNYUvY4YmSXQ77t9HLWFruiuxg75XlO+f7fh/y60Cgds7UwObODEPQodUe3ct+agjOija00z/U/FppSLlm0aueMNpVMkwOU5Ad2JeaKxPdJSzGEoJepGeOh/13lDwwjgJK0o0a9rzy1lTA+fQKvSoJR6+TPFK4FSFdSz4AprJDxOLf+blKdrBU7LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zSzsJXoTLNgtU+yvPl5ajNXABHyAC9pLJNTxAUqfj7U=; b=STl3JNExeNd1vD00pS61v1I7JhoOpFSX18O2IhvS6s4xbnP1e+GPwjDRr0UrArhDHedndsS9+e6XREzP5fnjfbAycaYJ7xHgEyEJo33O0OUpqAoeecNFrz0kZlkYdV1UFYFb3mohypZV0JdstAF4yIe/PcP7YYXRuKFdiZMyNBB2s0Z7IHvUlOKDGuaq3mBrzgXG7mPP3e04Wy9aI7NlM1sEZOXpExQgGxCUZUzloXA2XwzjY1sDBMxQcZcsRoQDL+HvbjnVB5sz/UGHvsvTfpMeQLKW0g7OB2Bg1s0dPSF5hhsWUzc0AbML2EWVh+S2rNfXPO6SfsTEmsofgplJAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zSzsJXoTLNgtU+yvPl5ajNXABHyAC9pLJNTxAUqfj7U=; b=iUSCiruCJ6/s4mIE0hlwQDU6qVBx65BDxufXXGpRN28rHyqm0nnyUOQqxumqOFdZMwXoBVsACwJfyYL43YeWr86BBb+izzqkP98CN/xHrwHDeqbP2C4pZ0rTavD7kTiVy31DPfjCAlaVLD2YuIZKg3YgPDwaOZ7NVH/OQZMpKIXsVHS35xKB87faY28yYuHjgUXBjufcwy61PQfh+8VcbA+seEMsb+ilWD5RTllpnfTKYmHhU6WHu+fnZqvGj9RZ6EafwHlrnQLGS/7AlhP+xuzLLsQg0Fn45HcRyB/gwHBo6G/iJFbgWVnWeU/3hAmPvHeYMLQGOr9lxJeggXAyng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB5844.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:5d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Fri, 22 Dec 2023 16:58:25 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::9378:63a0:1c28:2df7]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::9378:63a0:1c28:2df7%3]) with mapi id 15.20.7113.019; Fri, 22 Dec 2023 16:58:24 +0000 Message-ID: <29459cc0-2770-4fea-9ed0-aa9c4f09ad9c@efficios.com> Date: Fri, 22 Dec 2023 11:58:24 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/9] Some register value cleanups Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231221191716.257256-1-simon.marchi@efficios.com> <877cl618m2.fsf@tromey.com> From: Simon Marchi In-Reply-To: <877cl618m2.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0139.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:87::13) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB5844:EE_ X-MS-Office365-Filtering-Correlation-Id: 35eaa6a1-4475-4e84-8460-08dc030f361d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oBcjueWh3xIDRDkwD/QiLiXcox0Qrx1haEcPCKUxl26cPnAB4lvQrVrUllPc0BNLqchJCnVp3X2J2qOkVxhLvlj+H12kDI3ckQn99U6QhLqkeYpVDOiNU31b550aQoYddwchcF2k3fFV7rfutX/64mVq3Xq6Um+ix/9QfkIkf81usFDlgH2cnBTWvKMRpYyVg0js6/J5Gw9VRcyomkQxVfjQr/2GMwc8PuRRbK4IUOEleNCS+6va0qxQE2HhcWre2r+PzsVgXtx26UElc392p5ahjt7smgBT3gN6PaMkYkRHQofAoD/QwQRiNs5xM9C3rCeEd4EXtjkSL6ysl4/QQJu6IlyOguO+OCh1a2aFfI4U6m+u0HPtmcfsC/NeY/UG2KvtjstBX3MMoXLns1wAltGpCmQhK4HdbofOo/xUo1JeHLsX3kikkxlPjFOw9MTst/Z7yJvoyZ6CPuMPdzVGu01jeR8Oxsl740ez9bC4PMIVeX03zvn4JZ/fjaB78HsAAmzMRQ3lfrPon4RzYYWbRaYjLiRMzks4Op8OzROUKkzcDAsPYTb8msy1pc391avGSt/G1v9WawZJhk6DOdv5ToltqGh0uXeRhd/E0FxNxeGOE+X71sEJdmCd4KdcYB6WjU4+uLH3bxnqYLVGzzydYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376002)(39830400003)(396003)(136003)(366004)(346002)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(31686004)(26005)(2616005)(6506007)(6512007)(36756003)(38100700002)(31696002)(66556008)(8936002)(41300700001)(8676002)(66946007)(83380400001)(44832011)(53546011)(5660300002)(6916009)(4326008)(66476007)(2906002)(4744005)(6486002)(478600001)(316002)(4001150100001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGs1eTJqaFh3NVpHUzZOV2ZMUlBwbTYvQXRoQmV1czRhZ3NGZjZoczBxQXds?= =?utf-8?B?eEdwS1RPaFZDczhQNGZvWEpQR2V5RmpNYkVwekxFUUJmcmFnTkFGTVRURVlS?= =?utf-8?B?Q1FMVHZodGxDcmdZU2RFYTBRS2JxektZWU1QMXhGUCtIS1lEZnhPQm5tL1VP?= =?utf-8?B?YzNoOGpIRXBISmQ2UWkvcitlR3lnRnUxTkVjN0IzVldCamNNN2hXK3c5WXV0?= =?utf-8?B?WE9TMlUrVGYyQ09WUW1Xekx3dzFnem1JNHVrVGhwRHRvZkdLdkx0RVQzSW1l?= =?utf-8?B?TnplYk1qUTZaOHRKdkV1SHNmTWc4NmFERU1iV2p3aGJFamdNRW5ReTZ0Njk5?= =?utf-8?B?ajhxVGZ5bTRkMnBuS2JBdnJaNWgxYjJncXRJVkNkQi9iSEtJMnl2RXJGUE44?= =?utf-8?B?Zk1xejN6VTB0cUZQS1NJQzE0TzBEZS9ndC9TYUhnMG1ZMmNtTmR3bXZ6UEdI?= =?utf-8?B?MDZjdmxEMmkzSUM4WFhPVHJNL0JTNjU5N2ZmaER5elNFdnVXZ1pIUjdEcUdJ?= =?utf-8?B?a1NxelNjM21XRnhlMENMQzBVa2lPMTUwTjFadHYwbEgzeUJXWVMxeHErZVJX?= =?utf-8?B?NWFmZjllTWxJaXBCTGdvUW5sdHZWS0RsSGtvaHF3WS9oNkF6NXJzSFhkSlZO?= =?utf-8?B?VStIR0szcDlnaWdlUVF3UGJzRWQzSUVMa2dBRTZ2YVNPVFI5UkYrWlVFUy91?= =?utf-8?B?a3dPVnlYWGQxNHFVdDFqNmxtSjd0Tk8vUmlFc3A5NTVheWs2a3M5N0hFNEdC?= =?utf-8?B?R0xOOGhYU2hvSlpIdVZ0UC9rZGRBdU1SbysrV3M0eFY4V09xVEZzaGxPR0s0?= =?utf-8?B?aXh0dDA5dGVURE9idXp6Z3FJS0lIZnp5STM4dWdpcW1CT1NnZDUrcXlzeUFD?= =?utf-8?B?dnNZckxsRVVsUXpVWGovbXY2aGZaazVTOXh6NjVTT0J1b205MGZMTDQwWFJt?= =?utf-8?B?WENQWk9ybVp4U2E4d2JpeXBNZU9DVmpxeE80ODJaWExjMldZZXZkWTcvL3lI?= =?utf-8?B?dFFES2llUE5QRXh3MzNQSTMvSHBjdDBpdUsyN003VFRGTlkrbXJ6RWJEZTBB?= =?utf-8?B?UGNYNXNlU3JhUmZWMXdobDEvWGpnWXNVUlAzYnFndkJKTzRtWTk3OThSMlRE?= =?utf-8?B?RVlBbGZTOW82bW1nUHFSd1VPd0VJeEdiR2RFbkdkdUJ6MVVmNG5iaEd0THl0?= =?utf-8?B?SkpYOU9Nb1drN05xRndzNFV0eFN6MW9YbXFxMnFpNC96cWFLSmlwY3lQdHVo?= =?utf-8?B?UE9yQWhCWXN0aDh1R2RVMEhRWmtlSnlmTW1zc1QwWmdpUWs1SE9KMWJkWEpX?= =?utf-8?B?ckJGV3FzTGp3QUVHaUY1MHZzYUFFbkVEZVBZajN5MU1UQjhUUTRRU09GdjVy?= =?utf-8?B?dlJzOG9RYmoxMWczU3F4K2R1ZnAzamVTRTd2cXBoeG0wMzhBenAvOXBWNG5t?= =?utf-8?B?N01WakZKVGxoNnd0N3VvTkduaml6K3B2VEppbXZBSlpzTkV6TlRrVUZIZWJx?= =?utf-8?B?YjVIOVZNMXo3Q1ROQ2kxWVBhSUc5N1cxckp5Z25uVVpXSHlHNmt3RGNxZFdv?= =?utf-8?B?VzRQMXVVWFNDcVorNmtTV3VrLzU0cmVHcmg2L3JwbDNNRG1OeFQ1SFRxZ09q?= =?utf-8?B?enhmSDBDZGRwc0dOalJiR2VCbi9mYXg5azcxekVIZzlhZVI2YWNzWnlOcU1S?= =?utf-8?B?SFJmUjR1Y25YUFBmZ0NLa2FkbjNORGRXZE5VdmxPSXo2SHpsK2o3dzAvTU4w?= =?utf-8?B?TGd5S2IrQXNaV2ljK0YzaFRYRnZCdUtndHgwYVk1REQrYkdHZ2N0Sm55eWRo?= =?utf-8?B?L1RadzJFbGFlTDJQMDkrR29mTGNxMERHM2l4Y2JOV1ZUcW40L0lDK1RuclpR?= =?utf-8?B?SnZJQy9yZXdlYkU0bEt3cXpnaEJQWHlaL0NkQURVQlg0ZUJEZXVzbjBJL2hu?= =?utf-8?B?OTd0YkZ3Q0k2SGF3SDlYTkxjbmpocGFTUkh4bUlhUTZ5MjZmNi80azBydEg4?= =?utf-8?B?WUcyaklsOGxkQ2NUWG1xbnpvQ3p3OS9DdUEwQkszaHFZdG1HUlM2RWhBbS9E?= =?utf-8?B?OW0yZWFOd0tTc1JHNmhBVEc4WTF5WHc4Zy9YKzVPczdINU96b3c4cllLVGI4?= =?utf-8?Q?SsAGSMxW/T6wGotp0RRsJ7cSt?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35eaa6a1-4475-4e84-8460-08dc030f361d X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2023 16:58:24.8953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7e9s3zlZhEC8lEpHHmhxmmECxYutNWF0QwH3WxTLxPVy8uT66LoVFW1Uj11nDCSE3Ed0LXocC+GmnwptqhdZ8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB5844 X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-12-22 11:53, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> I'm currently investigating some things related to register read and > Simon> spotted some improvements that could be made to make the code a bit > Simon> simpler or more robust, here they are. > > Thank you for doing this. I sent a few minor notes, but overall I'm > very happy to see this series. > > Tom Thanks, I'll apply your comments, and I'll push it if there are no significant changes that need re-review. Simon