From: Simon Marchi <simon.marchi@polymtl.ca>
To: Luis Machado <luis.machado@linaro.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH v5 20/25] New memory-tag commands
Date: Thu, 4 Feb 2021 23:52:40 -0500 [thread overview]
Message-ID: <295ad93d-a12d-da03-fcd5-20f93f3cff80@polymtl.ca> (raw)
In-Reply-To: <f1c773cd-02b7-1876-fc6f-b189eb1564be@polymtl.ca>
>> void _initialize_printcmd ();
>> void
>> _initialize_printcmd ()
>> @@ -2982,4 +3263,63 @@ Construct a GDB command and then evaluate it.\n\
>> Usage: eval \"format string\", ARG1, ARG2, ARG3, ..., ARGN\n\
>> Convert the arguments to a string as \"printf\" would, but then\n\
>> treat this string as a command line, and evaluate it."));
>> +
>> + /* Memory tagging commands. */
>> + add_prefix_cmd ("memory-tag", class_vars, memory_tag_command, _("\
>> +Generic command for printing and manipulating memory tag properties."),
>> + &memory_tag_list, "memory-tag ", 0, &cmdlist);
>> + add_cmd ("print-logical-tag", class_vars,
>> + memory_tag_print_logical_tag_command,
>> + ("Print the logical tag for an address.\n\
>> +Usage: memory-tag print-logical-tag <address>.\n\
>> +<address> is an expression that evaluates to a pointer or memory address.\n\
>> +GDB will print the logical tag associated with <address>. The tag\n\
>
> Instead of saying "GDB will print the...", use the infinite "Print the
> ...". I would also swap the two sentences to say what the command says
> first, before describing the argument. Something like:
>
> Print the logical tag associated with a pointer. POINTER is an
> expression that evaluates to a pointer.
I just noticed that the very first sentence of the help is pretty much
the same thing as I wrote. In that case, I think the "GDB will print
the..." sentence is simply redundant, I'd just remove it.
Simon
next prev parent reply other threads:[~2021-02-05 4:52 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 20:20 [PATCH v5 00/25] Memory Tagging Support + AArch64 Linux implementation Luis Machado
2021-01-27 20:20 ` [PATCH v5 01/25] New target methods for memory tagging support Luis Machado
2021-01-27 23:26 ` Lancelot SIX
2021-01-28 10:02 ` Luis Machado
2021-02-05 2:31 ` Simon Marchi
2021-01-27 20:20 ` [PATCH v5 02/25] New gdbarch memory tagging hooks Luis Machado
2021-02-05 2:38 ` Simon Marchi
2021-02-05 3:58 ` Simon Marchi
2021-01-27 20:20 ` [PATCH v5 03/25] Add GDB-side remote target support for memory tagging Luis Machado
2021-02-05 2:48 ` Simon Marchi
2021-01-27 20:20 ` [PATCH v5 04/25] Unit testing for GDB-side remote memory tagging handling Luis Machado
2021-02-05 2:50 ` Simon Marchi
2021-01-27 20:20 ` [PATCH v5 05/25] GDBserver remote packet support for memory tagging Luis Machado
2021-02-05 2:56 ` Simon Marchi
2021-02-05 12:38 ` Luis Machado
2021-01-27 20:20 ` [PATCH v5 06/25] Unit tests for gdbserver memory tagging remote packets Luis Machado
2021-01-27 20:20 ` [PATCH v5 07/25] Documentation for " Luis Machado
2021-01-28 3:30 ` Eli Zaretskii
2021-01-28 9:58 ` Luis Machado
2021-01-27 20:20 ` [PATCH v5 08/25] AArch64: Add MTE CPU feature check support Luis Machado
2021-02-05 3:05 ` Simon Marchi
2021-01-27 20:20 ` [PATCH v5 09/25] AArch64: Add target description/feature for MTE registers Luis Machado
2021-01-27 20:20 ` [PATCH v5 10/25] AArch64: Add MTE register set support for GDB and gdbserver Luis Machado
2021-01-27 20:20 ` [PATCH v5 11/25] AArch64: Add MTE ptrace requests Luis Machado
2021-02-05 3:13 ` Simon Marchi
2021-01-27 20:20 ` [PATCH v5 12/25] AArch64: Implement memory tagging target methods for AArch64 Luis Machado
2021-02-05 3:30 ` Simon Marchi
2021-01-27 20:21 ` [PATCH v5 13/25] Convert char array to std::string in linux_find_memory_regions_full Luis Machado
2021-02-05 3:32 ` Simon Marchi
2021-01-27 20:21 ` [PATCH v5 14/25] Refactor parsing of /proc/<pid>/smaps Luis Machado
2021-02-05 3:38 ` Simon Marchi
2021-01-27 20:21 ` [PATCH v5 15/25] AArch64: Implement the memory tagging gdbarch hooks Luis Machado
2021-02-05 4:09 ` Simon Marchi
2021-02-05 14:05 ` Luis Machado
2021-01-27 20:21 ` [PATCH v5 16/25] AArch64: Add unit testing for logical tag set/get operations Luis Machado
2021-01-27 20:21 ` [PATCH v5 17/25] AArch64: Report tag violation error information Luis Machado
2021-02-05 4:22 ` Simon Marchi
2021-02-05 14:59 ` Luis Machado
2021-02-05 16:13 ` Simon Marchi
2021-01-27 20:21 ` [PATCH v5 18/25] AArch64: Add gdbserver MTE support Luis Machado
2021-01-27 20:21 ` [PATCH v5 19/25] AArch64: Add MTE register set support for core files Luis Machado
2021-01-27 20:21 ` [PATCH v5 20/25] New memory-tag commands Luis Machado
2021-02-05 4:49 ` Simon Marchi
2021-02-05 4:52 ` Simon Marchi [this message]
2021-02-08 18:59 ` Luis Machado
2021-03-23 21:46 ` Simon Marchi
2021-01-27 20:21 ` [PATCH v5 21/25] Documentation for the new mtag commands Luis Machado
2021-01-28 3:31 ` Eli Zaretskii
2021-02-05 4:50 ` Simon Marchi
2021-01-27 20:21 ` [PATCH v5 22/25] Extend "x" and "print" commands to support memory tagging Luis Machado
2021-02-05 5:02 ` Simon Marchi
2021-01-27 20:21 ` [PATCH v5 23/25] Document new "x" and "print" memory tagging extensions Luis Machado
2021-01-28 3:31 ` Eli Zaretskii
2021-02-05 5:04 ` Simon Marchi
2021-02-08 20:44 ` Luis Machado
2021-01-27 20:21 ` [PATCH v5 24/25] Add NEWS entry Luis Machado
2021-01-28 3:32 ` Eli Zaretskii
2021-02-05 5:06 ` Simon Marchi
2021-02-08 20:44 ` Luis Machado
2021-01-27 20:21 ` [PATCH v5 25/25] Add memory tagging testcases Luis Machado
2021-02-04 14:18 ` [PING] [PATCH v5 00/25] Memory Tagging Support + AArch64 Linux implementation Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=295ad93d-a12d-da03-fcd5-20f93f3cff80@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).