From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53283 invoked by alias); 17 Oct 2018 15:53:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53254 invoked by uid 89); 17 Oct 2018 15:53:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Oct 2018 15:53:05 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w9HFqxDi017482 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 17 Oct 2018 11:53:03 -0400 Received: by simark.ca (Postfix, from userid 112) id 092981EA6D; Wed, 17 Oct 2018 11:52:59 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 969BE1E4C2; Wed, 17 Oct 2018 11:52:58 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 17 Oct 2018 15:53:00 -0000 From: Simon Marchi To: Jan Vrany Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3] Fix various tests to use -no-pie linker flag when needed In-Reply-To: <52489e133153f8151f1ea529122feafa@polymtl.ca> References: <20181017145537.3010-1-jan.vrany@fit.cvut.cz> <20181017151210.3278-1-jan.vrany@fit.cvut.cz> <52489e133153f8151f1ea529122feafa@polymtl.ca> Message-ID: <2985d86a6b3b9a3bef6e79bc2d130955@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00374.txt.bz2 On 2018-10-17 11:43, Simon Marchi wrote: > On 2018-10-17 11:12, Jan Vrany wrote: >> Various test use test code written in i385 / x86_64 assembly that >> cannot > > typo, "i385" > >> be used to create PIE executables. Therefore compilation of test >> programs >> failed on systems where the compiler default is to create PIE >> executable. >> >> To fix this, force -no-pie linker flag. > > LGTM, thanks! Actually, see the message from Pedro. gcc 4.8 doesn't know about this flag, and we probably want to support that for a while... so we'll have to implement that gdb_compile flag. Simon