From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 69A423858037 for ; Thu, 11 Jan 2024 19:25:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69A423858037 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 69A423858037 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705001112; cv=pass; b=U3iVh/DtVd4Ge7h3KojIDXMKCRX4B1z2aRjFOgDRAFLxzPuzx+j5xM4QvgZgT1+0JRf5Bf9Ur1nlbDO/JoecMDK5EmG3MWEufZDpbRN+udVrKQ7hdu9KmrSpcvMnhSa2z1Fa0G09XoZNrinY1ki1FMkPGPva2W9m2iQu+Q2wVNM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705001112; c=relaxed/simple; bh=9sLCAT4sCf3RZruXoJAc59e4BKoGV7iyC2/OKr2cXqI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ABf53zuwx3/Pf55ZX8YpZjNa5DGrRBHu4Rt6J99yhV5GyQb7/fjPc1ns220j/+NqoYe/a5gNQdIgA0FVlglfjiFJGsUcQXRXtW7gaJ/wpp9oddSDniXZwM4akakrzL+LPU9Wuu6t9PVxo0S9xEbxmPQ1BwrArR3voB1x6I+5FD8= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4T9vkp5wjRz3sFP; Thu, 11 Jan 2024 19:25:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T9vkp585cz449P; Thu, 11 Jan 2024 19:25:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705001106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E+FtJRKMwcBjKviLIA3QVVr35G1inYIX6Q/yNorfPaQ=; b=tDibaDBi0CUH2mzCtkENKmd5b6llXWg/AA0znk92kYg0MQrTliJrZVavd/yGgvzppm3U8R P9h3kLx87bk1RmlcJdk/OjJbjPLWM4IEJ28p2gxtvwAdGKO+ISlYLIvcAeG+kl9Ie+dAgX o26GUq8+zykEEdORvOYA4JkaH377YDJ4CSFja7HInVARoNGVdx2Pd7eB/hwYA2ec5449zj vM7MATuyNGnuGYmmO2tXPkBCSJT0gffK2Si0gythgKC6t+dr/EaQWOmRHfWqoHfWQ/jfVv lY9Hn+gz9o9j1jC4jtpqChUO0vLI6/5RMt42LQ1FaVfLLXdc4+5MhYFDFAu0DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705001106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E+FtJRKMwcBjKviLIA3QVVr35G1inYIX6Q/yNorfPaQ=; b=QLCtKgB5PJkGYL/DReNnzHULuBOK/PZYR+KUEzrIe+AWPgEQBwO1KuYQb8h5qSZvn2BTWu mhI/Qb34++xkTQgsbHxtm84VeeaTKZ3Mv4P9oZeARNyK+GcQz94ZrswSxfzOLxnP29dg2v 5yOhCAux77Nq0MY+rdB4s4Bt2BQN8Zn8Jotaoxe8iXQWT8GDoY25PhUdO1UuIKd+h88DyF db9At7DtSNNtIEqV3Rzjt/dRARSKx5yW4oCO68HJt338BrfTKPx3z/dlOrThckQIsE3/VT Z0HjHvf8oglnPD0YQ0zF/Wc1FDbqMqEmoUGk4yS53cF0JYc+bmfSjWP4yPQ3rw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705001106; a=rsa-sha256; cv=none; b=j/gLAP33pfJbL5oPKBqGrBQ0aNJfgi4n/LAz4ihpqaEb2m9DbBa+0lwE6phH4Ye9uvMjlu PkYb0BXJBzhGQsPDuTbB+IwGU9+h0m9D8etv2+9xC8ah/23FPx51h4ZBvKXwgRxzVtGuBw 4p5HvMA3GYVBz4SnvR1ry33quhs0+5vGnCX1h6eDvsWmk6O8MFzYBrgCNStNg8KGVSQZxS Ip1D45ztxo4Pel1ssArvHbWR0cGFZKbb8+EhIiVP+aDjJCri6pn/JYkxqmh3TRwx0XeZrv ytMMKlv+NFkpyDjVJHa5xU3Bkk760U0QwR55AbOHOXwJ/uc9+sS9dfidIDuG2w== Received: from [IPV6:2601:644:9381:f410:7c71:8d88:a2f5:8ee0] (unknown [IPv6:2601:644:9381:f410:7c71:8d88:a2f5:8ee0]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T9vkp19kkzSsC; Thu, 11 Jan 2024 19:25:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <29993677-d7a8-4cf0-b367-2d67201ca111@FreeBSD.org> Date: Thu, 11 Jan 2024 11:25:04 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3] gdb: add trailing '/' when using 'complete' with directory names Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org Cc: Tom Tromey , Lancelot SIX References: From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/11/24 8:02 AM, Andrew Burgess wrote: > In V3: > > - Add link to bug Tom pointed out, > > - Use concat rather than temporary std::string. Save a strdup call, > > - Added 'explicit' to the constructor, > > - Remove weird 'const reference' thing. Latest version LGTM. Reviewed-By: John Baldwin -- John Baldwin