From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 2/7] Remove make_cleanup_ui_out_table_begin_end
Date: Sat, 09 Sep 2017 18:22:00 -0000 [thread overview]
Message-ID: <29dd1075cea4be9035966dbe5335f7e4@polymtl.ca> (raw)
In-Reply-To: <87y3pndfmk.fsf@bapiya>
On 2017-09-09 18:02, Tom Tromey wrote:
> I forgot to mention something I had meant to mention when submitting
> this series:
>
> Tom> * spu-tdep.c (info_spu_mailbox_list): Use ui_out_emit_table.
> Tom> (info_spu_dma_cmdlist): Likewise.
> [..]
> Tom> * darwin-nat-info.c (darwin_debug_regions_recurse): Use
> Tom> ui_out_emit_table.
>
> I don't have any way to test these, or even compile the darwin patch.
> So this requires extra careful review at least, or someone to volunteer
> to try them out.
>
> It would be very nice to have a darwin builder hooked up to the
> buildbot. I'm not sure how practical this is ... there are so many
> Macs
> around Moz that maybe I could acquire one somehow, but I don't know
> that I could host it anywhere.
The patch LGTM.
I built-tested your series on a Mac, it builds fine (if we ignore all
the current hurdles to get it to build). Now when I try actually
running, I get this:
(gdb) r
Starting program: /Users/simark/build/binutils-gdb/gdb/test_clang
[New Thread 0x1503 of process 79554]
[New Thread 0x1803 of process 79554]
Warning:
Cannot insert breakpoint -1.
Cannot access memory at address 0xeb19
Command aborted.
But it also does that before your patch.
Simon
next prev parent reply other threads:[~2017-09-09 18:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 15:35 [RFA 0/7] more ui-out cleanup removal Tom Tromey
2017-09-09 15:35 ` [RFA 4/7] Use ui_out_emit_tuple in disasm.c Tom Tromey
2017-09-09 18:35 ` Simon Marchi
2017-10-12 15:37 ` Simon Marchi
2017-10-12 16:06 ` Simon Marchi
2017-10-12 16:11 ` Tom Tromey
2017-10-12 21:07 ` Tom Tromey
2017-10-13 16:13 ` Tom Tromey
2017-10-16 22:37 ` Simon Marchi
2017-10-16 22:59 ` Tom Tromey
2017-09-09 15:35 ` [RFA 5/7] Use ui_out_emit_list in more places Tom Tromey
2017-09-09 18:43 ` Simon Marchi
2017-09-09 15:35 ` [RFA 3/7] Use ui_out_emit_tuple " Tom Tromey
2017-09-09 18:32 ` Simon Marchi
2017-09-09 19:32 ` Tom Tromey
2017-09-09 15:35 ` [RFA 1/7] Use ui_out_emit_table and ui_out_emit_list in print_thread_info_1 Tom Tromey
2017-09-09 17:47 ` Simon Marchi
2017-09-09 18:36 ` Tom Tromey
2017-09-09 19:20 ` Matt Rice
2017-09-09 15:35 ` [RFA 6/7] Remove make_cleanup_ui_out_redirect_pop Tom Tromey
2017-09-09 18:49 ` Simon Marchi
2017-09-09 15:46 ` [RFA 2/7] Remove make_cleanup_ui_out_table_begin_end Tom Tromey
2017-09-09 16:02 ` Tom Tromey
2017-09-09 18:22 ` Simon Marchi [this message]
2017-09-09 15:46 ` [RFA 7/7] Use ui_out_emit_list and ui_out_emit_tuple with gdb::optional Tom Tromey
2017-09-09 18:51 ` Simon Marchi
2017-09-09 19:44 ` [RFA 0/7] more ui-out cleanup removal Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29dd1075cea4be9035966dbe5335f7e4@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).