[PATCH 1/2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant

[PATCH 1/2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant

[Hannes Domani]

gdb/ChangeLog:

2021-05-25  Hannes Domani  <ssbssa@yahoo.de>

	* python/py-symbol.c (gdbpy_initialize_symbols): Restore
	gdb.SYMBOL_LABEL_DOMAIN constant.
---
 gdb/python/py-symbol.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/python/py-symbol.c b/gdb/python/py-symbol.c
index 8953ee097cc..d44b55ed5a9 100644
--- a/gdb/python/py-symbol.c
+++ b/gdb/python/py-symbol.c
@@ -673,6 +673,8 @@ gdbpy_initialize_symbols (void)
 				  VAR_DOMAIN) < 0
       || PyModule_AddIntConstant (gdb_module, "SYMBOL_STRUCT_DOMAIN",
 				  STRUCT_DOMAIN) < 0
+      || PyModule_AddIntConstant (gdb_module, "SYMBOL_LABEL_DOMAIN",
+				  LABEL_DOMAIN) < 0
       || PyModule_AddIntConstant (gdb_module, "SYMBOL_MODULE_DOMAIN",
 				  MODULE_DOMAIN) < 0
       || PyModule_AddIntConstant (gdb_module, "SYMBOL_COMMON_BLOCK_DOMAIN",
-- 
2.31.1

[PATCH 2/2] Fix documentation of gdb.SYMBOL_LOC_COMMON_BLOCK

[Hannes Domani]

gdb/doc/ChangeLog:

2021-05-25  Hannes Domani  <ssbssa@yahoo.de>

	* python.texi (Symbols In Python): Fix gdb.SYMBOL_LOC_COMMON_BLOCK.
---
 gdb/doc/python.texi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index aad480b2a5c..1247d0b19bb 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -5242,8 +5242,8 @@ The value does not actually exist in the program.
 @item gdb.SYMBOL_LOC_COMPUTED
 The value's address is a computed location.
 
-@vindex SYMBOL_LOC_COMPUTED
-@item gdb.SYMBOL_LOC_COMPUTED
+@vindex SYMBOL_LOC_COMMON_BLOCK
+@item gdb.SYMBOL_LOC_COMMON_BLOCK
 The value's address is a symbol.  This is only used for Fortran common
 blocks.
 @end vtable
-- 
2.31.1

Re: [PATCH 2/2] Fix documentation of gdb.SYMBOL_LOC_COMMON_BLOCK

[Eli Zaretskii]

> Date: Tue, 25 May 2021 17:32:53 +0200
> From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
> 
> gdb/doc/ChangeLog:
> 
> 2021-05-25  Hannes Domani  <ssbssa@yahoo.de>
> 
> 	* python.texi (Symbols In Python): Fix gdb.SYMBOL_LOC_COMMON_BLOCK.

Thanks, this doesn't need approval, as it's an obvious fix.

Re: [PATCH 2/2] Fix documentation of gdb.SYMBOL_LOC_COMMON_BLOCK

[Hannes Domani]

 Am Dienstag, 25. Mai 2021, 19:15:39 MESZ hat Eli Zaretskii <eliz@gnu.org> Folgendes geschrieben:

> > Date: Tue, 25 May 2021 17:32:53 +0200
>
> > From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
> >
> > gdb/doc/ChangeLog:
> >
> > 2021-05-25  Hannes Domani  <ssbssa@yahoo.de>
> >
> >     * python.texi (Symbols In Python): Fix gdb.SYMBOL_LOC_COMMON_BLOCK.
>
>
> Thanks, this doesn't need approval, as it's an obvious fix.

Pushed, thanks.


Hannes

Re: [PATCH 1/2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant

[Simon Marchi]

On 2021-05-25 11:32 a.m., Hannes Domani via Gdb-patches wrote:
> gdb/ChangeLog:
> 
> 2021-05-25  Hannes Domani  <ssbssa@yahoo.de>
> 
> 	* python/py-symbol.c (gdbpy_initialize_symbols): Restore
> 	gdb.SYMBOL_LABEL_DOMAIN constant.
> ---
>  gdb/python/py-symbol.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gdb/python/py-symbol.c b/gdb/python/py-symbol.c
> index 8953ee097cc..d44b55ed5a9 100644
> --- a/gdb/python/py-symbol.c
> +++ b/gdb/python/py-symbol.c
> @@ -673,6 +673,8 @@ gdbpy_initialize_symbols (void)
>  				  VAR_DOMAIN) < 0
>        || PyModule_AddIntConstant (gdb_module, "SYMBOL_STRUCT_DOMAIN",
>  				  STRUCT_DOMAIN) < 0
> +      || PyModule_AddIntConstant (gdb_module, "SYMBOL_LABEL_DOMAIN",
> +				  LABEL_DOMAIN) < 0
>        || PyModule_AddIntConstant (gdb_module, "SYMBOL_MODULE_DOMAIN",
>  				  MODULE_DOMAIN) < 0
>        || PyModule_AddIntConstant (gdb_module, "SYMBOL_COMMON_BLOCK_DOMAIN",
> 

Could you please write a commit message?  As someone not familiar with
the problem, I'm not sure what you are trying to fix.  Did this property
disappear?  If so, when was that / what commit did that?  If we managed
to regress this, it probably means we need to check them in some test.

Simon