From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 485763857401 for ; Tue, 25 May 2021 20:47:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 485763857401 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14PKlWmn006999 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 May 2021 16:47:37 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14PKlWmn006999 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 96BBC1E01F; Tue, 25 May 2021 16:47:32 -0400 (EDT) Subject: Re: [PATCH 1/2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant To: Hannes Domani , gdb-patches@sourceware.org References: <20210525153253.2461-1-ssbssa.ref@yahoo.de> <20210525153253.2461-1-ssbssa@yahoo.de> From: Simon Marchi Message-ID: <29f0f91c-b60c-4aa9-723b-54b07da3276b@polymtl.ca> Date: Tue, 25 May 2021 16:47:32 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210525153253.2461-1-ssbssa@yahoo.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 25 May 2021 20:47:32 +0000 X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_STOCKGEN, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 May 2021 20:47:39 -0000 On 2021-05-25 11:32 a.m., Hannes Domani via Gdb-patches wrote: > gdb/ChangeLog: > > 2021-05-25 Hannes Domani > > * python/py-symbol.c (gdbpy_initialize_symbols): Restore > gdb.SYMBOL_LABEL_DOMAIN constant. > --- > gdb/python/py-symbol.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gdb/python/py-symbol.c b/gdb/python/py-symbol.c > index 8953ee097cc..d44b55ed5a9 100644 > --- a/gdb/python/py-symbol.c > +++ b/gdb/python/py-symbol.c > @@ -673,6 +673,8 @@ gdbpy_initialize_symbols (void) > VAR_DOMAIN) < 0 > || PyModule_AddIntConstant (gdb_module, "SYMBOL_STRUCT_DOMAIN", > STRUCT_DOMAIN) < 0 > + || PyModule_AddIntConstant (gdb_module, "SYMBOL_LABEL_DOMAIN", > + LABEL_DOMAIN) < 0 > || PyModule_AddIntConstant (gdb_module, "SYMBOL_MODULE_DOMAIN", > MODULE_DOMAIN) < 0 > || PyModule_AddIntConstant (gdb_module, "SYMBOL_COMMON_BLOCK_DOMAIN", > Could you please write a commit message? As someone not familiar with the problem, I'm not sure what you are trying to fix. Did this property disappear? If so, when was that / what commit did that? If we managed to regress this, it probably means we need to check them in some test. Simon