From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id A636E3893646 for ; Tue, 23 Jun 2020 17:58:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A636E3893646 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-57-a9sHbFh0OWKhg3sqQh2nGQ-1; Tue, 23 Jun 2020 13:58:43 -0400 X-MC-Unique: a9sHbFh0OWKhg3sqQh2nGQ-1 Received: by mail-wr1-f72.google.com with SMTP id a6so10151125wrq.3 for ; Tue, 23 Jun 2020 10:58:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uMXynBGqMN6r16lL9iY2kleVoqrahJ2w0He69pWORMs=; b=kc66igO+lqsJdrdnfNKl8zkdaAeel9IfehNdaTdYG23B34VRTL9NJfKHlmqW+r6xmx Hfhyx0cM6ACR59OXGqnG2tJCmXmOTFr1VUqucra4jH91Jv96/aSzemIexekh9xtrfevm 1myH5r+oLKRIaI3MFwv2rzKEjO5imVHuYKeJc4ncVQNkcrrMyPzYPrt9cQrjqgpjDJiv 25Iuk71Sk35SbgCHyEWEtdXPVwRk9CZshi+7at7sz38etcRDESiRZwXDi48H5dRjQFVy BYtWHleRW3yWxEKSzsiOy8UJdqPQrEL5qhkRmRlnZ2hpzSOtmGZ37VV1Rk3bhG2vSfvi YGkw== X-Gm-Message-State: AOAM530so7LB7rGnuZJvKqo6GKTOnTldILmiCTrA+J0kQLP53T4kiHbA ADHHww0WAFg2zwLPSnS89R9JndhKkvlL2rA8owW2mXYUm0LndLF6GeuDUCGxbk4Bx8HxRyEGmc3 DWrXWtRy/RAx2fqvvYSJMPQ== X-Received: by 2002:a1c:b103:: with SMTP id a3mr2489637wmf.186.1592935122136; Tue, 23 Jun 2020 10:58:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyI2d3Mobje76gS9u22VbWqtfqataBmXklom+j40oZp5tMWHR8vdr8nF524ftIv9Y5ZZLgXlQ== X-Received: by 2002:a1c:b103:: with SMTP id a3mr2489622wmf.186.1592935121920; Tue, 23 Jun 2020 10:58:41 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id z25sm4636049wmk.28.2020.06.23.10.58.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2020 10:58:41 -0700 (PDT) Subject: Re: [PATCH] Fix "maint selftest" regression, add struct, scoped_mock_context To: Andrew Burgess References: <20200414175434.8047-1-palves@redhat.com> <20200414175434.8047-29-palves@redhat.com> <20200623133750.GO2737@embecosm.com> <475a7fa3-07b1-1830-38e5-5c3b7c6cb7a1@redhat.com> <3fad7665-c2e7-5d15-151a-3adcea22f38e@redhat.com> <20200623163454.GP2737@embecosm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <29f20e6b-8c3a-bea9-a4ad-a46b8b497e38@redhat.com> Date: Tue, 23 Jun 2020 18:58:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200623163454.GP2737@embecosm.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2020 17:58:47 -0000 On 6/23/20 5:34 PM, Andrew Burgess wrote: > * Pedro Alves [2020-06-23 16:38:02 +0100]: > >> On 6/23/20 3:26 PM, Pedro Alves via Gdb-patches wrote: >>> On 6/23/20 2:37 PM, Andrew Burgess wrote: >> >>>> I suspect that the problem might be this line in regcache.c:cooked_read_test: >>>> >>>> /* Switch to the mock thread. */ >>>> scoped_restore restore_inferior_ptid >>>> = make_scoped_restore (&inferior_ptid, mock_ptid); >>>> >>>> My suspicion from a quick read of your patch above is that we need to >>>> do more than just set inferior_ptid here now. >>> >>> Indeed. Thanks for reporting it. >>> >>> I fixed this in gdbarch-selftests.c, where this code is duplicated, >>> but missed regcache.c. I'll fix it. >>> >> >> Like so. WDYT? > > LGTM. > Thanks, I've pushed it. Pedro Alves