From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by sourceware.org (Postfix) with ESMTPS id 68E873858CD1 for ; Wed, 20 Dec 2023 21:24:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68E873858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 68E873858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703107480; cv=none; b=n1V2giWKAcYqGqbXmq5bSMA89Cs7++C43J7AMquDXnivxBrjzXtrQr/5DyP/wuMFPQnTWqoFr/9KniCM4Lr0BGUvoZsJ7q6uqEI+o97QPEmMWJoL7LfQWVNzNJmkk1aC4ncxVkJbRaxVNNL9xrXoZmf9UrjtIAM9QQkwDo8fYwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703107480; c=relaxed/simple; bh=Us19uocAnd/Sk+DKMXFj3kaoCfJB2llYNF7Re6J3Gh0=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=ZG2unU66hzY6cYJkiN+BAqfSgrZE+9NZkg2YM9USMY4STgVZe7iBEEyfOiun+dhSnCl8gx7YCJuQ9xANj/AQ8bfTu+6qh0j1iPY1WXAE25lo6w0Iu4Jd121DoNEOCnUEEgwd6G/Rw7rvKlJbjem3l8fVmrkyQp+ogcNr0B1dg9c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40d12b56a38so1424375e9.2 for ; Wed, 20 Dec 2023 13:24:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703107475; x=1703712275; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w+CNC9wKvnxjJseM9d+MEc0bt6dsj0xf1ihYwVWjP48=; b=J2SVLpT+nBaFWO4KjGGDjhu6LJsKl/pUJFBQ2TJVWVHR62Ll/wj/NBJbTI2uuUwwFB 1koMYplIqgDnKaTOG5G7MROFw2hDa6dUOdspxMiy9fU/Fz+a0i6k7D9NqZWfE7nfRMFy Bi8jHre5ohAB/xuY2WItlgyDPQZggi4ekFt5WxONlcHKYMU11REYTgkJhV6DuuhzaOoM fwFFjMhHVLLfwfhhAxnOtdT5bICLd3Ssv6hiJjSoC3aBkyiCtyUPEYkGMtmUoSss6NkE qG9gXmz3ChrE2aFS9bFZ8hO7QFJ4HiVq42f5ev/awtoM3HLwzMjKv+FsipE8AP9bqYW7 jKSw== X-Gm-Message-State: AOJu0YwySk62k4JP82JcgT9eD1C2SgMOfNv3dnSH/PL2OhzD8VV319Zv AyIvS2Uh0LwxGX91rEb3p97ftmgfUberFA== X-Google-Smtp-Source: AGHT+IFJWzNuUo2rQS8QngDDIBIJXsLo5PEMlett2s/BhVQjularJjFz9i8SyYGKtO2wcaMaHzDMwA== X-Received: by 2002:a1c:7209:0:b0:40d:2376:74e9 with SMTP id n9-20020a1c7209000000b0040d237674e9mr78160wmc.203.1703107474661; Wed, 20 Dec 2023 13:24:34 -0800 (PST) Received: from ?IPV6:2001:8a0:f923:4f00:1791:acb8:e147:39c1? ([2001:8a0:f923:4f00:1791:acb8:e147:39c1]) by smtp.gmail.com with ESMTPSA id h7-20020a05600c350700b0040d2e37c06dsm825096wmq.20.2023.12.20.13.24.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 13:24:33 -0800 (PST) Message-ID: <2a1e0f77-2f5b-440b-941f-d87669ea4c13@palves.net> Date: Wed, 20 Dec 2023 21:24:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] Step over thread exit improvements/fixes + AMD GPU Content-Language: en-US From: Pedro Alves To: gdb-patches@sourceware.org References: <20231214202238.1065676-1-pedro@palves.net> In-Reply-To: <20231214202238.1065676-1-pedro@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2023-12-14 20:22, Pedro Alves wrote: > This series is the result of making step-over-thread-exit work > properly with the AMD GPU target. > > It includes some improvements to > gdb.threads/step-over-thread-exit.exp, a few core fixes, and then AMD > GPU target fixes. > > Finally, the last two patches include tests that we are carrying > downstream, but that unfortunately can't work with upstream GDB yet, > because upstream doesn't understand the DWARF extensions that we are > working hard to get into DWARF 6, so upstream is missing proper > unwinding and accessing variables. I include them in the series so > reading the patches makes more sense, but I don't plan on pushing > them. Unless we are OK with adding them upstream with some early > return, effectivelly making them nops. > > I sent the first two patches as a separate series last month, and > Simon & Lancelot have meanwhile reviewed this whole series internally > at AMD, which resulted in some further improvements in those first > patches (as well as in the others). I've addressed Lancelot's comments (thanks! all adjusted accordingly.), added corresponding approved-by tags, and pushed this series in, except the tests, as mentioned above. Pedro Alves