From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 0525E3858CDA for ; Mon, 5 Sep 2022 14:10:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0525E3858CDA Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3EE431FA17; Mon, 5 Sep 2022 14:10:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1CCBB139C7; Mon, 5 Sep 2022 14:10:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZRwuBT0DFmOxMwAAMHmgww (envelope-from ); Mon, 05 Sep 2022 14:10:05 +0000 Content-Type: multipart/mixed; boundary="------------Yox5JBjJotR6rxnmTMwDJrUQ" Message-ID: <2a454b57-20fa-fcd9-4d1e-719c0567d871@suse.de> Date: Mon, 5 Sep 2022 16:10:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH][gdb/build] Add gdb/contrib/makeinfo-dummy.sh Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220901095108.GA29248@delia> <095e64ca-4595-188a-c28f-70080b0133b5@simark.ca> <157567c8-3042-bcf9-f38f-3f983af79c28@suse.de> From: Tom de Vries In-Reply-To: X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2022 14:10:10 -0000 This is a multi-part message in MIME format. --------------Yox5JBjJotR6rxnmTMwDJrUQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/1/22 19:21, Simon Marchi wrote: > On 9/1/22 10:58, Tom de Vries via Gdb-patches wrote: >> On 9/1/22 16:43, Simon Marchi wrote: >>> On 9/1/22 05:51, Tom de Vries via Gdb-patches wrote: >>>> Hi, >>>> >>>> Currently, we cannot build gdb without makeinfo installed. >>>> >>>> It would be convenient to work around this by using the configure flag >>>> MAKEINFO=/usr/bin/true or some such, but that doesn't work because top-level >>>> configure requires a makeinfo of at least version 4.7, and that version check >>>> fails for /usr/bin/true, so we end up with MAKEINFO=missing instead. >>>> >>>> Work around this by adding a script gdb/contrib/makeinfo-dummy.sh that can be >>>> used instead, like so: >>>> ... >>>> $ ./src/configure MAKEINFO=$src/gdb/contrib/makeinfo-dummy.sh >>>> ... >>>> >>>> The script merely prints the version string that satisfies the version check >>>> in $src/configure. >>>> >>>> Tested on x86_64-linux, with makeinfo removed. >>>> >>>> Any comments? >>> >>> I wouldn't mind having this if it helps you. This file would probably >>> belong in $top_level/contrib more than $top_level/gdb/contrib. >>> >> >> Hi Simon, >> >> thanks for the review. >> >> Agreed, but does that also mean submitting to gcc-patches instead? All the other scripts in /contrib seems to be copies from /contrib. > > IMO, it would be fine to add a file like this just in binutils-gdb, and > if someone wants it in gcc they can copy it there. When making changes > to files existing in both repos, then yeah it's better to involve gcc to > so that they stay in sync. > >> >>> Just in case that would work for you, in this case I have been using: >>> >>> $ ./configure >>> $ make MAKEINFO=/bin/true >>> >>> and that worked fine so far. >> >> I see, I suppose that'll work as well, I didn't think of that. >> >> I guess it matters more for me to have a documented way of dealing with this, than some specific solution. I ran into this today, knew I worked around this before, but didn't remember how. I'm hoping that having this file in the repo will be something that is easy to find back and use. >> >> It would be possible to handle 'true' in the toplevel configure, which would make configure MAKEINFO=true work, but that would have to go past gcc-patches review, and I'm not sure if it's worth the effort to try this, given my suspicion that it will not be accepted. > > Also more efforts, but what we would want is a --disable-doc or > --without-makeinfo configure switch, I think. I gave the --without-makeinfo a try. WDYT? Thanks, - Tom --------------Yox5JBjJotR6rxnmTMwDJrUQ Content-Type: text/x-patch; charset=UTF-8; name="0001-Add-without-makeinfo.patch" Content-Disposition: attachment; filename="0001-Add-without-makeinfo.patch" Content-Transfer-Encoding: base64 QWRkIC0td2l0aG91dC1tYWtlaW5mbwoKQ3VycmVudGx5LCB3ZSBjYW5ub3QgYnVpbGQgZ2Ri IHdpdGhvdXQgbWFrZWluZm8gaW5zdGFsbGVkLgoKSXQgd291bGQgYmUgY29udmVuaWVudCB0 byB3b3JrIGFyb3VuZCB0aGlzIGJ5IHVzaW5nIHRoZSBjb25maWd1cmUgZmxhZwpNQUtFSU5G Tz0vdXNyL2Jpbi90cnVlIG9yIHNvbWUgc3VjaCwgYnV0IHRoYXQgZG9lc24ndCB3b3JrIGJl Y2F1c2UgdG9wLWxldmVsCmNvbmZpZ3VyZSByZXF1aXJlcyBhIG1ha2VpbmZvIG9mIGF0IGxl YXN0IHZlcnNpb24gNC43LCBhbmQgdGhhdCB2ZXJzaW9uIGNoZWNrCmZhaWxzIGZvciAvdXNy L2Jpbi90cnVlLCBzbyB3ZSBlbmQgdXAgd2l0aCBNQUtFSU5GTz1taXNzaW5nIGluc3RlYWQu CgpXaGF0IGRvZXMgd29yayBpcyB0aGlzOgouLi4KJCAuL2NvbmZpZ3VyZQokIG1ha2UgTUFL RUlORk89L3Vzci9iaW4vdHJ1ZQouLi4KYnV0IHRoZSBkcmF3YmFjayBpcyB0aGF0IGl0J2xs IGhhdmUgdG8gYmUgc3BlY2lmaWVkIGZvciBlYWNoIG1ha2UgaW52b2NhdGlvbi4KCkZpeCB0 aGlzIGJ5IGFkZGluZyBzdXBwb3J0IGZvciAtLXdpdGhvdXQtbWFrZWluZm8gaW4gdG9wLWxl dmVsIGNvbmZpZ3VyZS4KClRlc3RlZCBieSBidWlsZGluZyBnZGIgb24geDg2XzY0LWxpbnV4 LCBhbmQgdmVyaWZ5aW5nIHRoYXQgbm8gLmluZm8gZmlsZXMKd2VyZSBnZW5lcmF0ZWQuCgpD aGFuZ2VMb2c6CgoyMDIyLTA5LTA1ICBUb20gZGUgVnJpZXMgIDx0ZGV2cmllc0BzdXNlLmRl PgoKCSogY29uZmlndXJlLmFjOiBBZGQgLS13aXRob3V0LW1ha2VpbmZvLgoJKiBjb25maWd1 cmU6IFJlZ2VuZXJhdGUuCgotLS0KIGNvbmZpZ3VyZSAgICB8IDQgKysrKwogY29uZmlndXJl LmFjIHwgNCArKysrCiAyIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKQoKZGlmZiAt LWdpdCBhL2NvbmZpZ3VyZSBiL2NvbmZpZ3VyZQppbmRleCAxNjEzOWUzYmZhMy4uNjZjY2Vm NGQ4YzAgMTAwNzU1Ci0tLSBhL2NvbmZpZ3VyZQorKysgYi9jb25maWd1cmUKQEAgLTgzODYs NiArODM4Niw5IEBAIGZpCiBkb25lCiB0ZXN0IC1uICIkTUFLRUlORk8iIHx8IE1BS0VJTkZP PSIkTUlTU0lORyBtYWtlaW5mbyIKIAoraWYgdGVzdCAkd2l0aF9tYWtlaW5mbyA9ICJubyI7 IHRoZW4KK01BS0VJTkZPPXRydWUKK2Vsc2UKIGNhc2UgIiAkYnVpbGRfY29uZmlnZGlycyAi IGluCiAgICoiIHRleGluZm8gIiopIE1BS0VJTkZPPSckJHIvJChCVUlMRF9TVUJESVIpL3Rl eGluZm8vbWFrZWluZm8vbWFrZWluZm8nIDs7CiAgICopCkBAIC04NDAxLDYgKzg0MDQsNyBA QCBjYXNlICIgJGJ1aWxkX2NvbmZpZ2RpcnMgIiBpbgogICAgIDs7CiAKIGVzYWMKK2ZpCiAK ICMgRklYTUU6IGV4cGVjdCBhbmQgZGVqYWdudSBtYXkgYmVjb21lIGJ1aWxkIHRvb2xzPwog CmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggYTU1NTVh OWM5MWIuLjM2ODBmYTk3MDg3IDEwMDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29u ZmlndXJlLmFjCkBAIC0zNDM2LDYgKzM0MzYsOSBAQCBjYXNlICIgJGJ1aWxkX2NvbmZpZ2Rp cnMgIiBpbgogZXNhYwogCiBBQ19DSEVDS19QUk9HUyhbTUFLRUlORk9dLCBtYWtlaW5mbywg WyRNSVNTSU5HIG1ha2VpbmZvXSkKK2lmIHRlc3QgJHdpdGhfbWFrZWluZm8gPSAibm8iOyB0 aGVuCitNQUtFSU5GTz10cnVlCitlbHNlCiBjYXNlICIgJGJ1aWxkX2NvbmZpZ2RpcnMgIiBp bgogICAqIiB0ZXhpbmZvICIqKSBNQUtFSU5GTz0nJCRyLyQoQlVJTERfU1VCRElSKS90ZXhp bmZvL21ha2VpbmZvL21ha2VpbmZvJyA7OwogICAqKQpAQCAtMzQ1MSw2ICszNDU0LDcgQEAg Y2hhbmdlcXVvdGUoLCkKICAgICA7OwogY2hhbmdlcXVvdGUoWyxdKQogZXNhYworZmkKIAog IyBGSVhNRTogZXhwZWN0IGFuZCBkZWphZ251IG1heSBiZWNvbWUgYnVpbGQgdG9vbHM/CiAK --------------Yox5JBjJotR6rxnmTMwDJrUQ--