From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E96F73858406 for ; Tue, 22 Feb 2022 22:38:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E96F73858406 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 21MMcWjN006180 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Feb 2022 17:38:37 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 21MMcWjN006180 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 845F11EDF0; Tue, 22 Feb 2022 17:38:32 -0500 (EST) Message-ID: <2a4bc2e5-a7b9-a448-1988-75c53dd61c83@polymtl.ca> Date: Tue, 22 Feb 2022 17:38:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v5 06/15] do_target_wait_1: Clear TARGET_WNOHANG if the target isn't async. Content-Language: en-US To: John Baldwin , gdb-patches@sourceware.org References: <20220121201631.63530-1-jhb@FreeBSD.org> <20220121201631.63530-7-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20220121201631.63530-7-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 22 Feb 2022 22:38:32 +0000 X-Spam-Status: No, score=-3039.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Feb 2022 22:38:47 -0000 On 2022-01-21 15:16, John Baldwin wrote: > Previously, TARGET_WNOHANG was cleared if a target supported async > mode even if async mode wasn't currently enabled. This change only > permits TARGET_WNOHANG if async mode is enabled. > --- > gdb/infrun.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/infrun.c b/gdb/infrun.c > index 5959c3e6658..f8ccafd287d 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -3629,7 +3629,7 @@ do_target_wait_1 (inferior *inf, ptid_t ptid, > > /* We can't ask a non-async target to do a non-blocking wait, so this will be > a blocking wait. */ > - if (!target_can_async_p ()) > + if (!target_is_async_p ()) > options &= ~TARGET_WNOHANG; > > if (deprecated_target_wait_hook) Hi John, Starting with this patch I see a bunch of multi-target tests start to fail, for instance gdb.multi/multi-target-info-inferiors.exp. This is on plain Ubuntu 20.04 amd64. I don't have much time now, but I can provide more info later if needed. Simon