From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by sourceware.org (Postfix) with ESMTPS id EBEB43851C33 for ; Tue, 6 Oct 2020 14:27:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EBEB43851C33 Received: by mail-qk1-x742.google.com with SMTP id v123so16806812qkd.9 for ; Tue, 06 Oct 2020 07:27:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/T0kVGrDmeNFLlIQ7gBsxY1JpORPDQ00TUXqpPtce/c=; b=o5/1ehsMic5JXiv5NybT+FCNdH3RelhHOGBG4CHtkl+M/j0ZSYYaEXBWeEKoimhVdm btNx6qr6Aq0MlvbminKhEA5aVlDmBeADDnllT67JtC/xoXNQEBo0w8ik8biUjq63XuCj KHlvxKhCK+hT5laO5Ly0D33CydmhTeiZ7xIEcD3BnY/XAtx5pNMRYMJQXm1duaVIiU4p tceucwX1JxMAarjtFgrvKoTIoeNYhBEIsxeIc6c8DVDVQ/TKvCAJ6UHqkbKWjINAZ+35 HngrYHUTYru9fx3z6z/19+z2V/+n5235pom1zpNMCRRXKBH8Vru2S0gK+OwRwCnVGpLF 2uJg== X-Gm-Message-State: AOAM531NeqPFJkygicU8Q8NZ1RgCCd1IyEUSYB4QDJAphrMwsRAn2Pya ssyuiAwg1zN+3TrpzB0GDWqfWg== X-Google-Smtp-Source: ABdhPJwNzOHswzVgAj25lrUWZdxnq6BC07RcceiWE0OIKE7Q3dm6BGeQC1UUhSIvyYGccpmQHI8T+A== X-Received: by 2002:a37:aa0a:: with SMTP id t10mr5537381qke.128.1601994436283; Tue, 06 Oct 2020 07:27:16 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:fe4b:a8e8:3d0e:18c4:e36a? ([2804:7f0:8283:fe4b:a8e8:3d0e:18c4:e36a]) by smtp.gmail.com with ESMTPSA id r64sm2633738qkf.119.2020.10.06.07.27.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Oct 2020 07:27:15 -0700 (PDT) Subject: Re: [PATCH] Add NetBSD/aarch64 gdbserver support To: Kamil Rytarowski , gdb-patches@sourceware.org References: <20201006000120.8166-1-n54@gmx.com> From: Luis Machado Message-ID: <2a4dac0f-0ee8-dd71-3f59-900bf4163660@linaro.org> Date: Tue, 6 Oct 2020 11:27:13 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201006000120.8166-1-n54@gmx.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2020 14:27:18 -0000 Hi, On 10/5/20 9:01 PM, Kamil Rytarowski wrote: > The support is on par with NetBSD/amd64, thus GPR works, > single step and software breakpoint are operational, and the > SVR4 r_debug integration is functional. > > gdbserver/ChangeLog: > > * netbsd-aarch64-low.cc: Add. > * Makefile.in (SFILES): Register "netbsd-aarch64-low.c". > * configure.srv: Add aarch64*-*-netbsd*. > --- > gdbserver/ChangeLog | 6 ++ > gdbserver/Makefile.in | 1 + > gdbserver/configure.srv | 6 ++ > gdbserver/netbsd-aarch64-low.cc | 113 ++++++++++++++++++++++++++++++++ > 4 files changed, 126 insertions(+) > create mode 100644 gdbserver/netbsd-aarch64-low.cc > > diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog > index d667a203e67..5fd71b6ee71 100644 > --- a/gdbserver/ChangeLog > +++ b/gdbserver/ChangeLog > @@ -1,3 +1,9 @@ > +2020-10-01 Kamil Rytarowski > + > + * netbsd-aarch64-low.cc: Add. > + * Makefile.in (SFILES): Register "netbsd-aarch64-low.c". > + * configure.srv: Add aarch64*-*-netbsd*. > + > 2020-10-01 Kamil Rytarowski > > * netbsd-i386-low.cc: Add. > diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in > index 8b80acebdf1..442a34b381f 100644 > --- a/gdbserver/Makefile.in > +++ b/gdbserver/Makefile.in > @@ -193,6 +193,7 @@ SFILES = \ > $(srcdir)/linux-x86-low.cc \ > $(srcdir)/linux-xtensa-low.cc \ > $(srcdir)/mem-break.cc \ > + $(srcdir)/netbsd-aarch64-low.cc \ > $(srcdir)/netbsd-amd64-low.cc \ > $(srcdir)/netbsd-i386-low.cc \ > $(srcdir)/netbsd-low.cc \ > diff --git a/gdbserver/configure.srv b/gdbserver/configure.srv > index c4fe4ca81ee..cd25b1574e0 100644 > --- a/gdbserver/configure.srv > +++ b/gdbserver/configure.srv > @@ -61,6 +61,12 @@ case "${gdbserver_host}" in > ipa_obj="${ipa_obj} linux-aarch64-tdesc-ipa.o" > ipa_obj="${ipa_obj} arch/aarch64-ipa.o" > ;; > + aarch64*-*-netbsd*) srv_regobj="" > + srv_tgtobj="netbsd-low.o netbsd-aarch64-low.o fork-child.o" > + srv_tgtobj="${srv_tgtobj} nat/fork-inferior.o" > + srv_tgtobj="${srv_tgtobj} nat/netbsd-nat.o" > + srv_tgtobj="${srv_tgtobj} arch/aarch64-insn.o arch/aarch64.o" > + ;; > arm*-*-linux*) srv_tgtobj="$srv_linux_obj linux-arm-low.o" > srv_tgtobj="$srv_tgtobj linux-arm-tdesc.o" > srv_tgtobj="$srv_tgtobj linux-aarch32-low.o" > diff --git a/gdbserver/netbsd-aarch64-low.cc b/gdbserver/netbsd-aarch64-low.cc > new file mode 100644 > index 00000000000..d0e485649d9 > --- /dev/null > +++ b/gdbserver/netbsd-aarch64-low.cc > @@ -0,0 +1,113 @@ > +/* Copyright (C) 2020 Free Software Foundation, Inc. > + > + This file is part of GDB. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include > +#include > +#include > + > +#include "server.h" > +#include "netbsd-low.h" > +#include "arch/aarch64.h" > +#include "arch/aarch64-insn.h" > +#include "tdesc.h" > + > +/* The fill_function for the general-purpose register set. */ > + > +static void > +netbsd_aarch64_fill_gregset (struct regcache *regcache, char *buf) > +{ > + struct reg *r = (struct reg *) buf; > + > +#define netbsd_aarch64_collect_gp(regnum, fld) do { \ > + collect_register (regcache, regnum, &r->fld); \ > + } while (0) Do we really need the above instead of using the for loop below? > + > + for (size_t i = 0; i < 31; i++) > + netbsd_aarch64_collect_gp (AARCH64_X0_REGNUM + i, r_reg[i]); A matter of taste, but we could define a reasonably-named constant for "31" instead of hardcoding it here. > + > + netbsd_aarch64_collect_gp (AARCH64_SP_REGNUM, r_sp); > + netbsd_aarch64_collect_gp (AARCH64_PC_REGNUM, r_pc); > +} > + > +/* The store_function for the general-purpose register set. */ > + > +static void > +netbsd_aarch64_store_gregset (struct regcache *regcache, const char *buf) > +{ > + struct reg *r = (struct reg *) buf; > + > +#define netbsd_aarch64_supply_gp(regnum, fld) do { \ > + supply_register (regcache, regnum, &r->fld); \ > + } while(0) Same as above. Do we really need this construct? > + > + for (size_t i = 0; i < 31; i++) > + netbsd_aarch64_supply_gp (AARCH64_X0_REGNUM + i, r_reg[i]); Same suggestion to replace the hardcoded constant with a define. > + > + netbsd_aarch64_supply_gp (AARCH64_SP_REGNUM, r_sp); > + netbsd_aarch64_supply_gp (AARCH64_PC_REGNUM, r_pc); > +} > + > +/* Description of all the aarch64-netbsd register sets. */ > + > +static const struct netbsd_regset_info netbsd_target_regsets[] = > +{ > + /* General Purpose Registers. */ > + {PT_GETREGS, PT_SETREGS, sizeof (struct reg), > + netbsd_aarch64_fill_gregset, netbsd_aarch64_store_gregset}, > + /* End of list marker. */ > + {0, 0, -1, NULL, NULL } > +}; > + > +/* NetBSD target op definitions for the aarch64 architecture. */ > + > +class netbsd_aarch64_target : public netbsd_process_target > +{ > +protected: > + const netbsd_regset_info *get_regs_info () override; > + > + void low_arch_setup () override; > +}; > + > +/* Return the information to access registers. */ > + > +const netbsd_regset_info * > +netbsd_aarch64_target::get_regs_info () > +{ > + return netbsd_target_regsets; > +} > + > +/* Architecture-specific setup for the current process. */ > + > +void > +netbsd_aarch64_target::low_arch_setup () > +{ > + target_desc *tdesc > + = aarch64_create_target_description (0, false); Did you choose to go with the standard core registers with CPSR and no TPIDR? Otherwise this looks good and I don't have any more comments.