Re: [PATCH v2 0/2] Fix tab vs spaces in generated gdbarch.c

[Simon Marchi <simark@simark.ca>]

On 12/2/22 14:21, Thiago Jung Bauermann via Gdb-patches wrote:
> Hello,
> 
> This version addresses Simon's review comments. It generates the same
> gdbarch.c as v1. There are only minor formatting and code reorganization
> changes in gdbarch.py.
> 
> Changes since v1:
> 
> - gdbarch.py: Fix indentation in the generated gdbarch_dump function
>   - Formatted with black.
> - gdbarch.py: Fix indentation in the generated set_gdbarch_* definitions
>   - Formatted with black.
>   - Added separate function to avoid duplicating the computation of the
>     indentation characters, as proposed by Simon.
> 
> Original cover letter:
> 
> If you change gdbarch-components.py and submit a patch containing the
> generated gdbarch.c file, git will point out that it contains whitespace
> errors, e.g.:
> 
> Applying: gdb/aarch64: Detect vector length changes when debugging remotely
> .git/rebase-apply/patch:164: indent with spaces.
>                        "gdbarch_dump: update_architecture = <%s>\n",
> .git/rebase-apply/patch:165: indent with spaces.
>                        host_address_to_string (gdbarch->update_architecture));
> .git/rebase-apply/patch:186: indent with spaces.
>                                   gdbarch_update_architecture_ftype update_architecture)
> warning: 3 lines add whitespace errors.
> 
> These patches make gdbarch.py generate indentation using tabs and spaces
> as required by the GNU coding style. The first patch also takes the
> opportunity to align the function arguments with the opening parenthesis
> in the line above.
> 
> In both patches, “git show --ignore-all-space” confirms that gdbarch.c has
> only whitespace changes.
> 
> Thiago Jung Bauermann (2):
>   gdbarch.py: Fix indentation in the generated gdbarch_dump function
>   gdbarch.py: Fix indentation in the generated set_gdbarch_* definitions
> 
>  gdb/gdbarch.c  | 1502 ++++++++++++++++++++++++------------------------
>  gdb/gdbarch.py |   41 +-
>  2 files changed, 773 insertions(+), 770 deletions(-)
> 
> 
> base-commit: 55fc1623f942fba10362cb199f9356d75ca5835b

Thanks:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon