From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1FF013858425 for ; Tue, 23 Nov 2021 18:16:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1FF013858425 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-431-SwIxK27ZN9ell2cZLZyiVA-1; Tue, 23 Nov 2021 13:16:47 -0500 X-MC-Unique: SwIxK27ZN9ell2cZLZyiVA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 494C81006AA3; Tue, 23 Nov 2021 18:16:46 +0000 (UTC) Received: from [10.97.116.88] (ovpn-116-88.gru2.redhat.com [10.97.116.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C22EA19730; Tue, 23 Nov 2021 18:16:44 +0000 (UTC) Message-ID: <2a5b7baf-0e05-b8eb-ffac-af8aa77be8f7@redhat.com> Date: Tue, 23 Nov 2021 15:16:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: GDB 11.2 ("re-spin") update (2021-11-21) To: Joel Brobecker Cc: gdb-patches@sourceware.org References: <252590db-4a8f-68ac-fad5-382783e5ea02@redhat.com> From: Bruno Larsen In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 18:16:53 -0000 On 11/23/21 01:54, Joel Brobecker wrote: > Hi Bruno, > >> I'm wondering if PR 28480 >> (https://sourceware.org/bugzilla/show_bug.cgi?id=28480) is relevant >> enough to be on .2; A solution is already on the list >> (https://sourceware.org/pipermail/gdb-patches/2021-November/183243.html) >> but hasn't been accepted yet >> >> Basically, with this proposed solutions, things will stop breaking >> silently and will now loudly warn if ambiguous requests are made. > > This seems reasonable to me, provided the patch doesn't drag for > too long, and then a Global Maintainer approves the patch for > backporting to 11.2 (it looks relatively contained, so no objection > a priori myself, but I don't know much about this area of the code). I wouldn't expect the patch to drag, since the last comments were to do with formatting, more than about the solution itself. I would be surprised if it wasn't self contained, but it is possible, I am not very familiar with the code as a whole. > > The PR suggests this is a regression from GDB 10, but it sounds > like it was really luck of the draw that made it work before? > Pretty much. It was reported as a regression, but we eventually understood that it is just the "bad commit" was just not thorough enough and that the code was relying on undefined behavior. -- Cheers! Bruno Larsen