From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/6] Pass section index to start_compunit_symtab
Date: Wed, 18 Jan 2023 17:06:57 -0500 [thread overview]
Message-ID: <2ae94116-fb85-ee8b-8772-4cf176a45c11@simark.ca> (raw)
In-Reply-To: <87pmbbzekb.fsf@tromey.com>
On 1/18/23 17:02, Tom Tromey via Gdb-patches wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
>>> + SECTION_INDEX is the index of the section for the compunit and
>>> + for block symbols in this compunit. Normally SECT_OFF_TEXT. */
>
> Simon> I don't understand this comment, specifically how a compunit can "have"
> Simon> a single section. Don't compunits define data and text symbols, which
> Simon> have different sections, for instance?
>
> I can reword it, this only refers to the section for blocks. See
> compunit_symtab::m_block_line_section.
>
> Simon> I'm curious to know why we have to store that and we can't always use
> Simon> SECT_OFF_TEXT, but I guess that will come with the following patches.
>
> I suspect this is dead code, I just didn't change it in this series.
> I could though if you'd prefer.
I suppose that if it's indeed always the text section that is passed, it
would be easy to spot.
Simon
next prev parent reply other threads:[~2023-01-18 22:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 15:30 [PATCH 0/6] Change how symbol section indices are set Tom Tromey
2023-01-18 15:30 ` [PATCH 1/6] Use default section indexes in fixup_symbol_section Tom Tromey
2023-01-18 17:19 ` Simon Marchi
2023-01-18 19:13 ` Tom Tromey
2023-01-18 15:30 ` [PATCH 2/6] Set section indices when symbols are made Tom Tromey
2023-01-18 21:43 ` Simon Marchi
2023-01-18 22:00 ` Tom Tromey
2023-01-18 15:30 ` [PATCH 3/6] Pass section index to start_compunit_symtab Tom Tromey
2023-01-18 21:55 ` Simon Marchi
2023-01-18 22:02 ` Tom Tromey
2023-01-18 22:06 ` Simon Marchi [this message]
2023-01-19 13:36 ` Tom Tromey
2023-02-08 16:28 ` Tom Tromey
2023-01-18 15:30 ` [PATCH 4/6] Set section index when setting a symbol's block Tom Tromey
2023-01-18 15:30 ` [PATCH 5/6] Remove most calls to fixup_symbol_section Tom Tromey
2023-01-18 15:30 ` [PATCH 6/6] Merge fixup_section and fixup_symbol_section Tom Tromey
2023-02-08 16:28 ` [PATCH 0/6] Change how symbol section indices are set Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ae94116-fb85-ee8b-8772-4cf176a45c11@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).