public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Bruno Larsen <blarsen@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/6] Remove some uses of xfree
Date: Tue, 5 Oct 2021 15:13:34 -0300	[thread overview]
Message-ID: <2b1a001d-ec86-1062-ff3d-d239752adf2d@redhat.com> (raw)
In-Reply-To: <20211005001453.2957929-1-tom@tromey.com>

On 10/4/21 9:14 PM, Tom Tromey wrote:
> I found a few spots using manual memory management that could easily
> be changed to use unique_xmalloc_ptr or std::string.  I split this
> into separate patches to make each change simpler to understand.
> 
> Regression tested on x86-64 Fedora 34.
> 
> Tom
> 
> 

Tested this patch series on ppc64le RHEL 8.5, no regressions there, and aarch64 RHEL 8.5 has quite a few gdb.mi new failures, but those tests seem... unreliable at best. I'll dig a bit into them to see if they are racy, but in general looks like a good change with no errors introduced

-- 
Cheers!
Bruno Larsen


  parent reply	other threads:[~2021-10-05 18:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  0:14 Tom Tromey
2021-10-05  0:14 ` [PATCH 1/6] Use unique_xmalloc_ptr in solib_catchpoint Tom Tromey
2021-10-05  0:14 ` [PATCH 2/6] Use unique_xmalloc_ptr in exec_catchpoint Tom Tromey
2021-10-05  0:14 ` [PATCH 3/6] Use unique_xmalloc_ptr in watchpoint Tom Tromey
2021-10-05  0:14 ` [PATCH 4/6] Use unique_xmalloc_ptr in bp_location Tom Tromey
2021-10-05  0:14 ` [PATCH 5/6] Use unique_xmalloc_ptr in breakpoing Tom Tromey
2021-10-05  0:14 ` [PATCH 6/6] Use std::string in print_one_catch_syscall Tom Tromey
2021-10-05 18:13 ` Bruno Larsen [this message]
2021-10-20 17:00 ` [PATCH 0/6] Remove some uses of xfree Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b1a001d-ec86-1062-ff3d-d239752adf2d@redhat.com \
    --to=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).