From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 6BEAC385BF9C for ; Tue, 5 Oct 2021 18:13:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6BEAC385BF9C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-12-qLMbdGn-OJKZSpHCc3bCbQ-1; Tue, 05 Oct 2021 14:13:40 -0400 X-MC-Unique: qLMbdGn-OJKZSpHCc3bCbQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2C84A8145E5; Tue, 5 Oct 2021 18:13:39 +0000 (UTC) Received: from blarsen.remote.csb (ovpn-116-91.gru2.redhat.com [10.97.116.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D167E19D9D; Tue, 5 Oct 2021 18:13:37 +0000 (UTC) Subject: Re: [PATCH 0/6] Remove some uses of xfree To: Tom Tromey , gdb-patches@sourceware.org References: <20211005001453.2957929-1-tom@tromey.com> From: Bruno Larsen Message-ID: <2b1a001d-ec86-1062-ff3d-d239752adf2d@redhat.com> Date: Tue, 5 Oct 2021 15:13:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211005001453.2957929-1-tom@tromey.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 18:13:42 -0000 On 10/4/21 9:14 PM, Tom Tromey wrote: > I found a few spots using manual memory management that could easily > be changed to use unique_xmalloc_ptr or std::string. I split this > into separate patches to make each change simpler to understand. > > Regression tested on x86-64 Fedora 34. > > Tom > > Tested this patch series on ppc64le RHEL 8.5, no regressions there, and aarch64 RHEL 8.5 has quite a few gdb.mi new failures, but those tests seem... unreliable at best. I'll dig a bit into them to see if they are racy, but in general looks like a good change with no errors introduced -- Cheers! Bruno Larsen