From: Simon Marchi <simark@simark.ca>
To: Lancelot SIX <lsix@lancelotsix.com>,
Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: fix array-view-selftests.c build with g++ 4.8
Date: Thu, 18 Nov 2021 16:36:22 -0500 [thread overview]
Message-ID: <2b550d1b-8033-b9b4-9d69-b9513eb8fdb4@simark.ca> (raw)
In-Reply-To: <20211118211132.sobuijcdi74wm4i7@ubuntu.lan>
On 2021-11-18 4:11 p.m., Lancelot SIX via Gdb-patches wrote:
> On Thu, Nov 18, 2021 at 03:50:53PM -0500, Simon Marchi via Gdb-patches wrote:
>> When building with g++ 4.8, I get:
>>
>> CXX unittests/array-view-selftests.o
>> /home/smarchi/src/binutils-gdb/gdb/unittests/array-view-selftests.c:123:42: error: expected 'class' before 'Container'
>> template<template<typename ...> typename Container>
>> ^
>>
>> I am no C++ template expert, but it looks like if I change "typename" for
>> "class", as the compiler kind of suggests, the code compiles.
>
> Indeed. Apparently 'typename' can be used instead of 'class' in a
> template template parameter only starting c++17[1].
>
> Thanks for taking care of this.
>
> Lancelot.
>
> [1] https://en.cppreference.com/w/cpp/language/template_parameters#Template_template_parameter
Ok, thanks for the info. Since you acked this patch and patch 1/2
fixes a regression I introduced, I pushed the two patches.
Simon
prev parent reply other threads:[~2021-11-18 21:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 20:50 [PATCH 1/2] gdb: fix ia64-tdep.c " Simon Marchi
2021-11-18 20:50 ` [PATCH 2/2] gdb: fix array-view-selftests.c " Simon Marchi
2021-11-18 21:11 ` Lancelot SIX
2021-11-18 21:36 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b550d1b-8033-b9b4-9d69-b9513eb8fdb4@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).