From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 77E3A3858422 for ; Thu, 18 Nov 2021 21:36:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77E3A3858422 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D224F1EDEE; Thu, 18 Nov 2021 16:36:22 -0500 (EST) Subject: Re: [PATCH 2/2] gdb: fix array-view-selftests.c build with g++ 4.8 To: Lancelot SIX , Simon Marchi Cc: gdb-patches@sourceware.org References: <20211118205053.2429353-1-simon.marchi@efficios.com> <20211118205053.2429353-2-simon.marchi@efficios.com> <20211118211132.sobuijcdi74wm4i7@ubuntu.lan> From: Simon Marchi Message-ID: <2b550d1b-8033-b9b4-9d69-b9513eb8fdb4@simark.ca> Date: Thu, 18 Nov 2021 16:36:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211118211132.sobuijcdi74wm4i7@ubuntu.lan> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2021 21:36:25 -0000 On 2021-11-18 4:11 p.m., Lancelot SIX via Gdb-patches wrote: > On Thu, Nov 18, 2021 at 03:50:53PM -0500, Simon Marchi via Gdb-patches wrote: >> When building with g++ 4.8, I get: >> >> CXX unittests/array-view-selftests.o >> /home/smarchi/src/binutils-gdb/gdb/unittests/array-view-selftests.c:123:42: error: expected 'class' before 'Container' >> template typename Container> >> ^ >> >> I am no C++ template expert, but it looks like if I change "typename" for >> "class", as the compiler kind of suggests, the code compiles. > > Indeed. Apparently 'typename' can be used instead of 'class' in a > template template parameter only starting c++17[1]. > > Thanks for taking care of this. > > Lancelot. > > [1] https://en.cppreference.com/w/cpp/language/template_parameters#Template_template_parameter Ok, thanks for the info. Since you acked this patch and patch 1/2 fixes a regression I introduced, I pushed the two patches. Simon