From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2061.outbound.protection.outlook.com [40.107.116.61]) by sourceware.org (Postfix) with ESMTPS id 52F543858D20 for ; Sat, 14 Oct 2023 20:12:48 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 52F543858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.116.61 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697314369; cv=pass; b=C1hNmLLFDdQHZAM3y5CfHkpIU5ao1YuaybVunWj3gE2N3C7n1CTHiZziuHZcwqvCwSLh/Hl7oi8PxVbomQ2Q1HX4w9KlhKdy7URPCZppwADYHtWbfHHB13jFyAj42SismzjL6H2QwHiYj4q9gX/wsYWDDW18/6rOJ4/X24V8P/o= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697314369; c=relaxed/simple; bh=w0xMvT8/ej0YMQbuefiocrBpBexK5y8Vxgqi/If6vYg=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=OLSzJUN6BD9JGut9eeppf38Mf28Hmzrow03P/nypv+4LWWEuJbdYHNn3TkaseJpWFxyWh3088tvOiqZuFQ5SXeEDnftT2IBcwVVDyCfkyeDDxNSS5tRZnid4RX6FgaauSYWe+1gD0C30j+udoq0he0c34bw8kP8pFSjeAnQGoN4= ARC-Authentication-Results: i=2; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 52F543858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ey2hhuRNeBM4XRTNE7WjocC/2NBCsSOfvHor7qR1M3/B9lH06RaenxoIFsUd2e+uA4S1UJrZXxwlk2mXUG5NG6QtT1rUlthf6QbyNGOdW+wbur16JaOdMJQcoCshndNjt/tvq5WJKYp2Io61W1uLcAm+TEieg4UKStoZxJGZWUwN2JlbXJXAZw7RsXSBO8v7yKV6oy5qzcYuNJ5ZFuHCo+7okekomdiDE6+C44BiTJHe4Gg2LT5aYgEGjMtX/mRgYxFjTBOYEJTFCDK6GRvVaPC1gANc9owzAlWCZlVPCrqWKEYk7BqX7px9G52JW15Ji418FmifaeB71SvJg7NDMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DgFPRO1xQav/nFfecgCpXhGLQXLXws4gIpcUoSmpInQ=; b=lT2OkWPqiepheF63V9Dmrzm42h35mbPGsfRQXHKzgXKRb8mcjjC2Bnvhm4jhkhmoDQncrkgL6lXFtNUbzaWUTV9npIy+eWCPpC2AFx+IMYB8LGZrjOBXh9QyFPwmA52wiBWnozzpy5AMB+VqFYielsioST9tGSKiYy7cNyFpOYCHhRYNrvRQ2SfDUwJav+tebLddowbbJY87OwlBdZgc28Qv9BwzSH8EQrY6k39B+6+6hQ+JNCP6PQctTvqGqW+dEj1VgnOJa6GVzV7CSIlOuOhdYZC/mEef5tkT3yoEwKzw7QXl9EpqOUfD/YOb5P6Phza0RVSJW+PZXovGiKtRAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DgFPRO1xQav/nFfecgCpXhGLQXLXws4gIpcUoSmpInQ=; b=e7VQ7ecPlzu2GYzRTswbNYsjgLg7Th4xwR8C7cjpF4H9n1r45WqCNviVa0i/UU/fYU3+bhuCbQV776W9wEEiu/v70Jiwbke+KiIXO3T0i9tQSaIbIB8OokefLOxsZxchCYMVmR6YZIdlWTblZRXnlDrX1VOJOxNxr/0WUA544RZq3v1KDaVebY7MNzRpCzAmcoiThUDfKGH4uEU4B/to5kHwlC+Cf2BvBytO9YFB6V8vLQ6gNDXjp4DK9rtz7Bs/Rm3PBTbwT2EiqJXA9lzhiyUc6FPZBZa/Pc4qLDlGrmCUGvX2ObZzKDmP3TPV11OKrKWk0itpCstmBpoGcVXyAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YQBPR0101MB9135.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:5e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.34; Sat, 14 Oct 2023 20:12:45 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a%7]) with mapi id 15.20.6886.034; Sat, 14 Oct 2023 20:12:45 +0000 Message-ID: <2b5f2f66-eb76-4fef-8fc7-6551a3db2677@efficios.com> Date: Sat, 14 Oct 2023 16:12:44 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/24] gdbsupport: make intrusive_list's disposer accept a reference Content-Language: fr To: Pedro Alves , gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-7-simon.marchi@efficios.com> <1f70b3f3-3291-4115-99e1-948707d9c7a2@palves.net> From: Simon Marchi In-Reply-To: <1f70b3f3-3291-4115-99e1-948707d9c7a2@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQXP288CA0034.CANP288.PROD.OUTLOOK.COM (2603:10b6:c00:41::45) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YQBPR0101MB9135:EE_ X-MS-Office365-Filtering-Correlation-Id: 0886ab1f-a326-44bd-adf5-08dbccf1edfd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lfFN1X+gYSsHhPKDOI9a9gbZ0IYrvvVGOSxQh5BIXDl8Clf+LehAawxFpmCUK7lovPVy+PghMKIXQGjDXUXDb/NEC1zgxFs3e5GRlurpyMTfSFsaiXxhspf2WBubbIFxEgaBvJQlumqPvyKSr/5OFT2lu+4x3uEoYmtgZ8TF6Ksjo9J3YduB9bjwGcRGfbQ8QhXPY/b3DK72LyIkIH8aOCfmjHtPDXyoPMzJe8UHF7IBTiQL24KUcZxPRrUeMuUZoSjPPN5BBP6x9ZylXanXtmvdMmt0zsOLVMHOwu76nbPDmgQoJtHkUVooWT0KfbEIX/l8LCgvl58QUzH5EpcQAoqtzDU9ZtHjRf1QUh2lWx5rdVW1ONN+pKXVANi4nHHxd89SYirG6Q/du5M39ApyqQqgCr5eBvSdbF1TZPqfo074CSHdwqjazZjSnqHipSjUuBGlh2DTA6W1onlxtEbcZay3IF7LqF3f83R/FizxcnH1nc862Kn7BdmhrttpX7E8KuxiZxgYaa+yQaCOPEd4Epa92vPiYLreVzLV/p6BG+IbnZPDJHRjIkcXEu/AsfpTdDY5bMiepcvmc1+Engj4VflyC54hP9ldSKbtHojPPwRrLIvoO953nCFEOpCYwFdqzV40MqZtn26aNrcFyAYjfg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(136003)(39830400003)(366004)(396003)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(2616005)(26005)(6506007)(6512007)(53546011)(83380400001)(41300700001)(44832011)(5660300002)(8676002)(2906002)(4001150100001)(478600001)(6486002)(8936002)(66946007)(66556008)(316002)(66476007)(31696002)(38100700002)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2g0RXE2QWJPUW9LVzcxNHZmZCs1MzhDMzZJcDd3L1NuQ2x2UmRDN1VadWpF?= =?utf-8?B?Q2FXSmpwaVdZM05JN1JZOE5VajFid3pBNTMwQW1ZYm85MlFYcDJoM3IrRUhL?= =?utf-8?B?LzArbzhBSFMxdE9JaVdwM0VVUUppQ0s2bkdrN2kzbHhyS3RCMk1wQ1BqN1Jh?= =?utf-8?B?R0JpV0NaRm90UDg0bm9rQ1d6cmhxMm4yS1pHdnVXMnNpZnV3TWJYeXRFdVBH?= =?utf-8?B?WStLVHk3RjVDb1ZRYUdIYjM2REx5bWE1RE8wVmxlTUtxelZkVFAvbmVTN21H?= =?utf-8?B?N0IvU0hRTHJlc0pXT0Y5MkdtTVNla084T2pzTUVaOTQwVTlYZGFscWl6RkN3?= =?utf-8?B?RENOblB3aVhhWGlwMUoyOW5Nc3ZBbGtmcHp1NWNWT0wvak5vbE5NVjdWVVJS?= =?utf-8?B?Zm8xTFZjeUlYTVhwdDRWUk9yVXRraFhBS0hoY3AyVFZSUjBkaU5RSGxIR1JX?= =?utf-8?B?Ykc5b2tLTkIvZHlQTEFmbXlXKytQQTVFS2pHa2RPa0sxblJZNXhpSlAyZTY1?= =?utf-8?B?amN6VnhEL1J0UlFHSXFoNm1aRk5pcktmNE04WFYrdU1zYk9sVzl6YXhoK3ZK?= =?utf-8?B?Z0RmZktodDJ0Q2VyNFRYYXdpUjR5RllxdHUzdkRzU08vK1FTbEx4b1hQSzQ4?= =?utf-8?B?UEwvRHlWK1ZWT0VNTTFNdjExa3VJeXdZK0N0ZDJNZVlDeHJHU3hOb0IyUWVz?= =?utf-8?B?SmwzRmxlWmRKZzM5em80S2tkUlpsOGNzUFRDWE1LY04zbGlmUmVMTHY1dnpB?= =?utf-8?B?bDJNL2U2bHRPbkttRUIyNHNtYUxUeXVTYitNM1JhbzRjTXFrM2dNUEZrajdH?= =?utf-8?B?NzdUTnliVlR6ZnU4RmRoV0xVZ0dBcFRveko1VUhRMHU0S2oweGRPYmdrcFBM?= =?utf-8?B?cFQ0OXJsazFlQ1BhYzFsQVNoRW5uRGZ1RzJxQ0Foc1RwMmQ1TmdGcEFGSlha?= =?utf-8?B?czhHdk0wVklnNm8ydmlyeEFzeXBXbVZ1YmhRaTZLQ2RBVjd1VGVGT2RXSFNN?= =?utf-8?B?bUpncXFKcFpRQmlXTGFHMDlKUkpDK0JzYUhLZytMOEN2THRhTzloNHU0MFI1?= =?utf-8?B?dHNWdm5xb2J5NkptMjYyOGQ1dkdJMk80WDFqM3UzcW9DUmJmYTA5RzZ6Ny8v?= =?utf-8?B?UHhVclR2MitIa0gzS3BJVVY5UE5kM0tlaDVhUmV2UGFoc2ZFT1Q5a0p6Wkkw?= =?utf-8?B?RnpMRHRqZGdlYjdLaGlhdGJXSVk1NWp3YzQvQkVQSnhabTlnbFVzSDNhZ3lM?= =?utf-8?B?N0c5ai9MOEVXYWhDU1hyUVRnUXlHK3RNTGJ3cExDSE8zSW5DNGtSU0ZLbG9s?= =?utf-8?B?T1hTKzVYblBKVENyV1lWZnpKdVQrb2RpNFg2Y1I5Yms1b1p3ZzlNTXBhSWNH?= =?utf-8?B?WngyR0hnR3dLK3IyWDRWUkpjZGI3UnIyUWNZcUhhYVhVbnFjSDIrSjNwTE1U?= =?utf-8?B?bWNFZlJMckdPTGZHeUtGL1JVUlFYRm4waGNiNHVUTU9lNXhoWnRZUkVlb2hy?= =?utf-8?B?RFdHTUpuM1BPZlhlcVZ0cGxYV3ZSdWV0MmxlNE1KdFZ4MnYxRDFCdndKa2VQ?= =?utf-8?B?TEFxWVdCNVdiREcwaDN0emlCRVVsS3JoVkpJTVZXV1N1bDczVERUc0EyUGEz?= =?utf-8?B?cjhlWkpTZmNsb0EzcnNRSVA3ZitVTGhZUmwrRXR2K1I2ak54eGpVTlZxQmhq?= =?utf-8?B?eUNBMitGVmZrZFJzbGdjZUtydHBlcUVYZU9zNjBxTlBkZVd3enlITDlvdzh0?= =?utf-8?B?UjJHMDEyR2QyaG5lVmZIdkg1Q2x0cmkxWW50QUJkTldwbkdWaUh1YWNmem5V?= =?utf-8?B?c2NjN0RVeTc0UkV0S00rdEd1N2RETVp6MU9SMGUvZnBJdTJMY3B6S0dkbHdH?= =?utf-8?B?Tm9oL0hlRjBLNlRsZXRjSXIweTdpc3ZTU0pMc1NMekdHMjQ4OXR1eG94WUYy?= =?utf-8?B?R1BsOU4xYzdvSmNja2cxR1dvQ2I1dlViaWxKalNRWGdKeWovKyt2S2Nwa2Vn?= =?utf-8?B?aWFnUWJCREpldjZPLytEVUJtaDZoTE9vUDQrTklZT1NQRnZGc0pJTlVwWDVQ?= =?utf-8?B?cnRzZVpCdjY3SGV2S0NTalM1YlVEWXRNa1JIbVRaeWxheHBPWUtRTDJBbFA2?= =?utf-8?Q?cu7WnUA71fVVY8YwPdAp9l2Zx?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0886ab1f-a326-44bd-adf5-08dbccf1edfd X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2023 20:12:45.6230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L5gumw1LKDdGHuEY0jb4nV5oWf3NyHDrYP5fT4zNg0bodQLsk52TR4r5HFYxZ2qtC3WfHBJz9LpgRR0zd9KTeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB9135 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/12/23 15:05, Pedro Alves wrote: > On 2023-10-10 21:40, Simon Marchi wrote: >> All the API of intrusive_list works with references to item, I'm not >> sure why the disposer used in intrusive_list::clear_and_dispose is >> different and receives a pointer. Change it to accept a reference >> instead. This helps simplify a bit a subsequent patch, and I don't see >> any downside to it. > > The whole intrusive_list API was copied from Boost intrusive_list (not > the implementation), so that's where that came from. > > I assume that the Disposer interface takes a pointer so that it has the same > interface as a unique_ptr Deleter, for instance. From a pure disposer/deleter angle, > it seems a bit odd to me to have a "delete" operator wrapper take a reference > instead of a pointer, leading to code like "delete &ref", FWIW. > > If this doesn't result in a great tangible improvement, I'd prefer keeping > the interface in sync with Boost's. I forgot about that, that's a good reason, I'll drop this patch. Thanks, Simon