From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 03FEC3858D28 for ; Fri, 27 Jan 2023 20:50:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 03FEC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CADFD21C9D; Fri, 27 Jan 2023 20:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674852654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G+6o9RgzvEEXRn3X74KgDogZb6qXHQGi+25rjcX5gVI=; b=cN22RJV9R/Nmo8hPWVkswoRJJNp/PtKWouFFuX1fl37a4Xz1NdcMz9xcslMsh12XAVwRtB abvhALewkrFdS3/mppBUMogEB4KKrFQBK7og4spCG3bcbc5fJpe/FXNQj5bd7XAn9csd69 pwy9J6bWR88gz184nAb8RwYqz7eupQ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674852654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G+6o9RgzvEEXRn3X74KgDogZb6qXHQGi+25rjcX5gVI=; b=I/VXb6Ot/LVClYmiz5Xsyv49J9lJnIq3YLAllNDClelwMHupKePLU79hNmaX7JWWjsLAs1 qAJJgeYj617LQVAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B59B7138E3; Fri, 27 Jan 2023 20:50:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id f2syKy451GP/fwAAMHmgww (envelope-from ); Fri, 27 Jan 2023 20:50:54 +0000 Message-ID: <2b6ce3a3-7e68-7dbe-14ac-1fced7f0091f@suse.de> Date: Fri, 27 Jan 2023 21:50:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] [gdb/testsuite] Add gdb.base/unwind-on-each-insn-{amd64, i386}.exp To: Tom Tromey , Tom de Vries via Gdb-patches References: <20230125200910.29700-1-tdevries@suse.de> <875yctrw9w.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <875yctrw9w.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/26/23 19:22, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > Tom> I did wonder about eliminating commonality between > Tom> unwind-on-each-insn-i386.exp and unwind-on-each-insn-amd64.exp, but > Tom> decided it was not worth the trouble. > > One thing some gdb.arch tests do is test the arch and then set some > variables based on that. So I guess if you wanted there could be a > single .exp file and not the .exp/.tcl split. I could merge unwind-on-each-insn-i386.exp and unwind-on-each-insn-amd64.exp, but I still would require the split because also unwind-on-each-insn.exp use the .tcl file. Anyway, I've been playing with the idea of enabling unwind-on-each-insn-i386.exp on x86_64, using -m32 (but that might be part of a larger exercise, extending to all gdb.arch i386 test-cases). And for that I'd need unwind-on-each-insn-i386.exp separate from unwind-on-each-insn-amd64.exp. So, for now I'm keeping this as is. Thanks, - Tom