From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10659 invoked by alias); 26 Apr 2018 02:59:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10647 invoked by uid 89); 26 Apr 2018 02:59:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Apr 2018 02:59:17 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w3Q2xBqg027944 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 25 Apr 2018 22:59:16 -0400 Received: by simark.ca (Postfix, from userid 112) id 409D71EF61; Wed, 25 Apr 2018 22:59:11 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id D3E2A1E47D; Wed, 25 Apr 2018 22:59:09 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 26 Apr 2018 02:59:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Use XOBNEW when possible In-Reply-To: <87wowu7whb.fsf@tromey.com> References: <1524685183-5553-1-git-send-email-simon.marchi@ericsson.com> <1524685183-5553-2-git-send-email-simon.marchi@ericsson.com> <87wowu7whb.fsf@tromey.com> Message-ID: <2bed0d1423307ef2d14696df13fea151@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 26 Apr 2018 02:59:11 +0000 X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00532.txt.bz2 On 2018-04-25 18:27, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Since XOBNEW is now poisoned to prevent using it with > Simon> non-trivially-constructible objects, it is worth using it over > plain > Simon> obstack_alloc. This patch changes the locations I could find > where we > Simon> can do that change easily. > > Thanks. > > Simon> - struct hppa_objfile_private *priv; > Simon> + hppa_objfile_private *priv > Simon> + = XOBNEW (&objfile->objfile_obstack, hppa_objfile_private); > > Simon> - priv = (struct hppa_objfile_private *) > Simon> - obstack_alloc (&objfile->objfile_obstack, > Simon> - sizeof (struct hppa_objfile_private)); > Simon> set_objfile_data (objfile, hppa_objfile_priv_data, priv); > Simon> memset (priv, 0, sizeof (*priv)); > > Maybe ones that memset should be using OBSTACK_ZALLOC. Right, I'll do that. Thanks, Simon