From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 0C1A73858D1E for ; Tue, 14 Feb 2023 10:59:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C1A73858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2BCDA21B1C; Tue, 14 Feb 2023 10:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676372347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dPlzZeduqqOIWk9iL3cYGYWGDOu6ev4C9a0KJw5JNN0=; b=dBp/bARQHBasZJYRitYJP7GuJHtmmrD6N5+gFQvoDS3aLItYGEeP/mgZq9jMUjPqAHDVJK n5JyRXqvRB+Kgf/7GG6Fz81wVsdQEqQp4CLAX6XDgcpOOB8FXZJtemhz6Rgy+dQg0f60ym 0+NSm5ahCbqurpDA1HXOvkUgq0IdBlo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676372347; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dPlzZeduqqOIWk9iL3cYGYWGDOu6ev4C9a0KJw5JNN0=; b=6XTd/zS6lJJ6p/pEPnYQUT/6tDPV+5VMMPJNentmwicA8DZBgpT92VQMqPpRTW+d0QVkIq Rohcr2iLzHAJ9zDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1538E138E3; Tue, 14 Feb 2023 10:59:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 07bpA3tp62PAbgAAMHmgww (envelope-from ); Tue, 14 Feb 2023 10:59:07 +0000 Content-Type: multipart/mixed; boundary="------------WOpUbY7w0zGeh54dVjU2J0dn" Message-ID: <2bfa0573-bd7c-5dd6-6fea-f4837c4eeb66@suse.de> Date: Tue, 14 Feb 2023 11:59:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: [PATCH] [gdb/testsuite] Add xfail in gdb.python/py-record-btrace.exp To: "Metzger, Markus T" Cc: "gdb-patches@sourceware.org" References: <20230213181001.25142-1-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------WOpUbY7w0zGeh54dVjU2J0dn Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit [ was: Re: [PATCH] [gdb/testsuite] Add have_linux_btrace_bug ] On 2/13/23 20:17, Metzger, Markus T wrote: > Hello Tom, > >> The linux kernel commit 670638477aed ("perf/x86/intel/pt: Opportunistically >> use single range output mode"), added in version v5.5.0 had a bug that was >> fixed by commit ce0d998be927 ("perf/x86/intel/pt: Fix sampling using >> single range output") in version 6.1.0. >> >> The bug manifested for intel microarchitectures Rocket Lake, Raptor Lake and >> Alder Lake. > > Actually, it's a h/w bug that got exposed by using single-range output. It affects > Core processors starting from Ice Lake and it only affects Processor Trace. Also, > it is only exposed by the py-record-btrace test, which does a lot of single-stepping. > > It might be better to just add an XFAIL for that one test. I'm not sure if maintaining > a processor list makes sense. The kernel patch disables single-range for > 1 page > for all processors and does not try to maintain a list of affected processors. We might > want to do the same in GDB and either disable that test for kernels between 5.5 and > 6.1, or setup an XFAIL. > I've gone with the XFAIL, see attached patch. WDYT? > The Branch Trace Store issue you found seems to affect all btrace tests on ADL > E-cores. This is a different issue. I can reproduce it and I am currently debugging it. I see, ack, thanks for the update. - Tom --------------WOpUbY7w0zGeh54dVjU2J0dn Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Add-xfail-in-gdb.python-py-record-btra.patch" Content-Disposition: attachment; filename*0="0001-gdb-testsuite-Add-xfail-in-gdb.python-py-record-btra.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA5OWViYWMwMjM5N2YxOWJjMTZjYWQ2YTZmZWY3ODI4ZmJjNzE2ODAzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IE1vbiwgMTMgRmViIDIwMjMgMTg6Mjc6MTcgKzAxMDAKU3ViamVjdDogW1BBVENI XSBbZ2RiL3Rlc3RzdWl0ZV0gQWRkIHhmYWlsIGluIGdkYi5weXRob24vcHktcmVjb3JkLWJ0 cmFjZS5leHAKClRoZXJlJ3MgYSBIVyBidWcgYWZmZWN0aW5nIFByb2Nlc3NvciBUcmFjZSBv biBzb21lIEludGVsIHByb2Nlc3NvcnMKKEljZSBMYWtlIHRvIFJhcHRvciBMYWtlIG1pY3Jv YXJjaGl0ZWN0dXJlcykuCgpUaGUgYnVnIHdhcyBleHBvc2VkIGJ5IGxpbnV4IGtlcm5lbCBj b21taXQgNjcwNjM4NDc3YWVkCigicGVyZi94ODYvaW50ZWwvcHQ6IE9wcG9ydHVuaXN0aWNh bGx5IHVzZSBzaW5nbGUgcmFuZ2Ugb3V0cHV0IG1vZGUiKSwKYWRkZWQgaW4gdmVyc2lvbiB2 NS41LjAsIGFuZCB3YXMgd29ya2VkIGFyb3VuZCBieSBjb21taXQgY2UwZDk5OGJlOTI3Cigi cGVyZi94ODYvaW50ZWwvcHQ6IEZpeCBzYW1wbGluZyB1c2luZyBzaW5nbGUgcmFuZ2Ugb3V0 cHV0IikgaW4gdmVyc2lvbgo2LjEuMC4KClRoZSBidWcgbWFuaWZlc3RzIChvbiBhIFBlcmZv cm1hbmNlLWNvcmUgb2YgYW4gaTctMTI1MFUsIGFuIEFsZGVyIExha2UgY3B1KSBpbgphIHNp bmdsZSB0ZXN0LWNhc2U6Ci4uLgooZ2RiKSBweXRob24gaW5zbiA9IHIuaW5zdHJ1Y3Rpb25f aGlzdG9yeV5NCndhcm5pbmc6IERlY29kZSBlcnJvciAoLTIwKSBhdCBpbnN0cnVjdGlvbiAz MyAob2Zmc2V0ID0gMHgzZDZhLCBcCiAgcGMgPSAweDQwMDUwMSk6IGNvbXByZXNzZWQgcmV0 dXJuIHdpdGhvdXQgY2FsbC5eTQooZ2RiKSBGQUlMOiBnZGIucHl0aG9uL3B5LXJlY29yZC1i dHJhY2UuZXhwOiBwcmVwYXJlIHJlY29yZDogXAogIHB5dGhvbiBpbnNuID0gci5pbnN0cnVj dGlvbl9oaXN0b3J5Ci4uLgoKQWRkIGEgY29ycmVzcG9uZGluZyBYRkFJTC4KCk5vdGUgdGhh dCB0aGUgaTctMTI1MFUgaGFzIGJvdGggUGVyZm9ybWFuY2UtY29yZXMgYW5kIEVmZmljaWVu dC1jb3JlcywgYW5kIG9uCmFuIEVmZmljaWVudC1Db3JlIHRoZSB0ZXN0LWNhc2UgcnVucyB3 aXRob3V0IGFueSBwcm9ibGVtcywgc28gaWYgdGhlIHRlc3RzdWl0ZQpydW4gaXMgbm90IHBp bm5lZCB0byBhIHNwZWNpZmljIGNwdSwgdGhlIHRlc3QgbWF5IGVpdGhlciBQQVNTIG9yIFhG QUlMLgoKVGVzdGVkIG9uIHg4Nl82NC1saW51eDoKLSBvcGVuU1VTRSBMZWFwIDE1LjQgd2l0 aCBsaW51eCBrZXJuZWwgdmVyc2lvbiA1LjE0LjIxCi0gb3BlblNVU0UgVHVtYmxld2VlZCB3 aXRoIGxpbnV4IGtlcm5lbCB2ZXJzaW9uIDYuMS44CgpQUiB0ZXN0c3VpdGUvMzAwNzUKQnVn OiBodHRwczovL3NvdXJjZXdhcmUub3JnL2J1Z3ppbGxhL3Nob3dfYnVnLmNnaT9pZD0zMDA3 NQotLS0KIGdkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1yZWNvcmQtYnRyYWNlLmV4cCB8 IDQ0ICsrKysrKysrKysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA0MyBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0 aG9uL3B5LXJlY29yZC1idHJhY2UuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5 LXJlY29yZC1idHJhY2UuZXhwCmluZGV4IDU1NWI3MGFlMzM2Li43ZGViMTU3YjczYyAxMDA2 NDQKLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LXJlY29yZC1idHJhY2UuZXhw CisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1yZWNvcmQtYnRyYWNlLmV4cApA QCAtNTQsNyArNTQsNDkgQEAgd2l0aF90ZXN0X3ByZWZpeCAicHJlcGFyZSByZWNvcmQiIHsK ICAgICBnZGJfdGVzdCAicHl0aG9uIHByaW50KHIubWV0aG9kKSIgImJ0cmFjZSIKICAgICBn ZGJfdGVzdCAicHl0aG9uIHByaW50KHIuZm9ybWF0KSIgInB0fGJ0cyIKICAgICBnZGJfdGVz dCAic3RlcGkgMTAwIiAiLioiCi0gICAgZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJweXRob24gaW5z biA9IHIuaW5zdHJ1Y3Rpb25faGlzdG9yeSIKKworICAgICMgVGhlcmUncyBhIEhXIGJ1ZyBh ZmZlY3RpbmcgUHJvY2Vzc29yIFRyYWNlIG9uIHNvbWUgSW50ZWwgcHJvY2Vzc29ycy4KKyAg ICAjIFRoZSBidWcgd2FzIGV4cG9zZWQgYnkgbGludXgga2VybmVsIGNvbW1pdCA2NzA2Mzg0 NzdhZWQKKyAgICAjICgicGVyZi94ODYvaW50ZWwvcHQ6IE9wcG9ydHVuaXN0aWNhbGx5IHVz ZSBzaW5nbGUgcmFuZ2Ugb3V0cHV0IG1vZGUiKSwKKyAgICAjIGFkZGVkIGluIHZlcnNpb24g djUuNS4wLCBhbmQgd2FzIHdvcmtlZCBhcm91bmQgYnkgY29tbWl0IGNlMGQ5OThiZTkyNwor ICAgICMgKCJwZXJmL3g4Ni9pbnRlbC9wdDogRml4IHNhbXBsaW5nIHVzaW5nIHNpbmdsZSBy YW5nZSBvdXRwdXQiKSBpbiB2ZXJzaW9uCisgICAgIyA2LjEuMC4gIERldGVjdCB0aGUga2Vy bmVsIHZlcnNpb24gcmFuZ2UgZm9yIHdoaWNoIHRoZSBwcm9ibGVtIG1heQorICAgICMgbWFu aWZlc3QuCisgICAgc2V0IGhhdmVfeGZhaWwgMAorICAgIHNldCB2IFtsaW51eF9rZXJuZWxf dmVyc2lvbl0KKyAgICBpZiB7ICR2ID09IHt9IH0geworCXNldCBoYXZlX3hmYWlsIDAKKyAg ICB9IGVsc2UgeworCXNldCBoYXZlX3hmYWlsIFwKKwkgICAgW2V4cHIgW3ZlcnNpb25fY29t cGFyZSBbbGlzdCA1IDUgMF0gPD0gJHZdIFwKKwkJICYmIFt2ZXJzaW9uX2NvbXBhcmUgJHYg PCBbbGlzdCA2IDEgMF1dXQorICAgIH0KKyAgICBzZXQgeGZhaWxfcmUgXAorCVtqb2luIFwK KwkgICAgIFtsaXN0IFwKKwkJICAid2FybmluZzogRGVjb2RlIGVycm9yIFxcKC4qXFwpIGF0 IGluc3RydWN0aW9uICRkZWNpbWFsIiBcCisJCSAgIlxcKG9mZnNldCA9ICRoZXgsIHBjID0g JGhleFxcKToiIFwKKwkJICAiY29tcHJlc3NlZCByZXR1cm4gd2l0aG91dCBjYWxsXFwuIl1d CisKKyAgICBzZXQgZ290X3hmYWlsIDAKKyAgICBzZXQgY21kICJweXRob24gaW5zbiA9IHIu aW5zdHJ1Y3Rpb25faGlzdG9yeSIKKyAgICBnZGJfdGVzdF9tdWx0aXBsZSAkY21kICIiIHsK KwktcmUgIl5bc3RyaW5nX3RvX3JlZ2V4cCAkY21kXVxyXG4kOjpnZGJfcHJvbXB0ICQiIHsK KwkgICAgcGFzcyAkZ2RiX3Rlc3RfbmFtZQorCX0KKwktcmUgLXdyYXAgIiR4ZmFpbF9yZSIg eworCSAgICBpZiB7ICRoYXZlX3hmYWlsIH0geworCQl4ZmFpbCAkZ2RiX3Rlc3RfbmFtZQor CQlzZXQgZ290X3hmYWlsIDEKKwkgICAgfSBlbHNlIHsKKwkJZmFpbCAkZ2RiX3Rlc3RfbmFt ZQorCSAgICB9CisJfQorICAgIH0KKyAgICBpZiB7ICRnb3RfeGZhaWwgfSB7CisJcmV0dXJu CisgICAgfQorCiAgICAgZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJweXRob24gY2FsbCA9IHIuZnVu Y3Rpb25fY2FsbF9oaXN0b3J5IgogICAgIGdkYl90ZXN0X25vX291dHB1dCAicHl0aG9uIGkg PSBpbnNuXFswXF0iCiAgICAgZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJweXRob24gYyA9IGNhbGxc WzBcXSIKCmJhc2UtY29tbWl0OiAzN2Q3NWQ0NTUyZDZiNGQyOTJmZmI0ZGVlOTIzMjlhNDQ5 Mjg4Mzc1Ci0tIAoyLjM1LjMKCg== --------------WOpUbY7w0zGeh54dVjU2J0dn--