From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8998 invoked by alias); 14 Feb 2019 20:38:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8987 invoked by uid 89); 14 Feb 2019 20:38:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (8.8.178.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Feb 2019 20:38:08 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 1350687649; Thu, 14 Feb 2019 20:38:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 575838AB75; Thu, 14 Feb 2019 20:38:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id F1FC886AB; Thu, 14 Feb 2019 20:38:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH 00/20] Remove cleanups To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20190213212927.9474-1-tom@tromey.com> <75686c17-b637-2403-09ab-b362d85a9c04@FreeBSD.org> <875ztm4e9s.fsf@tromey.com> From: John Baldwin Openpgp: preference=signencrypt Message-ID: <2c0c044c-19c5-824e-234d-f5e63d076c85@FreeBSD.org> Date: Thu, 14 Feb 2019 20:38:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <875ztm4e9s.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 575838AB75 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.94 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.993,0]; NEURAL_HAM_SHORT(-0.95)[-0.946,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00241.txt.bz2 On 2/14/19 6:48 AM, Tom Tromey wrote: >>>>>> "John" == John Baldwin writes: > > John> The only comment I have is that the structure names for exceptions look a > John> bit awkward in code now with the mix of lower and upper case, e.g.: > > That is a good point. I think I can easily update the exception > rewriter to also rename these classes. I will take a look. Plan B is > to just have a second patch to do the renaming. I think a second pass is fine unless its trivial to re-run the script. I second Pedro's suggestion about trying 'const' as well. -- John Baldwin                                                                            Â