From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id BB53E385840F for ; Tue, 9 Jan 2024 20:29:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB53E385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB53E385840F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704832172; cv=none; b=Pp2fuGjbJcIXs6zE981M/eQgWeD6cBT6zTPsUMOtYomNPVFYOmxuM+U8vkYlaqiif5wm3ckvwcnjtdb47oNWavs/pWphX/UuZS0MCibjZSpo7IDKWxmG1SQnMn2dxPL3mbwpu7gPJ7nxPVAZxUYqPQsGU7wodssUZvDUv7/jDLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704832172; c=relaxed/simple; bh=/lBXTbKfjkVzuFw5gWpZMIQS79YbQczmvjP5lx8vwXc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fQoFwAULMRxVRZyIBayM8be89IZECHvSddGq+qpFOp5cTozPSxyYPluntBGvVaT1c1pihKnWsaas1VCbv4mLAryf2Yp3gR0A0xBeIHnMoxTu+R4j+lzqQc/m8rCBOs6ZRquTFOCtITUgEpxKSMeczyVbmdOylVNPryMlop3mqMs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1704832165; bh=/lBXTbKfjkVzuFw5gWpZMIQS79YbQczmvjP5lx8vwXc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Z0lxM/Qbcw+B1IL+hT3uRxL7kBlbmE6zT4k7E82F9n5apa2MpVy/hxwkGFj2DzbjG jAmpJeFuDrUOJ5u35WRIG3rSQGCFSetemmWDVJJUUglqVovTUoN6e8Wb+5hnbjJm2o QgSuY95gR2iPnbOTi+jxs8s64FkRu+st+q1NXQyk= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 483D01E0B9; Tue, 9 Jan 2024 15:29:25 -0500 (EST) Message-ID: <2c2cf36a-f274-4940-882c-4935aa38f2e9@simark.ca> Date: Tue, 9 Jan 2024 15:29:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix ASAN failure in DWO code Content-Language: fr To: Tom Tromey , gdb-patches@sourceware.org References: <20240109195143.291756-1-tom@tromey.com> From: Simon Marchi In-Reply-To: <20240109195143.291756-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/9/24 14:51, Tom Tromey wrote: > Simon pointed out that my recent change to the DWO code caused a > failure in ASAN testing. > > The bug here was I updated the code to use a different search type in > the hash table; but then did not change the search code to use > htab_find_slot_with_hash. > > Note that this bug would not be possible with my type-safe hash table > series, hint, hint. I tested it locally, it seems fine to me. Approved-By: Simon Marchi Simon