From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2065.outbound.protection.outlook.com [40.107.21.65]) by sourceware.org (Postfix) with ESMTPS id BDE163858C98 for ; Thu, 4 Apr 2024 14:18:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDE163858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BDE163858C98 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.21.65 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712240292; cv=pass; b=eDmhcwWHoI113Cluz1HVuHv+kmvvpVTn8s/+zBYpSDvmW3PR4fj1K8OF2Vi4URBuMdw+9WTsOLpk5KH54wjkUB7JDOIFe0TfOXdHRSve2WhAcG824MHe+QUptovwi6LVoj4oRXobX/0kkH2la+L7pFYfoT2PAji4sjTUJhg3LO0= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712240292; c=relaxed/simple; bh=6Kl+zPpv3sIiBXJ/aesUJxR8SErVlJChUH/WV0lKiA4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=FLJ3CsawA7lpu2pTixb6pRR7D4jQ5zXvcdI2F8qrcP/P7xEpkOftde8oE54UgChn/plOQn5l4hysP8CWavctMZcavFrRzSzxPHHgm+yFC4CYbmDVnhMYkpxAmLXtV7prkXB8bL4iSWc70IutfVBiUlORemA+gPozr2JdnfKXa8c= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NtzygK+WRtRFEVen/6/zM/osXb6aJmLgP8HAAYGpogiRruGnqAXtXP0r9udWm1gMA9y5EhAXjGyTIVSyM5gYNgH0lugn/tPzgmFa9nxp/dF5UuUW3ZJf5ixJpR7Jzv6Zwrt6JeP9VqkXL+coaNIeNOoG6OB8rCE6Hs+m0CxitvCi9EMr7km825hYrwucLllPKqRymbbXHzA5nmemVvQ95P/HdUguPaeMEIqc4GbF8sSFvClfT0795no2zVrnpHUZLivriRdnGamfl8fxpmbpyqXObJfVs/OkjQ9+v0T3KKv/kIZF62Q159nsnUGupZ3fdboLgGDM9g7cD9a+Luauhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rdLdw3hKOLZyH/UIfPbvkFvUk3SoY8+WYwp1tLrx4mQ=; b=cOXRpAIKYawhryG2tNQ83EApY3+OlIFHUZ8lZOvah/67C6r3hOM6RgLoKaXvLPbpoYDIkxeBz9jqZYcTRhymwMqzAfEbYJkY0bE+a/U2Mi7Wrsgl4Gu4MMuEC/jFm5SxR/S3rDYHY/THXlNuvn6x+eCqOixicAvJSSWWwNft0eEdMviz4no92MVZTN2ZhbCXZiSk3pYSm7B4G7J30wjPYXR6tVHVcWWKG2cX8fof1SMhE09XtPBEtY0NAhWfieDCWx4Y+Mbb7YjKkD1vS8mRKal3HAQH7hHfdbs9t/uanBaSTCKdoKDGrJKRWgRru+uOWqmnP5twwOAlmJzi+3eL+Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rdLdw3hKOLZyH/UIfPbvkFvUk3SoY8+WYwp1tLrx4mQ=; b=nZVGaJri01/IDBnU3SY/lpo8xIB6iisRFAg5TN2EW+LZN1nLARN2B1qmsPw/bPWt1kWstnd3HOWL7DrHHPqSJm8GHjX1GDL06L0RAquu2esO8Hvy6UkTqOKBce7jPGEIHCNtW1HL6XB/w8iASIGytK5SyWsCeQnXpKi0WrPynhs= Received: from AS9PR01CA0019.eurprd01.prod.exchangelabs.com (2603:10a6:20b:540::21) by PAVPR08MB9652.eurprd08.prod.outlook.com (2603:10a6:102:31c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 14:18:06 +0000 Received: from AMS0EPF000001A3.eurprd05.prod.outlook.com (2603:10a6:20b:540:cafe::2a) by AS9PR01CA0019.outlook.office365.com (2603:10a6:20b:540::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.40 via Frontend Transport; Thu, 4 Apr 2024 14:18:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF000001A3.mail.protection.outlook.com (10.167.16.228) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Thu, 4 Apr 2024 14:18:04 +0000 Received: ("Tessian outbound dc0a9029eb2c:v300"); Thu, 04 Apr 2024 14:18:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1e39d0b4334614e3 X-CR-MTA-TID: 64aa7808 Received: from 522da0471d37.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EBB73EF6-B3E1-420F-928A-538ED10914E8.1; Thu, 04 Apr 2024 14:17:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 522da0471d37.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 04 Apr 2024 14:17:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+sgdZXjGrWrAe9NCmVQae751gNVhD0cZk0bKNmJZ5IVngqv3n6fa5RjUywT9I8jA4Dv/IHyvM2uUQSkUPNwhFkyful3XDWsW6qbdjYeptdLJ5eRYTMWuY9Zc2HWc6DLLfkm6opEuGYzHvzQrIxF5lstFkr1BCvJim6qjP+pjFlx299io3CQTno6x4yCR2ozAoVZcVJTCkJkw13wwMzYmVDV1TJOL9KtHgp3nUyfekPnj3+y2Z21HRKQ1KcS6D/rHpR6H5fsi4HrymcsoiYB5mFWNV21mW8/erGj3VjPWyyI6FA4ygEvY+5a8pm4rTmqLWGY3EId2fAIrTMm9fgNgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rdLdw3hKOLZyH/UIfPbvkFvUk3SoY8+WYwp1tLrx4mQ=; b=Uk475CddIu1wUHr6im5g2JqdCCJP5SbESaHwPU2IEJGYp3hG6bKOkQAmdlVxoDdTR3OG3bp4DTvb5Ttnt4CW5goZ+PvMkvPdQcDPs0bpdZiAEQSsJd3rd9g/AQWqOf2w6r7PtgssdHhW85A55+NndJl0zmNVBwOf7Xw5IVmUOt6lC12iiSJgEk79K0vxPDPr3i3cFVl7j0Pv3uWJ259gB/DnAK07PfIPus50D2hzdRU7qi3K7/Sfivhz1O+PX4988ov73fg4f2fPSW4LfMzcDN66unz8Qg7A4VeFKCYA137kBlV8/Nb33HWnlAKKb5h/4sw6bS/zebtG2VqHf6A/Hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rdLdw3hKOLZyH/UIfPbvkFvUk3SoY8+WYwp1tLrx4mQ=; b=nZVGaJri01/IDBnU3SY/lpo8xIB6iisRFAg5TN2EW+LZN1nLARN2B1qmsPw/bPWt1kWstnd3HOWL7DrHHPqSJm8GHjX1GDL06L0RAquu2esO8Hvy6UkTqOKBce7jPGEIHCNtW1HL6XB/w8iASIGytK5SyWsCeQnXpKi0WrPynhs= Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DU0PR08MB10358.eurprd08.prod.outlook.com (2603:10a6:10:415::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 14:17:55 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed%5]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 14:17:55 +0000 Message-ID: <2c3d0482-b3cb-4a23-8d9b-2df179f83281@arm.com> Date: Thu, 4 Apr 2024 15:17:53 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/7] gdb: aarch64: Move MTE address check out of set_memtag Content-Language: en-US To: Gustavo Romero , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20240404064819.2848899-1-gustavo.romero@linaro.org> <20240404064819.2848899-3-gustavo.romero@linaro.org> From: Luis Machado In-Reply-To: <20240404064819.2848899-3-gustavo.romero@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0024.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::19) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DU0PR08MB10358:EE_|AMS0EPF000001A3:EE_|PAVPR08MB9652:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Rk5I1jdmip9Ael/c0fooeV33aHQMSXe3jE6IxFOQNsq7kZGF2TW05k+cOB/lrC8D/Nv7LPhBAxcGJz8SUxGpA3dAfYos3rKoGG20LCmTnHPILrwfAE380ALx52Zt1OkJ8fNRC8TJM2AJ/YVbMMYWQ7juXg/E02nS7zD785BpI0CyVTlZVXPV/tnnSzLd997/Yae/YVRwOcnlpfl4ZW3oR+4Mhg74/sDJNUwlCV98WPj9CyDZXsJvHFGpqYLsNBHIjDA2xT2hX2Zz7P0n/El5R4dGZjgFqV93QIRSGYC+xW2NBl/18vQQaF9WOYb5E74XmpKFLoVR8FVbozivWZh7oAUZWtg3Re42+874sLWWDZ6WoVzFkQTV+oquE9V1rxCkvsvXY5h9IS9upcudXg3m7pSKv/w3+zbENU/NErvuy15sDi06Rm6/GLdV4TqNXCb93I6GREIuFMzqNSgYjdZ/J8iVWBdYBNeBxIEsGE7wkWHfFV63Mv/eFsKgs3JpsGtaBKwFiYI5J+EeYbC9KwVX1tBaPSUODJuF5kStBwhzSwHUaWe3FnkE41pzvXm2MbKkPccq8dLdcetEVoI+fmUBlV4ZE1NAxqQ/XTUW+xB7ZbOyfiFjtxlHCedLdOyPAstsuU+LvQM7pNlCpVV92et+d69FMg9eY/Jb6zR1yudDIYc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB10358 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001A3.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f4a2645-78d0-4324-95f7-08dc54b20b24 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O/ZwHhvWosBK65uD7ajQR05D9+rulDAngaqJeqEvQ0nYf6yCsYA8QNfWcUfG1jkYHmCN3Js3louW2UMgYRuZ+nVVSh/5qFGYBzJx/vOts3TGgKmxbPZONbh4XqdV7zXMH7U8Qbj3FDeyYJzpsPLNRpA1WIdGkQyho7Wp7ykeoxgqBDmaKmwlgEKd6AWxn7aMGubg1Sm3wgPGEjHyuu8BPCq8Hzrq4u9bB8wUC2GhnlFvQCvbBGsGUliGJyiucvkSV/u6GEbhB5Tt6EZh236DTdWNvIP/trr4l7dUoULwADaTP3SUWwkrPLyVamm3H/18cg8lPf+4Djp1eugWA37U/oxN5oMKJqQekMZ2x4OZEd+zgUL8eR/EJenkd86xMNsYW6Ld2fgvl46rKr6IHkeldIC/IPz1y5jwga6lwB5wGJyWetRqEnvFoGLPkRYqRoZxj7gbosEJOo/dF7AGeHNFjibRiiyzNxYgHygz+qwGkVVngGhLs01H5V3cQZkY/VjfHTo3HSBwpT35ScoQJzFcUNp5frXbPy3d8UKyNtTiQNdydBZlsJAgcGKoBKdhnB1gm7HVstZGcookCoEa+R6u0f4BFflUQwfYjU6FP0NHStNmgIoM5CzWIlwjHnmiBAGAukqG091vKmgYn8+y16emfpcHXX77HT9Bg7Bxti9DBjq4s7gSyaKuAPRGoWH5NKiiJQfhd7c992rJ50x+AOHpMjxi2WJTAP4kdzkSDX4uUlmefQyScR4TOqbGT9aFMZAt X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 14:18:04.7000 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f4a2645-78d0-4324-95f7-08dc54b20b24 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A3.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9652 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/4/24 07:48, Gustavo Romero wrote: > Move MTE address check out of set_memtag and add this check to the > upper layer, before set_memtag is called. This is a preparation for > using a target hook instead of a gdbarch hook MTE address checks. > > Signed-off-by: Gustavo Romero > --- > gdb/aarch64-linux-tdep.c | 4 ---- > gdb/printcmd.c | 5 +++++ > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c > index 50055ac3f48..8e6e63d4dcb 100644 > --- a/gdb/aarch64-linux-tdep.c > +++ b/gdb/aarch64-linux-tdep.c > @@ -2525,10 +2525,6 @@ aarch64_linux_set_memtags (struct gdbarch *gdbarch, struct value *address, > /* Remove the top byte. */ > addr = gdbarch_remove_non_address_bits (gdbarch, addr); > > - /* Make sure we are dealing with a tagged address to begin with. */ > - if (!aarch64_linux_tagged_address_p (gdbarch, address)) > - return false; > - > /* With G being the number of tag granules and N the number of tags > passed in, we can have the following cases: > > diff --git a/gdb/printcmd.c b/gdb/printcmd.c > index cb0d32aa4bc..774e3ec74ae 100644 > --- a/gdb/printcmd.c > +++ b/gdb/printcmd.c > @@ -3127,6 +3127,11 @@ memory_tag_set_allocation_tag_command (const char *args, int from_tty) > /* Parse the input. */ > parse_set_allocation_tag_input (args, &val, &length, tags); > > + /* If the address is not in a region memory mapped with a memory tagging A nit: s/memory mapped/memory-mapped ? > + flag, it is no use trying to manipulate its allocation tag. */ > + if (!gdbarch_tagged_address_p (current_inferior ()->arch (), val)) > + show_addr_not_tagged (value_as_address(val)); > + Looks like memory_tag_set_allocation_tag_command calls parse_set_allocation_tag_input, and the latter has the exact same check as you are adding here. Is this then redundant? > if (!gdbarch_set_memtags (current_inferior ()->arch (), val, length, tags, > memtag_type::allocation)) > gdb_printf (_("Could not update the allocation tag(s).\n"));