From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 811913857420 for ; Wed, 2 Nov 2022 14:56:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 811913857420 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 125571E0D3; Wed, 2 Nov 2022 10:56:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1667400979; bh=W5gW5a4pq9d8gWSuEU+bHLV6M3y3DSdttLq0uFaT1lE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=L4KmI9ZYeLJlrAdwdDMlbF2dpFLVNHL6q7cqWN34y5aZD+4HKxQJgqtwTMYsQ7ntm BIcC2XdskinQjSvbUIkbiQfE07chMMvMqOC/PeLrb/0s96R+wmhHEkDg90lkRVIMIr 47u90WWSC8LZP+tBKoiwqL/O2EAb1HRASwtMRF/U= Message-ID: <2c4aba2a-f30b-d73c-2988-d76c18849226@simark.ca> Date: Wed, 2 Nov 2022 10:56:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] gdb: new $_inferior_threads convenience variable Content-Language: fr To: Andrew Burgess , gdb-patches@sourceware.org References: <20221102143416.3307157-1-aburgess@redhat.com> From: Simon Marchi In-Reply-To: <20221102143416.3307157-1-aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/2/22 10:34, Andrew Burgess via Gdb-patches wrote: > Add a new convenience variable $_inferior_threads that contains the > number of (non-exited) threads in the current inferior. This can be > used in command scripts, or breakpoint conditions, etc to adjust the > behaviour for multi-threaded inferiors. I don't really have time to look at the code, but here's a naming nit: I think the name should contain "number" or "count" or something like that. The name "_inferior_threads" makes me think it yields a list of threads, somehow. Simon