From: Pedro Alves <palves@redhat.com>
To: Markus Metzger <markus.t.metzger@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/7] improve btrace enable error reporting
Date: Tue, 06 Feb 2018 16:28:00 -0000 [thread overview]
Message-ID: <2c57146a-7111-4381-3851-bd1ff4d610b9@redhat.com> (raw)
In-Reply-To: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com>
Hi Markus,
On 01/26/2018 02:14 PM, Markus Metzger wrote:
> Recording may fail for a variety of reasons. Improve the error
> messages by stating more clearly what operation failed and try to give
> a reason why it failed.
>
> Further align the error messages for native and remote debugging.
>
> Changes to v1:
> - move helper classes into gdb/common/
> - add unit tests for helpers
> - simplify helpers
>
> Markus Metzger (7):
> common: add scoped_fd
> common: add scoped_mmap
> btrace: prepare for throwing exceptions when enabling btrace
> btrace, gdbserver: use exceptions to convey btrace enable/disable
> errors
> btrace, gdbserver: remove the to_supports_btrace target method
> btrace: improve enable error messages
> btrace: check perf_event_paranoid
This LGTM, though I have a couple questions, and a nit.
#1 - Where does this leave up wrt to:
'old gdb' x 'new gdbserver'
and
'new gdb' x 'old gdbserver'
?
#2 - Where we now say
+ error (_("GDB does not support Intel PT."));
(and similarly for BTS)
shouldn't that say something like "_This_ GDB does not",
so that the user can tell that it's a matter of that
particular build of gdb, not that GDB-the-project is lacking
support for PT?
#3 - in patch 7:
Instead of:
const char *filename = "/proc/sys/kernel/perf_event_paranoid";
write:
static const char filename[] = ...;
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-02-06 16:28 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 14:14 Markus Metzger
2018-01-26 14:14 ` [PATCH v2 6/7] btrace: improve enable error messages Markus Metzger
2018-01-26 14:14 ` [PATCH v2 2/7] common: add scoped_mmap Markus Metzger
2018-01-26 14:14 ` [PATCH v2 1/7] common: add scoped_fd Markus Metzger
2018-02-13 16:48 ` Yao Qi
2018-02-13 17:28 ` Metzger, Markus T
2018-02-14 15:22 ` Yao Qi
2018-02-14 17:26 ` Metzger, Markus T
2018-02-19 15:28 ` Metzger, Markus T
2018-02-19 15:46 ` Eli Zaretskii
2018-02-20 10:12 ` Yao Qi
2018-02-20 10:46 ` Metzger, Markus T
2018-02-20 11:09 ` Yao Qi
2018-02-20 13:16 ` Metzger, Markus T
2018-01-26 14:14 ` [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace target method Markus Metzger
2018-02-24 16:51 ` Maciej W. Rozycki
2018-02-26 13:08 ` Metzger, Markus T
2018-02-26 19:30 ` Andreas Arnez
2018-02-26 21:58 ` Maciej W. Rozycki
2018-02-27 10:57 ` Metzger, Markus T
2018-02-27 15:32 ` Maciej W. Rozycki
2018-02-27 18:14 ` Metzger, Markus T
2018-02-28 10:29 ` Maciej W. Rozycki
2018-02-28 11:09 ` Maciej W. Rozycki
2018-02-28 11:24 ` Metzger, Markus T
2018-02-28 12:53 ` Metzger, Markus T
2018-02-28 15:55 ` Maciej W. Rozycki
2018-02-28 16:08 ` Eli Zaretskii
2018-02-28 12:00 ` Yao Qi
2018-02-28 16:27 ` Sergio Durigan Junior
2018-03-01 11:33 ` Metzger, Markus T
2018-03-01 19:27 ` Sergio Durigan Junior
2018-03-05 12:14 ` Yao Qi
2018-03-05 16:13 ` Sergio Durigan Junior
2018-03-06 9:02 ` Yao Qi
2018-03-06 16:32 ` Sergio Durigan Junior
2018-03-01 19:34 ` Maciej W. Rozycki
2018-01-26 14:14 ` [PATCH v2 3/7] btrace: prepare for throwing exceptions when enabling btrace Markus Metzger
2018-01-26 14:14 ` [PATCH v2 4/7] btrace, gdbserver: use exceptions to convey btrace enable/disable errors Markus Metzger
2018-01-26 14:14 ` [PATCH v2 7/7] btrace: check perf_event_paranoid Markus Metzger
2018-02-06 16:28 ` Pedro Alves [this message]
2018-02-07 10:41 ` [PATCH v2 0/7] improve btrace enable error reporting Metzger, Markus T
2018-02-07 12:11 ` Pedro Alves
2018-02-08 10:40 ` Metzger, Markus T
2018-02-08 13:01 ` Pedro Alves
2018-02-08 13:49 ` Metzger, Markus T
2018-02-08 14:24 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c57146a-7111-4381-3851-bd1ff4d610b9@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).