From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by sourceware.org (Postfix) with ESMTPS id B85993858D32 for ; Mon, 27 Feb 2023 16:18:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B85993858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f41.google.com with SMTP id m14-20020a7bce0e000000b003e00c739ce4so4165903wmc.5 for ; Mon, 27 Feb 2023 08:18:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=92TwQcN7Y71S64dJ35imyRViL3u1zk8E+TRNLPLmWkk=; b=CvyQOjBjgq1/rP8d8+rVvZaVXtHU6fjDvDco9FeLhRB0BTPlNffXTmzvRmHFgunOLa URY9lTGVu2d0IDOXHq2QiFG49KJ932xuOZNE5Ow6eYpAgcM/qSsnH/n6zQL5uyo3ByKC OXzquW0GbMWG2Gfu09oyDzAsmyeu7tnnemxaEVkm2AYm3RA3z+5xKR6KzGOOwSXUK6Tp mWBhaOQir06Kji56LBgKLUnDRorh0Wm+ntmhvRvawhTBBq1mHvDtXqY0vjkXG9vMtNIo vjphCJtiXU+fq9H8heRakeStzTA61icfe/Y2Dafp54jkazljlaCQJdDsiXplJ4XiFI5I ileQ== X-Gm-Message-State: AO0yUKU9J58uMrofdu7+i+mATv1eo8Huhe2NxfCnM25LFG0sDttFKjgr kfZaOrA7NGdptTIcxVJkP1uq7Us1LzuILA== X-Google-Smtp-Source: AK7set8aLk5JcT9ri2L4WXQmPis29P/LoIuJ0k19PWdES57N5ooO353pK1uayfP2BToPqycjmfdCJg== X-Received: by 2002:a05:600c:3089:b0:3eb:29fe:fe19 with SMTP id g9-20020a05600c308900b003eb29fefe19mr8605463wmn.34.1677514727275; Mon, 27 Feb 2023 08:18:47 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id t10-20020a05600c128a00b003dfee43863fsm13006418wmd.26.2023.02.27.08.18.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 08:18:46 -0800 (PST) Subject: Re: [PATCH 6/8] gdb/testsuite: introduce is_target_non_stop helper proc To: Andrew Burgess , gdb-patches@sourceware.org References: <98e235a0c825ab2207eb98a088169f5f32e1ef6a.1676901929.git.aburgess@redhat.com> <87ttz7i28m.fsf@redhat.com> From: Pedro Alves Message-ID: <2c72a526-1dd0-497b-6dd5-241b42fe172f@palves.net> Date: Mon, 27 Feb 2023 16:18:48 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87ttz7i28m.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-02-27 2:58 p.m., Andrew Burgess wrote: >> The original code was written that way so that we'd only skip >> the remainder of the tests if we're absolutely sure they >> wouldn't work. If the maint command failed for some reason, we >> don't know that, so we continue with the testcase. >> >> I think that for a refactoring patch, that detail shouldn't be >> changed. > > Thanks for the feedback. How's the patch below? The only change is in > testsuite/lib/gdb.exp, everything else is the same as before. LGTM.