public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>,
	       Jerome Guitton <guitton@adacore.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] candidates for ambiguous command in upper case
Date: Tue, 10 Jan 2017 17:00:00 -0000	[thread overview]
Message-ID: <2c7e674b-e827-f433-cbaf-a3d1a20cba80@redhat.com> (raw)
In-Reply-To: <ee9212f7e0041953919f60df47699efa@polymtl.ca>

On 01/10/2017 03:28 PM, Simon Marchi wrote:
> On 2017-01-10 10:19, Jerome Guitton wrote:
>> Yao Qi (qiyaoltc@gmail.com):
>>
>>> IMO, there is nothing wrong.  There is no command starts from "EX".
>>
>> This is a bit weird to accept upper-case EXEC-FIL then... isn't it?
>>
>> (gdb) exec-fil
>> No executable file now.
>> (gdb) EXEC-FIL
>> No executable file now.
> 
> I agree that if GDB accepts commands in upper case, the ambiguous
> command message should work accordingly.

Agreed.  I thought that the manual mentioned that gdb accepts
commands in either case, but I can't find it now.

> The message as it is, with an empty list, doesn't make sense.
> 
> I also noticed that tab completion was case sensitive, should that be
> fixed as well?
> 
> For example,
> 
>   (gdb) inf<tab><tab>
> 
> shows "inferior  info", but
> 
>   (gdb) INF<tab><tab>
> 
> shows nothing.  Should it show "inferior  info", or "INFERIOR INFO"?

I think the former.  I.e., show the canonical lowercase.  That
is likely to end up much easier and saner to implement.

I've been playing with completion recently [1], and I've noticed
that

 (gdb) handle sigu<tab>

completes to:

 (gdb) handle SIGU<bell>

 (gdb) handle sig<tab>

Or really:

 (gdb) handle sigu M-?
 SIGURG   SIGUSR1  SIGUSR2  

In my branch I've completely changed how GDB hands over
completion matches to readline, and I've had to make
sure to preserve that behavior, as caught by some test.

[1] - this WIP branch gets rid of the need to quote
      linespecs as in "b 'function(int<tab>" among other things:

  https://github.com/palves/gdb/commits/palves/cp-linespec

Thanks,
Pedro Alves

  parent reply	other threads:[~2017-01-10 17:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 14:25 Jerome Guitton
2017-01-10 15:07 ` Yao Qi
2017-01-10 15:19   ` Jerome Guitton
2017-01-10 15:28     ` Simon Marchi
2017-01-10 15:40       ` Jerome Guitton
2017-01-10 17:00       ` Pedro Alves [this message]
2017-01-11 15:37         ` Jerome Guitton
2017-01-11 17:26         ` Yao Qi
2017-01-11 17:35           ` Luis Machado
2017-01-11 20:24           ` Pedro Alves
2017-01-12 10:18             ` Jerome Guitton
2017-01-12 16:37               ` Pedro Alves
2017-01-16 16:32                 ` Jerome Guitton
2017-01-17  1:58                   ` Pedro Alves
2017-01-17 16:29                     ` Luis Machado
2017-01-17 16:35                       ` Pedro Alves
2017-01-17 16:51                         ` Luis Machado
2017-01-17 17:04                           ` Pedro Alves
2017-01-17 17:13                             ` Luis Machado
2017-01-31 14:39                       ` Jerome Guitton
2017-01-31 15:20                         ` Pedro Alves
2017-02-08 18:05                           ` Jerome Guitton
2017-07-24 21:17                             ` Simon Marchi
2017-07-24 21:48                               ` [PATCH] define_command: Don't convert command name to lower case Simon Marchi
2017-07-24 21:54                                 ` Simon Marchi
2017-08-28 21:20                                   ` Simon Marchi
2017-07-26 12:42                                 ` Jerome Guitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c7e674b-e827-f433-cbaf-a3d1a20cba80@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guitton@adacore.com \
    --cc=qiyaoltc@gmail.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).