From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123510 invoked by alias); 14 Jul 2018 01:16:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123370 invoked by uid 89); 14 Jul 2018 01:16:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 14 Jul 2018 01:16:54 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 32AF11E48F; Fri, 13 Jul 2018 21:16:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531531012; bh=gdijiHOlAq1bQhss5X40kwuivIihr2YN9dwmA7DwI3U=; h=Subject:To:References:From:Date:In-Reply-To:From; b=VfqMzXgvEdeBV0QDx7Tc1Ms6TXVyXZ4VGdmy8RosAi2iYWUv02byJ6Azn20ekD6+H VKRZiyHK7tUsKEecPD6bAVSDIt+MfmrMI/l7hzO8WODxm+8UQnnMdX+XSf74FOTTkk 5qyzZXJV5IA74jR9jLEGOCnmlAxJdq8tcry4p2ww= Subject: Re: [RFA 02/13] Unused variable fixes related to conditional compilation To: Tom Tromey , gdb-patches@sourceware.org References: <20180712205208.32646-1-tom@tromey.com> <20180712205208.32646-3-tom@tromey.com> From: Simon Marchi Message-ID: <2ca3e97a-2d06-ac81-c992-40a9bfd2740e@simark.ca> Date: Sat, 14 Jul 2018 01:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180712205208.32646-3-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00438.txt.bz2 On 2018-07-12 04:51 PM, Tom Tromey wrote: > This patch fixes various unused variable warnings that are related to > conditional compilation. In these cases, either the variable is now > protected by the same #if as its uses, or the declaration is simply > lowered into the conditionally-compiled block. This LGTM. Simon