From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2045.outbound.protection.outlook.com [40.107.237.45]) by sourceware.org (Postfix) with ESMTPS id 4B2F73857C70 for ; Mon, 1 Nov 2021 16:02:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B2F73857C70 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iyMvkPRndk+pp1VwGryaZnB3WreihsMMYPhvQ0nHaBFw+m3ug9PhgcF6zKd7zS6WNELAyjZAeLhiAnHTX+4aV4CgFWCgSZCBOKZ696fv2Gc68Y8k2NcdzS+sLelRPWf80epbsfwaFDmH8AvuSNFsq5rO/Q4vTRTXmNKJ+y91KHB0fr7vWvhCqFJVSrIDkHBf0abrVsL0UaPBcyu9RzyYmpC8XMBWRkh1S7rMNdjJjwZLy55gnvNg0TVDKL409hIzyqrUpmakLWQ91gSWco+5iNFedOVPj+NmR+0PEgMwFY+JJTk+qInY9P4u5g4tl6L7llpNEPxKGQ4dgkpxG5yIIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=92nUXBnkkL0SY7UXiYZuXfBfrwUsUCE8U3tT8H0QOhQ=; b=Yr7leJjBtmxjGNgF7fiuulgzKH5OQjdnr7Cj/GKWbp12K+fqb4OvQkSRwJS+oPkePtJLi5wBfYOVdes8P+ilSrkWwZeDmLZMg6kNVt0zSiXod9TdbEokCI1AnVYd/uahhfUlMrkGx5xbS/mZjlmGhOSxu6XF0KPuFxi7lFUPO7XwoaTks6N+tENXWiswOzQ9+CdxQtDJz4yLNS3WHIV6Yl8CrTOd87Fs6PCBHLuFLTDNO4FaHmMWk+LWCUW1/F+XxEF7q9k9CdolrvP+tmsOterYL6gjiFzTlDPVjvgkA09ND4JijoMIeYVq+eYoTc6LOf4fMBu06eqE/+Uwz7tJRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) by BN9PR12MB5324.namprd12.prod.outlook.com (2603:10b6:408:105::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Mon, 1 Nov 2021 16:02:01 +0000 Received: from BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::f908:e014:a94:a35]) by BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::f908:e014:a94:a35%5]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 16:02:01 +0000 Subject: Re: [PATCH v3 04/28] Add to_location method to DWARF entry classes To: Simon Marchi , Lancelot SIX Cc: gdb-patches@sourceware.org References: <20211014093235.69756-1-zoran.zaric@amd.com> <20211014093235.69756-5-zoran.zaric@amd.com> <20211022212054.jzoa2vhrdq4pl2yi@ubuntu.lan> From: Zoran Zaric Message-ID: <2ce119d1-3cb8-cf73-555c-623a190f9e8a@amd.com> Date: Mon, 1 Nov 2021 16:01:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:20b:48b::20) To BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) MIME-Version: 1.0 Received: from [IPv6:2a00:23c7:1093:6301:28e8:5ece:e307:7c2] (2a00:23c7:1093:6301:28e8:5ece:e307:7c2) by AS9PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:20b:48b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Mon, 1 Nov 2021 16:02:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ebf952b5-6716-43c4-d43b-08d99d50f084 X-MS-TrafficTypeDiagnostic: BN9PR12MB5324: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ud//XIOgwPnT/TWwmo1Od6CLLVIxvCL+aSrEtGIwFASlKi1Rzz5NhZ4rpORhD2Wyhx9ZgY1tpXgZp2foaqS7KbbVehuyhBYjw78b23rp+8u+kyi0L/LuU09SfPt+i9qY2inzO2veWUfjUyLmK3/NTtEBRhScZXIIqDOvWapumtGp5JxRoZ2b5GZO4LFnORkX2sVMjyGUyhgl7sYw/y0PRMYnMLpaXE/T9ACPM1Uyb2ppHp/NIphBfzM175PuF4Q6ma4sOx7wNCIslBqZKvh7psO5wFccpL9dF+gGzoC/+u3pWVGuvLVeypdFPAfg+hARBptIM8DB7tR6hDdgOircRAhyrrbFaAkiieN8lUj0iGSbfrKdshmwsFemih5xN7YCnst0SPHNK2ILG1O8ko6P3mqEYYcpTalKoH/07idfxsBvtzNVlf3tsg/s8h55yJtbvZVWnG83N+HtbrW60W+Sd7TuQbvzPVFxem5xzC005ufpcyWXBxuNbcdy2ZAnlRk4CR8EEcwVJgL4Lx6R0cUrQQFa2VKe/fh2twpXZXhoomP9EKBGURwIH58/irN/OvdfipRYkI9VUAlxIW8azIJB3d91o0RtPyRGfhiLRIiNVVm/6cDsy0uJRmOOn3QA1pyMnECL6ZR522QWYYcHCI3BATiBLLqbV/QdkiGg2TFHn3Us4bzUvXIi8EAri+sdwqmZ8wdNNWANBqpWfpr3RiHIo9fy7q7Rr5QBXHAAVs9KCI6JHcqmocnIsRVeuPFkkznD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5065.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(86362001)(66946007)(6666004)(110136005)(8676002)(66556008)(66476007)(31686004)(38100700002)(8936002)(53546011)(186003)(36756003)(6486002)(31696002)(5660300002)(2616005)(83380400001)(44832011)(2906002)(316002)(4326008)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2JtaGJYemhGdE40azNXNmlUZEdvNkpxMFlPRTZnbGJaOWNBem9LMUxSL3pF?= =?utf-8?B?cE10ci9NU1plUzFUcXdjQi9tdWtKbGZmbEo0ZmxWaXpEMktha1JuV0t3YVRX?= =?utf-8?B?QkdUekdwRXhWWVlGQkdZaW9LbU5OWnArL2VyMzl2bDJtT1NKMTYxOU5SdWRX?= =?utf-8?B?L1pLYjl0VmxqREUrTWVlNzN1clBvQ2EvSFFlMTliOXBUWXV2QzMrVmJSZFRK?= =?utf-8?B?SnVMOFdUQXNpbHdkeDFDMytOalE2eFNrU2JySGYwaU9qKzZJTDZMTU4yUTQ1?= =?utf-8?B?YWN4b01aMDgwdWxhMjRocGtlNEc2MlhmOS9QNXJJS0dwa3J0ZlB5Q1FtaWNL?= =?utf-8?B?a2xTK0xXYW11N1pDN0F0aEtVN1N1VzJNZ1prTVBkdzVnMmdWQ1E2WHY2V0NQ?= =?utf-8?B?aWk4dkZSZUdZN1Q0bGx1SjNnaTlzNzRELzBSSmhZNExkVkdKOTltRVU0UVJ2?= =?utf-8?B?Z0FuT2dkZzJuQ2JNTnUvVHB5emVYait1U3lLMHZmQTZ1TUQ0eWxXbFh5alhq?= =?utf-8?B?MDBFTXZiQi92UStaYTZnSHBOSXN1K2xLU0ppRzVLb012RkYvTVh5NnJNYW9J?= =?utf-8?B?ajBrMzVQRzRqRnh3SERmbW0xVTlMaGhvNlRMZ0RQdm9MWmpZZW1XY2xHWTFO?= =?utf-8?B?eWNPaXVETzArbUJtYW1zdGlocDcwcjlpZUJpNTJkeVpSYjQrVmJ2YllNYXNL?= =?utf-8?B?UCtnaDZpb3RRa0hxRUt3QUlwWHBtekpKa3V5blZjR1QrbDlHU085VlpSZ3JO?= =?utf-8?B?T3Bxbks4SjlnUGgzbVcvRGF0cjh6ejYzZytGYmt4cGl2ZkZYMlVVMG5TWG9v?= =?utf-8?B?RVVYMFFTQjJlb2Q2TkFvZFZoNUZ0ZkVNVGhyVEd5WDArei9xV24wNUIrQU94?= =?utf-8?B?NWJFTFNiaGs0dC82NnZMbmJER0VKSGFZZFkyb2VlOUpHU1JUZ25DbEttcE0w?= =?utf-8?B?UFF1bFQ1SVJwTytJRGV2cVlybVJIK2Fvd1BBWGhDblBZNlZDRmVmaWliZFZi?= =?utf-8?B?cGxpVW4yZ1lXVngzQ1lEeGczUnlnV3N1WkJRaml5RTIxdFRXaXNFM2RjcmUz?= =?utf-8?B?d3pENzVsUjdXRzg4MG5USTdQbjFtTXB6YWFRRE5adElvU0J4bTk4YVZHK2Ja?= =?utf-8?B?ZGU0cGVEUVQwSWJiak5ZSTFLeWFIWHJuMjBoYnFiczdkbjdHQ1E3aSt0b0Y3?= =?utf-8?B?NnNuM1RjaUpCQ1NscUFJYVdVRWNYMEZsUnc5aVMzU3dabnNUWGx4c29tMUZK?= =?utf-8?B?dW9oU2FDeG5YT01vR01GdFhCL29BSVdUTUtrM0hDQVBwUEFWM3lqZXE1NG5O?= =?utf-8?B?Y01qRzIvdlV2R2lzYVZ1MDhVTU1QcTNSODNXdUxKQlNEdFJZMEx6MjRLeFFE?= =?utf-8?B?cFlZOHpvQ09SbkRubjZuOGcwcW9ka3BHSElickhST09VRGJuR0lEWnB0dG5P?= =?utf-8?B?T2tNUFhWVzVacUxxY0llSHh0dlcvWHBPWE9kOU5HbUJoTVJBb25jTjkvcGRi?= =?utf-8?B?dUpRZzhkK0s1WGY3Mk5uTDZuN2dLTFNrWlJZSzRNUmROckpCeWJpQURFYVdv?= =?utf-8?B?S1daOXpkbHV0NkVRWXJQYjVsb3RGbXhmVVVjL282aEk3anArdkg1MkVBQ2dU?= =?utf-8?B?V0JaRDZ0ZFg4a2ZJWkUzVHNGV0svdWY3Vy95b3NUd240VXg3STRjWEZ4OExp?= =?utf-8?B?c1I5SDM1T01CNk9tYmZBdSttM1E5aXFrU3AyZUhScDlkUHZmd2czUVl4OGV5?= =?utf-8?B?cjVLVEhEQm8zb0pQYVJzUTNEOSs5dC9GYUV4ZUZZLzU2WVdOQ29wUVRXUWF1?= =?utf-8?B?Z2NHWUdtNGQ4aFpDUkJERU9aMGdtU2V4WEpoYUZoZk56NktNY1dMSG9ET0xG?= =?utf-8?B?bFBWNFdUK216WVJZZHNXVnpwRFljR1kxZklHZlBsbXJDOU5hb0NzSHY4VGFG?= =?utf-8?B?KzVBdnB1U2Z3NWpuL2Vnb3pyOE45eng3WEpXYjE4elRpR3VtWE5HV2VoaERS?= =?utf-8?B?L3RSMzE5KzVheVRmZGlCNkJTMDJoeEprdk5zNit3enR0Rko3Q3NnSWtRdEd2?= =?utf-8?B?SERpQ2pXRUlaRkEranowcWEzS09RMmVVdVRqUUl4RUMxYzduNHd5eHBrcG5P?= =?utf-8?B?d05NREQvR1BXMGJ1V0xuTUcwa0k2NklKQzM5UkFhN3FKelF6V0RzYVlqUjFh?= =?utf-8?B?dHYySVVuMnBacUNiUUFSR25WVllPZ0hUcGpjL1BSWFZRS1pRSFkvbGhXc1Ra?= =?utf-8?Q?svZdHNg/0xm7/AEY/wEE2FOBsB6wUpXQMecOq7Uab0=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebf952b5-6716-43c4-d43b-08d99d50f084 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5065.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 16:02:00.9111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 34xI4TzcsaFi2lvHi+j01GjusSxys5ke65ScFK4TCe+DenXA9YTHyxnZlafH+wBfohbsVQgg1sGeW1Xj615ikw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5324 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2021 16:02:03 -0000 On 10/25/21 10:23 PM, Simon Marchi wrote: > [CAUTION: External Email] > >> I would be tempted to use the implementation from the standard library >> when available (i.e. if compiling in c++14 and later). Something like >> that should do it: >> >> #if __cplusplus >= 201402L >> #include >> >> using std::make_unique; >> #else >> /* template<...> std::unique_ptr make_unique(...){} */ >> #endif >> >> This is quite similar to what is done in gdbsupport/gdb_string_view.h. >> >> And to follow what is done in the string_view example, make_unique could >> probably be declared in the gdb namespace. I guess this suggestion >> would mainly make sense if this code is moved to gdbsupport (as >> suggested in the comment). >> >> One possible limitation of placing this in gdbsupport is that this >> implementation does not handle the 'template std::unique_ptr >> std::make_unique (std::size_t size)' case used to create arrays. >> It would be easy to borrow it from libstdc++ as well if we wanted to >> have a fully compliant make_unique implementation. >> >> Maybe a maintainer has an opinion on the whether this should be moved to >> gdbsupport? > > I think it would be good to have a gdb::make_unique in gdbsupport, as > you described (that uses the one from the standard library if > __cplusplus >= 201402L). There are surely other spots that could > benefit from it. > > Simon > Makes sense. Should I just add the existing function in this patch and leave the array version for someone to add it later? I don't like adding utility functions which are not currently in use. Zoran