From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by sourceware.org (Postfix) with ESMTPS id 417F33858C52 for ; Tue, 17 Oct 2023 14:57:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 417F33858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 417F33858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697554664; cv=none; b=u0qFMXIjaj5Y6/6K55ea+dGZ/Mhl79ml48J3KBOFDcy0bP1Y5qbxwepviprm6U3ZLGJc8eorPoKtmyMMogbCKX5cchaaJYhsJ30CF+3iNh3Y59B9TGoWU4gRmy+QI/Mmw73DV5zvtti68bwx/pmzQ6CJhmpd6Xbt55J99nHukiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697554664; c=relaxed/simple; bh=FpaC+mAB2NzMGRl0L8nLpcMGtKVjWp5fsCWXACs5cKY=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=WR/7ZhFHZzhnwgQixebfCHM8lP1axat1NDKMatRUXDpxpjOh3yexaNcIrt7RvoiYzPPlHrLwNVQ/yHy4qI26F+6w2bk/t/s3gv2y9FeKlk1OOF9+SUUo5cOdpiRjR+Zmj0MyKwryZQEoX8rEkLUpfvuY44Atbl5ymgo0C6OKRBI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4083740f92dso2881595e9.3 for ; Tue, 17 Oct 2023 07:57:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697554662; x=1698159462; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EMh1Oij59OQkOiRYqwtt0F/HM1Gjz8ELOaQ5039zJTI=; b=lgKo44GaynEtXhroiQSrmCN5zhBQ+sM9utGIqjZaGHgbbk+x9h29VMqcHSzhYSfmkH +2ogdLAl/FRZtEcsgfRuUzrL9mwsn/IpGZk8kdfiK0CLrE3sWN88gLVt6Dlr2664bhqF pwjgQ02MWq9IsKPXYWXXTaSz8acMYD65F/dcS/CqDMXFMxMEyquAs6yCQ0iLElErAPWL rCzhgyEuun5pIKxo6kF6O8B7b9ociveqrzHOIYHrVGe0jkoMsMdANH12qEFu6lPRooVM 517s1Do+3hwyxAVbWLmfub03dvnlwD9S052TqDWbi2IJW1sJiA0vtd7WyFVt4oih6+5T ZAEA== X-Gm-Message-State: AOJu0YxlBjHSfRmRHjTzxb3Ne0eMQkudaLSgHRr17aGDmGakxPIVdcDc ojUexs6jT7Ysj00D/nbJsuDNeGcY2AEIQg== X-Google-Smtp-Source: AGHT+IFgB9y2rg81yrvkeYxktOMW5qAjPm7+ZwmkbDNpxHexDPRGrJ3z8C+rnMiwHznedyPBSRiQig== X-Received: by 2002:a05:600c:a44:b0:408:364e:34a2 with SMTP id c4-20020a05600c0a4400b00408364e34a2mr1133372wmq.10.1697554661605; Tue, 17 Oct 2023 07:57:41 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:5aaf:ade2:476b:3ff2? ([2001:8a0:f939:d200:5aaf:ade2:476b:3ff2]) by smtp.gmail.com with ESMTPSA id 13-20020a05600c230d00b004068495910csm9974413wmo.23.2023.10.17.07.57.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 07:57:41 -0700 (PDT) Message-ID: <2cfcbc4c-4094-42e1-86c4-974ddcc88a28@palves.net> Date: Tue, 17 Oct 2023 15:57:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/24] gdb: add program_space parameter to target_so_ops::clear_solib Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-3-simon.marchi@efficios.com> From: Pedro Alves In-Reply-To: <20231010204213.111285-3-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Just a tiny nit. On 2023-10-10 21:39, Simon Marchi wrote: > diff --git a/gdb/solib-darwin.c b/gdb/solib-darwin.c > index 98c81bb3bdaa..4796315c373a 100644 > --- a/gdb/solib-darwin.c > +++ b/gdb/solib-darwin.c > @@ -78,16 +78,14 @@ static const registry::key > /* Get the current darwin data. If none is found yet, add it now. This I guess "current darwin data" -> "darwin data for PSPACE" ? > function always returns a valid object. */ > > -static struct darwin_info * > -get_darwin_info (void) > +static darwin_info * > +get_darwin_info (program_space *pspace) > { > --- a/gdb/solib-dsbt.c > +++ b/gdb/solib-dsbt.c > @@ -169,16 +169,14 @@ static const registry::key solib_dsbt_pspace_data; > /* Get the current dsbt data. If none is found yet, add it now. This Ditto "current" here. > function always returns a valid object. */ > > -static struct dsbt_info * > -get_dsbt_info (void) > +static dsbt_info * > +get_dsbt_info (program_space *pspace) > { > - struct dsbt_info *info; > - > - info = solib_dsbt_pspace_data.get (current_program_space); > - if (info != NULL) > + dsbt_info *info = solib_dsbt_pspace_data.get (pspace); > + if (info != nullptr) > return info; > > - return solib_dsbt_pspace_data.emplace (current_program_space); > + return solib_dsbt_pspace_data.emplace (pspace); > } > > > @@ -270,9 +268,6 @@ decode_loadmap (const gdb_byte *buf) > return int_ldmbuf; > }