From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id 89E6F386F0CC for ; Fri, 24 Jun 2022 15:22:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89E6F386F0CC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f48.google.com with SMTP id 189so1040549wmz.2 for ; Fri, 24 Jun 2022 08:22:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=7f7CJUW9tZ4lBlFxsucJtX68DJOzZAXhf22dR7VW+wo=; b=vuOy+smyM3s+/JPRjk/tT8f8ga7SCdY0YxUV1Suq9BPMGGHZQ7YLIHtLbVrsZTtV9c UYLJk1Fn3YuNzIVTuanbeBYWEAkiaatQ5txtNphV1J2jK2Ydg2PEo5USxckqKHtf8/ar xjAtJbww7QHSltzB01AO7cPGoqqi58KI6PWgW30DyQ0Vm4jFmpvk2BqZUSC2TkM/JLcO fcrzgbhhhNxrROZYFXX86zVjtHGsEnWCAdiWvtdXSKZdRCpjc8KS8xfkGwQ7i3hyZv5N 4x142GNEHNH1OOYs7PHpOpEebOtlcjO3ZOZsYlWQtHDLu75s0gW0JRfyFjDBSf1Ro+cq XHyg== X-Gm-Message-State: AJIora819y+BLXdp7a+FMJz1VzLDN+BHMGojuCB5gfjdVz6n6P7ATvVe xE8iQCNMUjCaXe4wGBg7We/pdYouKC4= X-Google-Smtp-Source: AGRyM1u/d0Qp7Yg3VNFT7ZthU4fvg+hYqTPshvUUvCwdGon+lUeE8biQaKvLQwY93CeLBKwJUdhsjg== X-Received: by 2002:a7b:c4d8:0:b0:39c:97ed:baa3 with SMTP id g24-20020a7bc4d8000000b0039c97edbaa3mr4337944wmk.58.1656084171666; Fri, 24 Jun 2022 08:22:51 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id n14-20020a05600c500e00b003a03564a005sm4980645wmr.10.2022.06.24.08.22.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 08:22:50 -0700 (PDT) Message-ID: <2d43e796-7228-f69a-c15b-5463653fe07b@palves.net> Date: Fri, 24 Jun 2022 16:22:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] gdb/testsuite: modernize gdb.base/maint.exp Content-Language: en-US To: Andrew Burgess , Bruno Larsen , gdb-patches@sourceware.org References: <20220509180431.31032-1-blarsen@redhat.com> <87edzic8v1.fsf@redhat.com> From: Pedro Alves In-Reply-To: <87edzic8v1.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 15:22:54 -0000 On 2022-06-21 16:52, Andrew Burgess via Gdb-patches wrote: >> + pass "$test_name 1" > You could use: > > pass "$gdb_test_name, pattern 1" > > here, and similar, with ', pattern 2' for the next 'pass' call. > How about pass "$gdb_test_name (pattern 1)" pass "$gdb_test_name (pattern 2)" ? The idea being that the text in the trail parens is not considered part of the test name, so when comparing gdb.sum files and matching test names, that parens part should be discarded. Whether this test passes with pattern 1 or 2 should make no difference IIUC, thus I think it should not be part of the (part that counts as real) test name.