From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121990 invoked by alias); 20 Jun 2018 16:47:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121974 invoked by uid 89); 20 Jun 2018 16:47:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Jun 2018 16:47:21 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5KGlEum026364 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 20 Jun 2018 12:47:19 -0400 Received: by simark.ca (Postfix, from userid 112) id A2D291EF29; Wed, 20 Jun 2018 12:47:14 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id CA43C1E481; Wed, 20 Jun 2018 12:47:12 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 20 Jun 2018 16:47:00 -0000 From: Simon Marchi To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite: Fix cc-with-tweaks.sh being executed in the wrong shell In-Reply-To: <1524771257-13690-1-git-send-email-simon.marchi@ericsson.com> References: <1524771257-13690-1-git-send-email-simon.marchi@ericsson.com> Message-ID: <2d8e4f3e9fb14412b67662a8aa11b8d5@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 20 Jun 2018 16:47:14 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00499.txt.bz2 On 2018-04-26 15:34, Simon Marchi wrote: > The cc-with-tweaks.sh script needs to be executed with bash. When > trying to run this: > > make check RUNTESTFLAGS="--target_board=dwarf4-gdb-index" > TESTS="gdb.base/return.exp" > > I get: > > gdb compile failed, > /home/emaisin/src/binutils-gdb/gdb/contrib/cc-with-tweaks.sh: 174: > /home/emaisin/src/binutils-gdb/gdb/contrib/cc-with-tweaks.sh: Bad > substitution > > The reason is that the board files execute cc-with-tweaks.sh using > /bin/sh, which points to dash on my machine. Remove the /bin/sh part > and let the shebang choose the right interpreter. I pushed this. Simon