From: Simon Marchi <simark@simark.ca>
To: Lancelot SIX <lancelot.six@amd.com>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH v5] gdb/gcore: interrupt all threads before generating the corefile
Date: Fri, 10 Feb 2023 16:46:30 -0500 [thread overview]
Message-ID: <2daa1736-57cb-3c5a-f1cd-48f5aa03d010@simark.ca> (raw)
In-Reply-To: <20230130165110.1440365-1-lancelot.six@amd.com>
On 1/30/23 11:51, Lancelot SIX wrote:
> Hi, this V5 follows
> https://sourceware.org/pipermail/gdb-patches/2022-December/194504.html.
>
> Changes since V4:
>
> - Update gdb/NEWS to fall into the "Changes since GDB 13" section.
> - Use "build_executable" instead of "prepare_for_testing" in the test
> to avoid one useless start of GDB.
> - Updated the test's description.
> - Updated the copyright year to include 2023.
>
> Best,
> Lancelot.
Hi Lancelot,
It seems like this version does not address the comment I made on v4,
the "what if a thread is doing an inline step" when we call this. Maybe
another way to look at it is, if the inferior was resumed with schedlock
on. Only one thread is "executing", and any_thread_of_inferior could
fall on a non-executing thread. Also, we'd want to end in the same
state as where we started. Can you check that case (with schedlock)? I
have the feeling that it's not handled.
Simon
next prev parent reply other threads:[~2023-02-10 21:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 16:51 Lancelot SIX
2023-02-10 14:36 ` [PING] " Lancelot SIX
2023-02-10 21:46 ` Simon Marchi [this message]
2023-03-22 16:35 ` [PATCH v6 0/3] interrupt all threads to generate core in non-stop targets Lancelot SIX
2023-03-22 16:35 ` [PATCH v6 1/3] gdb: add inferior parameter to target_is_non_stop_p Lancelot SIX
2023-03-22 16:35 ` [PATCH v6 2/3] gdb/infrun: Improve assertion in stop_all_threads Lancelot SIX
2023-03-22 16:35 ` [PATCH v6 3/3] gdb/gcore: interrupt all threads to generate core in non-stop targets Lancelot SIX
2023-03-22 16:44 ` Eli Zaretskii
2023-03-22 16:59 ` Lancelot SIX
2023-05-10 18:46 ` Lancelot SIX
2023-05-10 19:05 ` Eli Zaretskii
2023-05-10 19:08 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2daa1736-57cb-3c5a-f1cd-48f5aa03d010@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).