From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Gj+2=6G=simark.ca=simark@sourceware.org>
Received: from simark.ca (simark.ca [158.69.221.121])
	by sourceware.org (Postfix) with ESMTPS id 1F4153858414
	for <gdb-patches@sourceware.org>; Fri, 10 Feb 2023 21:46:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F4153858414
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca
Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPSA id 5818F1E0D3;
	Fri, 10 Feb 2023 16:46:30 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail;
	t=1676065590; bh=1wTl048MUR89MrdaK3B5eOMlQZDljhIZMh4nPnk0TRo=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=OzPt6wCrKntGW8aH5thz7rZIsfrY0y5lwMc0b2hBmZXuI7b1AqPUrh+zEEpqQFInJ
	 gCeuP7c47C33WqqMgTEmBZAlKK1nRUqClN1gYf3yxZ660oUiMU3mCgs+kItoMICqjX
	 mS3eopmLmmFK9s73nA1BhYv+dbyPypYpNRV6V6qk=
Message-ID: <2daa1736-57cb-3c5a-f1cd-48f5aa03d010@simark.ca>
Date: Fri, 10 Feb 2023 16:46:30 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH v5] gdb/gcore: interrupt all threads before generating the
 corefile
Content-Language: fr
To: Lancelot SIX <lancelot.six@amd.com>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
References: <20230130165110.1440365-1-lancelot.six@amd.com>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <20230130165110.1440365-1-lancelot.six@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 1/30/23 11:51, Lancelot SIX wrote:
> Hi, this V5 follows
> https://sourceware.org/pipermail/gdb-patches/2022-December/194504.html.
> 
> Changes since V4:
> 
> - Update gdb/NEWS to fall into the "Changes since GDB 13" section.
> - Use "build_executable" instead of "prepare_for_testing" in the test
>   to avoid one useless start of GDB.
> - Updated the test's description.
> - Updated the copyright year to include 2023.
> 
> Best,
> Lancelot.

Hi Lancelot,

It seems like this version does not address the comment I made on v4,
the "what if a thread is doing an inline step" when we call this.  Maybe
another way to look at it is, if the inferior was resumed with schedlock
on.  Only one thread is "executing", and any_thread_of_inferior could
fall on a non-executing thread.  Also, we'd want to end in the same
state as where we started.  Can you check that case (with schedlock)?  I
have the feeling that it's not handled.

Simon