From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 143FC385AC29 for ; Mon, 6 Mar 2023 15:32:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 143FC385AC29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678116726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DO+Jovu2taA68Uu10uUEx0vaUGsaenOjfl1pBBIuaI0=; b=SZuPkLjNN4UQdlqYGd1BMg4YTIN2yt1ne9f6WId322TsUfmtCBb4hoHnOxbgjNBTMMP+Jw N+4OeYTYlimJd4ZeZzPujGLxL+8zf7tEeRdpStT7pP6poMCCCQwtpTvvU7fIhW1RG0vnGj 5bJMt4gzFTZ3ehy1KRYymyD5lT4NwRI= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-d5XW-_ibMV6f0Y4CxmMQJg-1; Mon, 06 Mar 2023 10:32:04 -0500 X-MC-Unique: d5XW-_ibMV6f0Y4CxmMQJg-1 Received: by mail-ed1-f71.google.com with SMTP id c1-20020a0564021f8100b004acbe232c03so14148228edc.9 for ; Mon, 06 Mar 2023 07:32:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678116723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DO+Jovu2taA68Uu10uUEx0vaUGsaenOjfl1pBBIuaI0=; b=w+29UFDQZVixCfldKenMlf6OKckNLOgdTYnFLico9zFuad3nukNrhr4LmeHQS9v5PW hGiZpA2xxH4D/wivku4w0On+J5psXEE1LDvBujnikht64vZ5Xis1As24FYCleGiPFahC Gt0jwLj5pQpizWsuUTMjko49KiSRwcxhTf8pbP1MPUbgK2DMpXykghIKBskZPT6Pye6C 3mXWX0+0MLZMbuoGFc35hOvnyaUuvxwVU2YLkNUJqdIRzyQFU0JWKjADPRr52VaqmmiM RzVbonmBHgpHJ4XbU9km/FfliaEVqMH/Cbwzzzg9J0CDlZOPDKT2jwD/8q6AMsF853U9 F8HA== X-Gm-Message-State: AO0yUKU5/swycZlXzIQzJi3bZTquAVpihZnCsV6Va40RDhZs+fUmpemb nLkgiLBovTrTQdeENYmQ/o2o9B5jidOJgiN/QiQapBKtU8N+c3xymJlnf1ZWFWX83A4vFiWYm9k NxSCmiCoPA4lxOhYdfVzZuqf1dMYWbR3mKFjGQZ6u69/CngbIhSGH+FVB0zk1sdC+7oSxH5Lbvc KQcnUapA== X-Received: by 2002:aa7:d90d:0:b0:4af:70a6:5b06 with SMTP id a13-20020aa7d90d000000b004af70a65b06mr10817914edr.27.1678116723370; Mon, 06 Mar 2023 07:32:03 -0800 (PST) X-Google-Smtp-Source: AK7set8eev84TB/FdYJbv4nZsJ1Vs2hp66KzOFKtoYtGIuwWPNrGZSjjaBKr1Ee90r+XmBaUNBrSgA== X-Received: by 2002:aa7:d90d:0:b0:4af:70a6:5b06 with SMTP id a13-20020aa7d90d000000b004af70a65b06mr10817893edr.27.1678116723042; Mon, 06 Mar 2023 07:32:03 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id k12-20020a50ce4c000000b004c0459c20f9sm5236559edj.66.2023.03.06.07.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 07:32:02 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 2/5] gdb/gdbarch: remove yet more 'invalid=True' from gdbarch_components.py Date: Mon, 6 Mar 2023 15:31:54 +0000 Message-Id: <2dc5238144357ac1885ae86b12ef6bd77daa01c5.1678116328.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Following on from the previous commit, this commit removes yet more 'invalid=True' lines from gdbarch_components.py where the invalid setting has no effect. Due to the algorithm used in gdbarch.py for generated verify_gdbarch, if a component has a postdefault value then no invalid check will ever be generated for the component, as such setting 'invalid=True' on the component is pointless. This commit removes the setting of invalid. There is no change in the generated code after this commit. --- gdb/gdbarch_components.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/gdb/gdbarch_components.py b/gdb/gdbarch_components.py index 656c6a9f905..d3dfcfc806f 100644 --- a/gdb/gdbarch_components.py +++ b/gdb/gdbarch_components.py @@ -206,7 +206,6 @@ Value( type="const struct floatformat **", name="bfloat16_format", postdefault="floatformats_bfloat16", - invalid=True, printer="pformat (gdbarch, gdbarch->bfloat16_format)", ) @@ -221,7 +220,6 @@ Value( type="const struct floatformat **", name="half_format", postdefault="floatformats_ieee_half", - invalid=True, printer="pformat (gdbarch, gdbarch->half_format)", ) @@ -236,7 +234,6 @@ Value( type="const struct floatformat **", name="float_format", postdefault="floatformats_ieee_single", - invalid=True, printer="pformat (gdbarch, gdbarch->float_format)", ) @@ -251,7 +248,6 @@ Value( type="const struct floatformat **", name="double_format", postdefault="floatformats_ieee_double", - invalid=True, printer="pformat (gdbarch, gdbarch->double_format)", ) @@ -266,7 +262,6 @@ Value( type="const struct floatformat **", name="long_double_format", postdefault="floatformats_ieee_double", - invalid=True, printer="pformat (gdbarch, gdbarch->long_double_format)", ) @@ -289,7 +284,6 @@ One if `wchar_t' is signed, zero if unsigned. name="wchar_signed", predefault="-1", postdefault="1", - invalid=True, ) Method( @@ -332,7 +326,6 @@ addr_bit is the size of a target address as represented in gdb name="addr_bit", predefault="0", postdefault="gdbarch_ptr_bit (gdbarch)", - invalid=True, ) Value( @@ -355,7 +348,6 @@ and if Dwarf versions < 4 need to be supported. name="dwarf2_addr_size", predefault="0", postdefault="gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT", - invalid=True, ) Value( @@ -366,7 +358,6 @@ One if `char' acts like `signed char', zero if `unsigned char'. name="char_signed", predefault="-1", postdefault="1", - invalid=True, ) Function( -- 2.25.4