[ was: Re: [PATCH v2 2/2] Add Rust support to source highlighting ] On 19-09-19 14:54, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Well, it does work, but your question makes me realize that that's an > Tom> implementation artefact of the library, which could change for newer > Tom> version (or perhaps there are older versions where that differs). So it > Tom> should be safer to wrap highlighter construction as well. > > Tom> Updated the patch accordingly, and also added a PR number to both patches. > > Looks good to me -- but the bad news is you'll probably now want a > similar patch on master. Ok, committed to 8.3 branch. Here's the proposed commit for master. Ok for trunk if testing on x86_64-linux finishes without problems? Thanks, - Tom