From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tdevries@suse.de>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
 by sourceware.org (Postfix) with ESMTPS id 663973858D38
 for <gdb-patches@sourceware.org>; Wed, 12 Oct 2022 17:20:04 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 663973858D38
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 51D5821BC2;
 Wed, 12 Oct 2022 17:20:03 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2016413A5C;
 Wed, 12 Oct 2022 17:20:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WE22BUP3RmPHfwAAMHmgww
 (envelope-from <tdevries@suse.de>); Wed, 12 Oct 2022 17:20:03 +0000
Message-ID: <2e17b10a-1acb-79c3-26c9-2faeca6286c6@suse.de>
Date: Wed, 12 Oct 2022 19:20:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v3 4/5] sim: Check known getopt definition existence
Content-Language: en-US
From: Tom de Vries <tdevries@suse.de>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: gdb-patches@sourceware.org
References: <cover.1664095312.git.research_trasio@irq.a4lg.com>
 <cover.1665038297.git.research_trasio@irq.a4lg.com>
 <a57b2a3460064a9adc95914ba21214c8dbfc2bbf.1665038297.git.research_trasio@irq.a4lg.com>
 <7b235ccb-ab2e-cba0-3015-2eae5fe6a8a4@suse.de>
 <527a756e-2b1f-1509-5a6f-e4344fbee404@irq.a4lg.com>
 <57dbc444-6271-dfc2-8534-387187088f47@suse.de>
In-Reply-To: <57dbc444-6271-dfc2-8534-387187088f47@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Oct 2022 17:20:05 -0000

On 10/12/22 19:08, Tom de Vries wrote:
> On 10/12/22 19:03, Tsukasa OI wrote:
>> Adding
>> #include <getopt.h>
>> after
>> #include <sys/types.h>
>> might change something but I cannot guarantee whether this change would
>> fix the issue.
> 
> Ack, I'll try attached patch on the try-buildbot.
> 

I've tried it out, and it still fails the same:
...
/srv/buildbot/worker/gdb-try-centos-x86_64/gdb-build/sim/../../binutils-gdb/sim/m32c/main.c: 
In function ‘main’:
/srv/buildbot/worker/gdb-try-centos-x86_64/gdb-build/sim/../../binutils-gdb/sim/m32c/main.c:144:3: 
error: implicit declaration of function ‘getopt’ 
[-Werror=implicit-function-declaration]
    while ((o = getopt (argc, argv, "tc:vdm:C")) != -1)
    ^
cc1: all warnings being treated as errors
make[3]: *** [main.o] Error 1
make[3]: Leaving directory 
`/srv/buildbot/worker/gdb-try-centos-x86_64/gdb-build/sim/m32c'
...

Thanks,
- Tom