public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Johnson Sun <j3.soon777@gmail.com>
To: BrunoLarsen <blarsen@redhat.com>, gdb-patches@sourceware.org
Subject: [PING^3] [PATCH v2] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop
Date: Fri, 25 Nov 2022 23:10:18 +0800	[thread overview]
Message-ID: <2e4ab20c-30f4-e6cd-69ec-729b1d74a921@gmail.com> (raw)
In-Reply-To: <e6577bba-2a1a-b395-096b-617752eb9e3d@gmail.com>

Ping for: 
<https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.

Johnson

On 11/18/2022 8:14 PM, JohnsonSun wrote:
> Ping for: 
> <https://sourceware.org/pipermail/gdb-patches/2022-October/192910.html>.
>
> Johnson
>
> On 10/21/2022 2:24 AM, Johnson Sun wrote:
>> In 2014, the function `gdbpy_should_stop' has been replaced with
>> `gdbpy_breakpoint_cond_says_stop'
>>
>> This replaces `gdbpy_should_stop' with 
>> `gdbpy_breakpoint_cond_says_stop' in the
>> comments.
>>
>> Since `gdbpy_should_stop' has been renamed as noted in 
>> `gdb/ChangeLog-2014':
>>
>>     * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed
>>     from gdbpy_should_stop.  Change result type to enum scr_bp_stop.
>> ---
>>   gdb/python/py-finishbreakpoint.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gdb/python/py-finishbreakpoint.c 
>> b/gdb/python/py-finishbreakpoint.c
>> index c80096f6810..dcf86317779 100644
>> --- a/gdb/python/py-finishbreakpoint.c
>> +++ b/gdb/python/py-finishbreakpoint.c
>> @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self)
>>     Py_TYPE (self)->tp_free (self);
>>   }
>>   -/* Triggered when gdbpy_should_stop is about to execute the `stop' 
>> callback
>> +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to 
>> execute the `stop' callback
>>      of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and 
>> cache the
>>      `return_value', if possible.  */
>>   @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct 
>> gdbpy_breakpoint_object *bp_obj)
>>       }
>>   }
>>   -/* Triggered when gdbpy_should_stop has triggered the `stop' callback
>> +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the 
>> `stop' callback
>>      of the gdb.FinishBreakpoint object BP_OBJ.  */
>>     void
>

  reply	other threads:[~2022-11-25 15:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 17:24 [PATCH 0/3] [PR gdb/18655] Fix Python FinishBreakpoints not deleted bug Johnson Sun
2022-09-20 17:24 ` [PATCH 1/3] [gdb/testsuite] Add gdb.python/py-finish-breakpoint-deletion.exp for Bug 18655 Johnson Sun
2022-09-21 13:44   ` Bruno Larsen
2022-09-23  5:16     ` Johnson Sun
2022-09-20 17:24 ` [PATCH 2/3] [gdb/python] Fix " Johnson Sun
2022-09-21 14:02   ` Bruno Larsen
2022-09-20 17:24 ` [PATCH 3/3] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop Johnson Sun
2022-09-21 14:09   ` Bruno Larsen
2022-09-23  5:41 ` [PATCH v2] [PR python/18655] Fix deletion of FinishBreakpoints Johnson Sun
2022-09-23  8:32   ` Bruno Larsen
2022-09-23 20:16     ` Johnson Sun
2022-09-23 20:27   ` [PATCH v3] " Johnson Sun
2022-10-12  1:53     ` Simon Marchi
2022-10-20 17:34       ` Johnson Sun
2022-10-20 17:49         ` [PATCH v4] " Johnson Sun
2022-11-18 12:16           ` [PING] " Johnson Sun
2022-11-18 15:56           ` Simon Marchi
2022-09-23  6:00 ` [PATCH v2] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop Johnson Sun
2022-10-20 18:24   ` [PING] " Johnson Sun
2022-11-18 12:14     ` [PING^2] " Johnson Sun
2022-11-25 15:10       ` Johnson Sun [this message]
2022-12-04 16:45         ` [PING^4] " Johnson Sun
2022-12-12 21:44           ` [PING^5] " Johnson Sun
2022-12-13  2:34             ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e4ab20c-30f4-e6cd-69ec-729b1d74a921@gmail.com \
    --to=j3.soon777@gmail.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).