From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id BED9E3952484 for ; Fri, 25 Nov 2022 15:10:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BED9E3952484 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52d.google.com with SMTP id 130so4180449pgc.5 for ; Fri, 25 Nov 2022 07:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=G4s6eS1JUREMiwErONO5FOQaBhxHDS7haMpW5i/roRM=; b=g3YZpp7zJZiqb/lNnISmLEanyIvwNoCZCx9i0uunJkPk6grhTcFdsQcyb2zbZ4dvxT YVkw+SF8TEyGUdEt6TqN2G2tF2o7707RF5LKkzXYx4+ReCSvVxp/8JsTCLHE0eAf1mm2 8imamStfp3vptm5PzZi1RBfgmCyX7AKCRleifRf0Sa1gTcMSR4Zscouyp+1d9IUz4Ih1 9s7fsVSXO57uSKiti/bUXRQK9LId1zDyvGzrVb0sIWt2FlxeQtnfv1trhkh0jPSNaAa0 YVcMovUV5czv6rFmRi4IMR+4sFeCcKaUGS3GAPqk3ZxZjs+FNNGCTvwF3I98iF6loKK0 QzaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G4s6eS1JUREMiwErONO5FOQaBhxHDS7haMpW5i/roRM=; b=zdbeKFiCqU3iVu6cNgbL9BTEQNQNzP4Jc4tZiLSkcP6YxI75+zxjrlpJFFY9IITrGC MxY+XJUw/bbfshSWg63loLwDzKft2yF92TNIYguQMfR4f1cbu7IgwI1TPRQHvnwJIX1E URo4wBTp1gISulOdhn2+A6jiBtPnbbk2H98cSZdqd41XxAEvWYXM3YKauMBLdOAu8buu 1AGgBnJJiFA6SQ7TmV0OGPsj4JoGDB+lJJeAYyhqIKHIPOH+1wU5AO6KG4XxDi8ThhRf /try0aNeCa4Yk/JAUCyEO6CQpN9LtptwK9SQFfKI5OFtdOtZ+A/bLob3/lFm7zfdlX4e zsIg== X-Gm-Message-State: ANoB5pkYx1Gu1m5psZ4iTDloFUXFmH0yk6Cv2AOFKTVaYgbIpU44E6T4 YKrFtzb7PCP3ktLW65zlXdA5FDe2dVA= X-Google-Smtp-Source: AA0mqf7ZyhgwzJWdqlZ7vs+N5rFYJKh9hZ7i1Sa+YLM0iV+jsWyDAC37USF2wZBzmwke8nQrxnKWNw== X-Received: by 2002:a63:fc14:0:b0:477:86c1:640c with SMTP id j20-20020a63fc14000000b0047786c1640cmr16578635pgi.226.1669389020731; Fri, 25 Nov 2022 07:10:20 -0800 (PST) Received: from [192.168.2.107] (61-220-36-70.hinet-ip.hinet.net. [61.220.36.70]) by smtp.gmail.com with ESMTPSA id i14-20020a056a00004e00b0056da8c41bbasm3200481pfk.161.2022.11.25.07.10.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 07:10:20 -0800 (PST) Message-ID: <2e4ab20c-30f4-e6cd-69ec-729b1d74a921@gmail.com> Date: Fri, 25 Nov 2022 23:10:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: [PING^3] [PATCH v2] [gdb/python] Replace gdbpy_should_stop with gdbpy_breakpoint_cond_says_stop From: Johnson Sun To: BrunoLarsen , gdb-patches@sourceware.org References: <20220923060027.78902-1-j3.soon777@gmail.com> <20221020182456.2701-1-j3.soon777@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping for: . Johnson On 11/18/2022 8:14 PM, JohnsonSun wrote: > Ping for: > . > > Johnson > > On 10/21/2022 2:24 AM, Johnson Sun wrote: >> In 2014, the function `gdbpy_should_stop' has been replaced with >> `gdbpy_breakpoint_cond_says_stop' >> >> This replaces `gdbpy_should_stop' with >> `gdbpy_breakpoint_cond_says_stop' in the >> comments. >> >> Since `gdbpy_should_stop' has been renamed as noted in >> `gdb/ChangeLog-2014': >> >>     * python/py-breakpoint.c (gdbpy_breakpoint_cond_says_stop): Renamed >>     from gdbpy_should_stop.  Change result type to enum scr_bp_stop. >> --- >>   gdb/python/py-finishbreakpoint.c | 4 ++-- >>   1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/python/py-finishbreakpoint.c >> b/gdb/python/py-finishbreakpoint.c >> index c80096f6810..dcf86317779 100644 >> --- a/gdb/python/py-finishbreakpoint.c >> +++ b/gdb/python/py-finishbreakpoint.c >> @@ -90,7 +90,7 @@ bpfinishpy_dealloc (PyObject *self) >>     Py_TYPE (self)->tp_free (self); >>   } >>   -/* Triggered when gdbpy_should_stop is about to execute the `stop' >> callback >> +/* Triggered when gdbpy_breakpoint_cond_says_stop is about to >> execute the `stop' callback >>      of the gdb.FinishBreakpoint object BP_OBJ.  Will compute and >> cache the >>      `return_value', if possible.  */ >>   @@ -134,7 +134,7 @@ bpfinishpy_pre_stop_hook (struct >> gdbpy_breakpoint_object *bp_obj) >>       } >>   } >>   -/* Triggered when gdbpy_should_stop has triggered the `stop' callback >> +/* Triggered when gdbpy_breakpoint_cond_says_stop has triggered the >> `stop' callback >>      of the gdb.FinishBreakpoint object BP_OBJ.  */ >>     void >