From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 0EEDC3858D1E for ; Mon, 19 Jun 2023 17:12:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EEDC3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4A06E1F889; Mon, 19 Jun 2023 17:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1687194774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i4Rr3snXhWH5RREBn36uoh9Fg9u/Er0FqmjaaDY2390=; b=A6wITPh/AMlBD3ne/Ct7rBDRcD8ERRB1HMbchLr4+PdCtXXkFK0d3bkaNgsCGdl3EiI1bk 2uMWrlSt39bw8Tep40LKx28qxMYarOnVBVTEM5dCySTAoW7DGQDionz1HgrgPaSksS15s9 bRGY9kqWXRPZCRLm8X0eWWKao9w1/g8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1687194774; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i4Rr3snXhWH5RREBn36uoh9Fg9u/Er0FqmjaaDY2390=; b=yIedfs+E5ZLNufK4bRS65eWOCz9bUrAF3G0J5MCXAN7CeL4L6j60eGfXyFGQhsZtH2wG+3 VewcOw2ZiRdJBlBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2FE2E139C2; Mon, 19 Jun 2023 17:12:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zMuGCpaMkGSqbwAAMHmgww (envelope-from ); Mon, 19 Jun 2023 17:12:54 +0000 Message-ID: <2e7603da-d890-c37c-1497-3342600370ef@suse.de> Date: Mon, 19 Jun 2023 19:12:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [pushed] [gdb/testsuite] Clean up before compilation in gdb.ada/call-no-debug.exp Content-Language: en-US To: Luis Machado , Tom Tromey , Tom de Vries via Gdb-patches References: <20230616113305.27867-1-tdevries@suse.de> <877cs345ij.fsf@tromey.com> <30dc92ca-6fd5-46f1-d716-463be55cba98@suse.de> <9c0db209-2d05-213c-0491-1debe35fb403@arm.com> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/19/23 16:26, Luis Machado wrote: > On 6/19/23 15:25, Luis Machado wrote: >> On 6/17/23 11:50, Tom de Vries via Gdb-patches wrote: >>> On 6/16/23 20:38, Tom Tromey wrote: >>>>>>>>> "Tom" == Tom de Vries via Gdb-patches writes: >>>> >>>> Tom> Running test-case gdb.ada/call-no-debug.exp with target board unix/-m64 works >>>> Tom> fine, but if we run it again with target board unix-m32, we run into: >>>> >>>> Thanks for doing this. >>>> >>>> If gdb's test suite could detect when a new .exp is started, we could >>>> make this always work by removing the corresponding standard output directory. >>> >>> Hi, >>> >>> thanks for the suggestion, I've implemented it in gdb_init.  WDYT? >>> >>> Thanks, >>> - Tom >> >> Would this delete files unrelated to the specific test being executed? I started to see a number >> of errors in the testsuite where tests executed in parallel can't find gdb.log. >> >> For instance: >> >> --- >> >> ERROR: tcl error sourcing binutils-gdb/gdb/testsuite/gdb.arch/aarch64-sve.exp. >> ERROR: couldn't open "outputs/gdb.arch/aarch64-sve/gdb.log": no such file or directory >> while executing >> "log_file -a outputs/gdb.arch/aarch64-sve/gdb.log" >> ("eval" body line 1) >> invoked from within >> "eval log_file $saved_log" >> (procedure "get_compiler_info" line 51) >> invoked from within >> "get_compiler_info $language" >> (procedure "test_compiler_info" line 4) >> invoked from within >> "test_compiler_info "clang-*"" >> (procedure "gdb_compile" line 41) >> invoked from within >> "gdb_compile $src $obj $type $compile_flags" >> (procedure "gdb_simple_compile" line 44) >> invoked from within >> "gdb_simple_compile $name $code $type $compile_flags temp_obj $default_compile_flags" >> (procedure "gdb_can_simple_compile" line 2) >> invoked from within >> "gdb_can_simple_compile aarch32 [join $list \n]" >> (procedure "gdb_real__is_aarch32_target" line 15) >> invoked from within >> "gdb_real__is_aarch32_target" >> ("uplevel" body line 1) >> invoked from within >> "uplevel 2 $real_name" >> (procedure "gdb_do_cache_wrap" line 3) >> invoked from within >> "gdb_do_cache_wrap $real_name {*}$args" >> (procedure "gdb_do_cache" line 48) >> invoked from within >> "gdb_do_cache is_aarch32_target" >> (procedure "is_aarch32_target" line 1) >> invoked from within >> "is_aarch32_target" >> (procedure "is_aarch64_target" line 6) >> invoked from within >> "is_aarch64_target" >> (procedure "gdb_real__allow_aarch64_sve_tests" line 6) >> invoked from within >> "gdb_real__allow_aarch64_sve_tests" >> ("uplevel" body line 1) >> invoked from within >> "uplevel 2 [list $real_name {*}$args]" >> invoked from within >> "gdb_do_cache_wrap $real_name {*}$args" >> (procedure "gdb_do_cache" line 48) >> invoked from within >> "gdb_do_cache allow_aarch64_sve_tests" >> (procedure "allow_aarch64_sve_tests" line 1) >> invoked from within >> "allow_aarch64_sve_tests" >> ("uplevel" body line 1) >> invoked from within >> "uplevel 1 $fn" >> (procedure "require" line 11) >> invoked from within >> "require allow_aarch64_sve_tests" >> (file "binutils-gdb/gdb/testsuite/gdb.arch/aarch64-sve.exp" line 18) >> invoked from within >> "source binutils-gdb/gdb/testsuite/gdb.arch/aarch64-sve.exp" >> ("uplevel" body line 1) >> invoked from within >> "uplevel #0 source binutils-gdb/gdb/testsuite/gdb.arch/aarch64-sve.exp" >> invoked from within >> "catch "uplevel #0 source $test_file_name"" >> >> --- >> >> When reverting this patch, I no longer see the problem. Maybe it is deleting more than it should? > > Sorry, forgot to mention things work fine if you run the testsuite and the test serialized. If you pass -j2, for example, it > runs into the problem above. Hi, I can reproduce this, thanks for reporting this. It seems that gdb.log and gdb.sum are already there in the standard output file dir when the cleanup happens. I'm thinking about ways to work around this, but haven't come up with anything yet, so for now I've reverted this patch. Thanks, - Tom