From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id 8C89B3858D38 for ; Wed, 25 Jan 2023 17:24:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C89B3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f48.google.com with SMTP id f19-20020a1c6a13000000b003db0ef4dedcso1733169wmc.4 for ; Wed, 25 Jan 2023 09:24:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8F7if1WRDUiBhXGJyuCH7Ma403Dw3k1UzCGVlSZchQ8=; b=CZSlOprDA7hCv5ZfrXN2npC+4bKCKEDQFpoe3HblpIiDBmglZTWGvRZ8Sm3GfM3Nol 2qW0ZL9uoLfJqS8pahxsXnUxn+0pugd4DYr2VB19T7gQDhPVOWfWj2/OIVvFXS+Z8+M6 +JFR2x8CcYRn+6o/E+wWbtjGLuDV0+07gFQ+QyMazOJQeizRjLiBFj02M6WgGwcCu+Hl PXR2OdbmfouCa4YQNMoPTSpCwA0avocI33Q3jL6ZQ574eJjvsqXxLGfjkQ7GEmD+72TO cZgxLxV2CxBka/5ntUzDhjVZnTOZpJNepahT7JR0UnVcSsjGk/+IdyDVhCT82ZYwLWkM VXPA== X-Gm-Message-State: AFqh2kp1dcu1o5ItnEmVEK1AVkDCQN0L3EMDEM1CrvOhisidHwz0iQ57 CLStg/jDkByxPx1uw4T6JZkZI7Qhql0dPg== X-Google-Smtp-Source: AMrXdXuVd0AFMQL76X4amoHVWSQ1TRMRb5Cfd+G/6nO0lXJF1yNUvDsGT1gP7WWIRBCqO12Yf8JqIw== X-Received: by 2002:a05:600c:995:b0:3da:f4f5:ad0e with SMTP id w21-20020a05600c099500b003daf4f5ad0emr31879987wmp.9.1674667449559; Wed, 25 Jan 2023 09:24:09 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id l21-20020a05600c4f1500b003b47b80cec3sm2690886wmq.42.2023.01.25.09.24.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 09:24:09 -0800 (PST) Subject: Re: [PATCH 1/2 version 3] fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp To: Ulrich Weigand , "gdb-patches@sourceware.org" , "will_schmidt@vnet.ibm.com" , Bruno Larsen , "cel@us.ibm.com" References: <3e3c9c40f07ab01c79fe10915e76ffa187c42ad9.camel@us.ibm.com> <122f5d2d3db9ef1979b0f8da927d005f32bba82c.camel@us.ibm.com> <011768e8-2b76-f8ed-1174-fbaa020b15e7@redhat.com> <58cebd1a-7883-fbc6-ac94-c67293f8fc8d@redhat.com> <5e5dc4a49aa8feb370419a1efecf277673b7dfc7.camel@us.ibm.com> <610d5f171d5f4baeb94887217e69d0e6d70e9d66.camel@us.ibm.com> <873eb58a-a6ab-08b2-0827-ca6e0c8088ae@palves.net> <8c4ebc33-f7b5-14a3-3bb0-155fe03e92d8@redhat.com> <837e302b-3ac3-67bd-5314-55194ab35421@redhat.com> <1b995d4378b1e656caffc8682b1f3d66317ab92e.camel@de.ibm.com> From: Pedro Alves Message-ID: <2e7ed874-0d1f-6c28-010c-6dab7641ed73@palves.net> Date: Wed, 25 Jan 2023 17:24:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1b995d4378b1e656caffc8682b1f3d66317ab92e.camel@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-25 5:13 p.m., Ulrich Weigand wrote: >> Breakpoint 1, func2 (i=1) at finish.c:8 >> 8 return i + 1; >> (gdb) step >> 9 } <<< stopped a line bounary, and stepped over the func1 call as well! >> (gdb) p $pc >> $3 = (void (*)()) 0x55555555514d > So this is still at the return in func2, Whoops, the example that I quickly typed up didn't actually have an explicit return line when I first tried it (it returned void), and then I thought of adding one and I added it I missed that I now needed one extra step to get out of func, thinking I was at the last line of main already. > but you're right, > the next step brings us directly to func1 without stopping > in main at all. This is indeed unlike finish. > Exactly. >> I disagree. > OK, you've convinced me as well. Sorry for the confusion ... No worries!