From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@polymtl.ca>
Cc: SiZiOUS <sizious@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH][PR build/23568] Fix gdb-7.12.1 MinGW/MSYS build issue
Date: Wed, 29 Aug 2018 17:46:00 -0000 [thread overview]
Message-ID: <2ec5e4ef-ecc8-5eaa-6437-c1d29a6ff079@redhat.com> (raw)
In-Reply-To: <87va7t3zuk.fsf@tromey.com>
On 08/29/2018 05:24 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
>>> And I know, the MinGW/MSYS original project is maintained but almost
>>> deprecated in favour of MinGW-w64/MSYS2 project. But I really need XP
>>> support for my needs.
>>> I proposed this patch because it's really simple and not intrusive,
>>> but you're right, how many people uses that old MinGW/MSYS project?
>
> Simon> If the missing definition is indeed a mingw bug, but there is really
> Simon> no way of getting a new mingw release with that fixed because the
> Simon> project is unmaintained (but still useful to some people), I would not
> Simon> be against a patch like what you proposed. I would however add a
> Simon> clear comment for why this is needed, so that if some day we
> Simon> officially decide not to support this mingw, we can remove it.
>
> Also, is there any downside to the original patch?
> If not then I think we might as well accept it, subject to Simon's
> request here.
AFAICT, we don't know for sure whether it's necessary on the master
branch. The issue reported at <https://sourceware.org/bugzilla/show_bug.cgi?id=23583>
seems similar, but the patch will not fix it, making it pointless on its own.
It's possible that identifying a fix for the gnulib side may reveal
a different fix for the gdb side accordingly.
SiZiOUS can you try building the git master branch, or a recent
snapshot? See:
https://sourceware.org/gdb/current/
For example:
ftp://sourceware.org/pub/gdb/snapshots/current/gdb-8.2.50.20180829.tar.xz
The best would be current git master (or wait for a snapshot tomorrow),
because we just updated the gnulib copy in our tree.
Also, why do we need the #ifndef? Would unconditionally
include winerr.h cause problems?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-08-29 17:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 12:01 SiZiOUS
2018-08-28 16:57 ` Pedro Alves
2018-08-28 17:22 ` Eli Zaretskii
2018-08-28 22:19 ` SiZiOUS
2018-08-29 8:04 ` SiZiOUS
2018-09-09 20:06 ` Eli Zaretskii
[not found] ` <ddb12e03-7fc3-bf4b-cd24-235b43c33d38@gmail.com>
2018-12-02 13:52 ` SiZiOUS
2018-08-29 15:50 ` Simon Marchi
2018-08-29 16:19 ` Eli Zaretskii
2018-08-29 16:25 ` Tom Tromey
2018-08-29 17:01 ` SiZiOUS
2018-08-29 17:46 ` Pedro Alves [this message]
2018-08-29 16:59 ` SiZiOUS
2018-08-29 18:27 ` Pedro Alves
2018-08-29 21:07 ` SiZiOUS
2018-08-29 17:54 ` Pedro Alves
2018-08-29 18:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ec5e4ef-ecc8-5eaa-6437-c1d29a6ff079@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=sizious@gmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).