From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id D40F03858D1E for ; Wed, 14 Jun 2023 10:54:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D40F03858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4f619c2ba18so7896001e87.1 for ; Wed, 14 Jun 2023 03:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686740079; x=1689332079; h=in-reply-to:from:cc:references:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=bkDUXLpuOlNMamKbYS34THnfW4xk/PPKmrQ9sIJV2JM=; b=NVSp54DavPhuiAA8itvNSwdZd+sbMmcc9yaiY0gmQtY4je1VUpOAGktI7jGjKSkLVN O8dncaL+3B5iA+40aYjHb8rvYNsXNpC52KMbDWI7AD5iQJ6rBAv+ozMVBy10mUoNO8vm iFhRLcBvsbcDSTS0PNFbRzsCJlTVtosk8p/s5BdpTRnw15efouklQDKmWvMuDKAewCuk 2V0NttTenW4j3GSubHIeKWjmcL6strdYrPi7OSJTXU93Axw3nL8MlKZMsQlGRdhYvs37 7DCPbgfA0MemJ27A16PAnzh/2NF4t6SIeDx4RQsor/DCVSGpiwFYmQ2weh/LI2L/DcHh 5/eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686740079; x=1689332079; h=in-reply-to:from:cc:references:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bkDUXLpuOlNMamKbYS34THnfW4xk/PPKmrQ9sIJV2JM=; b=G/4L7lodx4twab3lOA8HyuVvBRSW2HmkWoxRWwA4t806dH40P7TYNIS0ESajrc9XdS u/xfACPq/MUuBejdi46n72Xbn7h2/ryeeCyAuat/+x2LjRFtUHupilIzum0sHefGVNbX Cwp3FgHBikC8uThb+EmhLRG5T4Ijj4sT3CXViGtQ6edX2deKjRUnmTzX32Q+99VEE+Yq objS3csqQO4Sz/QvaXehXz2Falggo1figyQNY00jpEh/OUhHtSG/P8b93GULE/vxUjUh 0IHYZBxO6KHpxFDISGMYWiLgr4zN78ECZtnPOD2t/AoGffkzU63NSJAzXU3AefpEm912 00JQ== X-Gm-Message-State: AC+VfDymTQOk0REqSvP4mD1nk1Rtj+IazauJcZSUa9tNI6Yl/StL6pqh Jb030/9j3fLdNTf1ZYIphDw= X-Google-Smtp-Source: ACHHUZ7Ma1V2sZRXkkhpMdVaVQ7KJKhY9FkMbKcv/W/B95A3x7ZfzmCxQz2VEUVxvhcRjG0RtLkn/g== X-Received: by 2002:a19:e349:0:b0:4f5:bc19:68e8 with SMTP id c9-20020a19e349000000b004f5bc1968e8mr6145980lfk.54.1686740079134; Wed, 14 Jun 2023 03:54:39 -0700 (PDT) Received: from [192.168.1.20] (78-73-77-63-no2450.tbcn.telia.com. [78.73.77.63]) by smtp.gmail.com with ESMTPSA id n24-20020a195518000000b004f608eb50d1sm15423lfe.299.2023.06.14.03.54.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 03:54:38 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------iQdEPKhcOMPrDob1fHy9orKE" Message-ID: <2f1611d0-58d9-93ac-e442-eabdb9fdd1ae@gmail.com> Date: Wed, 14 Jun 2023 12:54:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2] gdb/dap - Add support for additional target types Content-Language: en-US To: Tom Tromey References: <20230613120628.49014-1-simon.farre.cx@gmail.com> <87a5x35i25.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Simon Farre In-Reply-To: <87a5x35i25.fsf@tromey.com> X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------iQdEPKhcOMPrDob1fHy9orKE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > I don't really understand this part of the implementation. > > However, I was wondering if we really want to bother with all this. > Perhaps instead we should just have the clients pass any old "target" > argument as a string and have gdb invoke '"target " + client_string'. > I guess I don't see a whole lot of value in trying to separate out the > various parameters somehow. I think you're right actually. I looked over the other `target` commands and it seems as though they all take just 1 parameter, which makes this implementation superfluous/over-designed. I think the simple string approach, where the user passes `remote ` or `extended-remote ` is better. --------------iQdEPKhcOMPrDob1fHy9orKE--